Received-SPF: pass (google.com: domain of linux-kernel+bounces-17983-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Shinas Rasheed <srasheed@marvell.com>
To: Simon Horman <horms@kernel.org>
CC: Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Haseeb Gani <hgani@marvell.com>, Vimlesh
 Kumar <vimleshk@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        "egallen@redhat.com" <egallen@redhat.com>,
        "mschmidt@redhat.com"
	<mschmidt@redhat.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "wizhao@redhat.com" <wizhao@redhat.com>,
        "kheib@redhat.com"
	<kheib@redhat.com>,
        "konguyen@redhat.com" <konguyen@redhat.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Satananda Burla
	<sburla@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet
	<edumazet@google.com>
Subject: RE: [EXT] Re: [PATCH net-next v2 6/8] octeon_ep_vf: add Tx/Rx
 processing and interrupt support
Thread-Topic: [EXT] Re: [PATCH net-next v2 6/8] octeon_ep_vf: add Tx/Rx
 processing and interrupt support
Thread-Index: AQHaNaXX1bcgGLi5HEmdzaZKEl99WrDKNr0AgACszRCAAD9AAIAAQ9OQ
Date: Fri, 5 Jan 2024 15:08:18 +0000
Message-ID: 
 <PH0PR18MB47342CA6504103E68348AE96C7662@PH0PR18MB4734.namprd18.prod.outlook.com>
References: <20231223134000.2906144-1-srasheed@marvell.com>
 <20231223134000.2906144-7-srasheed@marvell.com>
 <20240104130016.47bc1071@kernel.org>
 <PH0PR18MB473450986CAA852218F225F0C7662@PH0PR18MB4734.namprd18.prod.outlook.com>
 <20240105110508.GU31813@kernel.org>
In-Reply-To: <20240105110508.GU31813@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?NvVB0fr84G3FD3nQjqw4jMEpkI5r0S7FctuIujRqkdBrgGAsgHPBBbSA1fSm?=
 =?us-ascii?Q?GJZhUXcKwOSJxSKYd5DvBw4QQu94h8M4JSi9QtxD1JUfWV9u57CQLq7ebiEW?=
 =?us-ascii?Q?wyuNhlzsCUtH8aTbl8hFLN9IGGRFwXjzO25l6vfmTDi9u43OkD2iBQ65pyD+?=
 =?us-ascii?Q?kKqYImNyFiNoxmjRR1wG3572ctG9a+tIrnz+YJw9N5OpBJq5skRv/xgbEUGB?=
 =?us-ascii?Q?P0SQZGVziCxjn88Q+XEpPlXIb+Ti8FoHdskLlKLdZHun9a9IukYh8jqf5mzU?=
 =?us-ascii?Q?C2I/CoJ5PTDGgWfUdrJlp0NWYTiWrkutmfqXrTYOfjMq3+2RoLUkaU/UXR3I?=
 =?us-ascii?Q?PNmvr4HzqU9v6DV3hr+TogMdebPbOT53bZ/yMwu4nO0Kxmaj1pqR/NYafOIw?=
 =?us-ascii?Q?7NcDrCN81IbFV6yWRn12ockgdNp+b6tq+1hAZrSsatzNhxS9WB7NzkHIoN8l?=
 =?us-ascii?Q?D4QpsW+6Anmb6mpWkewnISUorOKcs0hTn5i1FgwXQRDn/Uw+JgqgGKUCLcYY?=
 =?us-ascii?Q?hgT/pqO2LymgAEhkcfGU+xp8/wnuDGYxaLExv3HTmOV+z0bAGG6eMXQo7ESS?=
 =?us-ascii?Q?DRUVSziuTb1hwUUs6mZt3FOhDxoR/VZ9MkmIRLbGLLWrkdUOThtzz66qswPS?=
 =?us-ascii?Q?597hQl0FTlQZeH7ky7Aw3kysI1Eiu2woin2b3YIVmF1VTCwXejt9dX0fEZO/?=
 =?us-ascii?Q?WLn+fbxMNb1+s/E6y8wu6PqVQ/BheAXBgUbtoB480VLbuLy3nSPXg3zjRTRo?=
 =?us-ascii?Q?xxz/DPkYg9sypkan3c3GWsUaT4GrPbf9kQIUfPUxziWt0OwM6GjCBzl2crql?=
 =?us-ascii?Q?dSwlvu7M0V3e4D3StjB5ocEil1hnumY6nB3fqgOaF+/6Ep7lv9ZxNns6jAJo?=
 =?us-ascii?Q?fUxtw+9UDUi59TWoZ4jbrQRhfyM5R2KljGt1XqKZo7WHTld4QQ4q4n1y3S9Y?=
 =?us-ascii?Q?w5o/7ZDgX57DSfyXP7x34KSJv0NQD72ddySK3XA8DYLqfhaR4E2QSZqDFHwr?=
 =?us-ascii?Q?KBEK98I1FEoaSBSe+58kN0XU5io4FOsBjwhJy6eZm/HkPgMWL2IIFVHpVw6J?=
 =?us-ascii?Q?DbMTcSdRb10mRXnx+ezr7ixAWMLwz9zTxHLTjz5mvr3kwS3oynw7xDEyrsZz?=
 =?us-ascii?Q?ePYekMRuHxfuGTo22nyY3eAnAR3VmnHuTZrv9UkZOkzMFUWioytS8MT42PFi?=
 =?us-ascii?Q?grfRiP36Qgf/otpLD76rpGODWd7tT6Xt77f5/ktaCNn9I3CTJIny45C/fK78?=
 =?us-ascii?Q?YdVZBpnomgYofdtZIZCNjIMbvpKxkh3niTB4piCAqa0jv23NoKxcCu3fHAnf?=
 =?us-ascii?Q?hBN7SnmkAzAqE2+3namK3VP9nE0R2oNzIZARlfJfpeHrf4mCvog07Ts6fCKP?=
 =?us-ascii?Q?2PAt75IoDVcONff1f5SrXo+F0av1I2/mYM3AsaNtoDqtXR0m7iwVt6bXO+OF?=
 =?us-ascii?Q?tfeYWu+gVvYWSaX5J0ZOnlic4N5EXhEBbQ7TEmMMox6Pib5DgzTVdpEBelWY?=
 =?us-ascii?Q?q7mTh6AlqBwUjX5zEUVTkWXk2M66b2ieYih007ScAtt0v+ywbu+Y988MeOHh?=
 =?us-ascii?Q?wj3tqEPShEWNmPfv9PjLMagsTtajkW8hS3pbujtB?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4734.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38a79a17-69fa-4246-12ca-08dc0e00267a
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2024 15:08:18.7712
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XGKwWLyMIzV6RyBlhKf0TfjVlnHiX1JpDSEeoJAbEnp4TKsD5gjM7b/cDmy1Q1TOtNScp7XaVbSVsxNM8pIE5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB3887
X-Proofpoint-GUID: fnA4DPxSlZsWtXAEqtthAVbhPmKRTGeN
X-Proofpoint-ORIG-GUID: fnA4DPxSlZsWtXAEqtthAVbhPmKRTGeN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02

Thanks Simon for the comments. Will update in v3

> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Friday, January 5, 2024 4:35 PM
> To: Shinas Rasheed <srasheed@marvell.com>
> Cc: Jakub Kicinski <kuba@kernel.org>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Haseeb Gani <hgani@marvell.com>; Vimlesh Kumar
> <vimleshk@marvell.com>; Sathesh B Edara <sedara@marvell.com>;
> egallen@redhat.com; mschmidt@redhat.com; pabeni@redhat.com;
> wizhao@redhat.com; kheib@redhat.com; konguyen@redhat.com;
> Veerasenareddy Burru <vburru@marvell.com>; Satananda Burla
> <sburla@marvell.com>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>
> Subject: Re: [EXT] Re: [PATCH net-next v2 6/8] octeon_ep_vf: add Tx/Rx
> processing and interrupt support
>=20
> On Fri, Jan 05, 2024 at 07:26:14AM +0000, Shinas Rasheed wrote:
> > Hi Jakub,
> >
> > Thanks for the review!
> >
> > > > +	rx_done =3D octep_vf_oq_process_rx(ioq_vector->oq, budget);
> > >
> > > You should not call Rx processing if budget is 0 at all, please see
> > > NAPI docs. Looks like the function may try to refill Rx buffers with
> > > budget of 0.
> > >
> > If budget is zero, octep_vf_oq_process_rx just wouldn't try to query hw=
 for
> packets. Also since by then, the refill count should have been less than =
refill
> threshold, if not it only flushes free buffers back to the ring, (and tel=
l hw that
> there are more free buffers available which have been processed from mayb=
e
> previous calls - but this seems unlikely and should have been flushed at =
that
> time).
> >
> > > > @@ -114,8 +158,8 @@ static int octep_vf_setup_oq(struct
> octep_vf_device
> > > *oct, int q_no)
> > > >  		goto desc_dma_alloc_err;
> > > >  	}
> > > >
> > > > -	oq->buff_info =3D (struct octep_vf_rx_buffer *)
> > > > -			vzalloc(oq->max_count *
> > > OCTEP_VF_OQ_RECVBUF_SIZE);
> > > > +	oq->buff_info =3D vzalloc(oq->max_count *
> > > OCTEP_VF_OQ_RECVBUF_SIZE);
> > > > +
> > >
> > > bad fixup squash?
> > >
> > Sorry, I didn't understand. Can you explain?
>=20
> I think he means that this change seems to make a minor update
> to code introduced in a previous patch of this series, and thus should
> be squashed into that previous patch.