Received-SPF: pass (google.com: domain of linux-kernel+bounces-17985-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 5 Jan 2024 15:18:44 +0000
From: Mark Brown <broonie@kernel.org>
To: Karel Balej <karelb@gimli.ms.mff.cuni.cz>
Cc: Karel Balej <balejk@matfyz.cz>, Lee Jones <lee@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Duje =?utf-8?Q?Mihanovi=C4=87?= <duje.mihanovic@skole.hr>,
	~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver
Message-ID: <008ee9d6-6259-43df-9af3-2dc9877cfe94@sirena.org.uk>
References: <20231228100208.2932-1-karelb@gimli.ms.mff.cuni.cz>
 <20231228100208.2932-5-karelb@gimli.ms.mff.cuni.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Z19JQyAf+moSHib9"
Content-Disposition: inline
In-Reply-To: <20231228100208.2932-5-karelb@gimli.ms.mff.cuni.cz>


--Z19JQyAf+moSHib9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 28, 2023 at 10:39:13AM +0100, Karel Balej wrote:

> @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = {
>  		.num_resources = ARRAY_SIZE(pm88x_onkey_resources),
>  		.resources = pm88x_onkey_resources,
>  	},
> +	{
> +		.name = "88pm88x-regulator",
> +		.id = PM88X_REGULATOR_ID_LDO2,
> +		.of_compatible = "marvell,88pm88x-regulator",
> +	},

Why are we adding an of_compatible here?  It's redundant, the MFD split
is a feature of Linux internals not of the hardware, and the existing
88pm8xx MFD doesn't use them.

--Z19JQyAf+moSHib9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWYHdMACgkQJNaLcl1U
h9CmhQf/XJh7ujIuJ4+E3GvWjXwe7MGXOtALsEaqIGC4T2BCAber0xlL7cukDmYc
n7d+xRKRyBKt1w7xZTl9ZJ3q8Y9B2tlf9Gh+GcvcTk9q8xv+7r65NfMzbCJJ8l+l
jr9XfSVl3MXYCJ8Fp4/cuZdz3uifzyUHKSc2zVsETYihrnzPeMPuVBE3RBI4PgZ2
I4fqKaDwEDWmAUcvzIhZuo6+3Hl92xFNlaH7U45m5Y2KloMxzkzUp5lKx7T1Ztgn
xG1VOKREcO8UqksDJz5uig+sgR1CbjxDmf1f/2uTbdWWIz/i6+9FKZ5FbcHNaoms
jSL2gBg5Ou/JXADNybSPGKueWHLZ8g==
=O4ep
-----END PGP SIGNATURE-----

--Z19JQyAf+moSHib9--