Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp219840rdb; Fri, 5 Jan 2024 07:45:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IETg0ME0ttaY4Pghc8j4XIgG7X2OQTe3wO+IKPc19iTnjh20vzkDaILQ6I6zettkgzXSHVW X-Received: by 2002:a25:dc4c:0:b0:dbe:ccd8:562d with SMTP id y73-20020a25dc4c000000b00dbeccd8562dmr459999ybe.45.1704469528663; Fri, 05 Jan 2024 07:45:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704469528; cv=none; d=google.com; s=arc-20160816; b=VEbYHLN/IV3DpS2qTX2UrlqFeNdNLaCPCZM9RH6ROgweGhs0Lq8j4y9UwC0a9rLU6p +MAZWFTk/j8O22vZClsq+I+fdJNYE4K/b6Ko2hRIj/y5LGwUqotNjIXmLtxwZghTvS3w c6Zsa04A4xXCh9yaUIViD5P5kxIyc9q+nByaLZ9fcTmCSCs8h/XqQVhRiTej75hveC15 fk/21+AZ71iaoWxMcwEW8Bdr+s4eWeL4Jpeqb1MWOAgLD+kHIN3Ud6ZiF0fc5qB/ho4k GH6RWcLM5x0HF7OjMb+7MPgkZtwog7ELCRc3yWBSujpl5mF000wIt973AXOjNQlqGZfY A7jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=3w/rFZuEOTHz+qbpgqXvHJOQrhcOEmLTb0+OLq3f2pw=; fh=OqFjLGKCg0tTAB9xRQSFvt73p33mClT86CjqER1dgAA=; b=cPTM0Bz/UWRm8dewrIGPpa6zfZfrFXjrd3Ejua0MzPF1SIoY9AXEuZmeeVxcJ8OKND 1HIQK+CG1+5eCWy8WXUDnpJ8Mv1/0/BVPa0eITpO/kr2cLD8oPSg1mojSqcgixE2KrLf xEExyBMbUHpqCpXgXX3OnyeevnuB1KW+VYp7FQeXW2fUaDbMVjbLV7IRyu1wCouHrs9k U7Wtgop2MJT5l6qbtPmxS76RQCkNsDTjFRECnr42ogFd+RToyIwuT0XMZ5Gu9IiEyktW +kv4LlHhNpuxpfK/Hwbpo2Pet1mspcH1xbFSFaCEJJqKExALlaAGiIZRBxVDu1rUdU2a W3CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YnEAgl1X; spf=pass (google.com: domain of linux-kernel+bounces-18008-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18008-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id x18-20020a0cda12000000b0067f229293f3si2030162qvj.209.2024.01.05.07.45.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 07:45:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18008-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YnEAgl1X; spf=pass (google.com: domain of linux-kernel+bounces-18008-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18008-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 665E51C22E01 for ; Fri, 5 Jan 2024 15:45:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A40DD2E652; Fri, 5 Jan 2024 15:45:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YnEAgl1X" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E95B2E640 for ; Fri, 5 Jan 2024 15:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704469518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3w/rFZuEOTHz+qbpgqXvHJOQrhcOEmLTb0+OLq3f2pw=; b=YnEAgl1XdP3hI9komMRorkhsmfBHfG6q4ct/pEJjYXqFpIdcUTVVBj146nnB+p3Z15NuVc CR2XhVMEDYkCdU1l7SowVAPcOIgkKzEzQoeBuWwaQ/ycqhBEzTfUp2FEr7MHL+2MGrb5QF UbjlPB6UdG1MzSCc7zhMvfibiTnpbaY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-0NIzBHoHP4Gjyp4cwkpPug-1; Fri, 05 Jan 2024 10:45:16 -0500 X-MC-Unique: 0NIzBHoHP4Gjyp4cwkpPug-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40e35cd4d7fso3636935e9.0 for ; Fri, 05 Jan 2024 07:45:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704469515; x=1705074315; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3w/rFZuEOTHz+qbpgqXvHJOQrhcOEmLTb0+OLq3f2pw=; b=gPfmcXlX+Ou1uMQZfzRqrrSI4x1Milced19jvrfjq8qDuq+IuB4SBVz+sSePrM3rbX EVRZtmZ02LReqnMGApG/FxXly94wORApkQElSbR2i+5mRYn8sJL4unTx4JEydnl9331/ 0Hr4bnRxyU81ZyRbO54jAn2QQT4M2gtKH6DPAnzsXTickG7N6EmHhPgfgpvzL547LloZ /+jgEH6vCJWX8fEPO4S3ildN/GIVdn1jyPrqqPZRJal5lbL+giknpUUW8AakelfDSev+ S3rGeLpttkAmuFHfLj2OAP6rzPz8Vc2177PveECzVLCxZNjfIcv0vi0SqEcbSydx1rqY NGiA== X-Gm-Message-State: AOJu0YyBE4d3JSI1PCB0NC4eV/U7SjXjllfGu23YciiEDSyNMUgzdBRw vciKdzJmLvzDHGNhVARMwSksmmoSMjRkAUow6YDCI/GMnbOlTwMpiD0tuRUokRPfvXSMY5Iv1y4 /knZ9BUeDR/v4OXUGTE84f2yeUwEqs2L6 X-Received: by 2002:a05:600c:1384:b0:40d:8893:cede with SMTP id u4-20020a05600c138400b0040d8893cedemr1391728wmf.88.1704469515495; Fri, 05 Jan 2024 07:45:15 -0800 (PST) X-Received: by 2002:a05:600c:1384:b0:40d:8893:cede with SMTP id u4-20020a05600c138400b0040d8893cedemr1391719wmf.88.1704469515079; Fri, 05 Jan 2024 07:45:15 -0800 (PST) Received: from ?IPV6:2003:cb:c705:fb00:4bb9:5362:8a63:a97d? (p200300cbc705fb004bb953628a63a97d.dip0.t-ipconnect.de. [2003:cb:c705:fb00:4bb9:5362:8a63:a97d]) by smtp.gmail.com with ESMTPSA id p7-20020a05600c468700b0040d30af488asm1940071wmo.40.2024.01.05.07.45.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 07:45:14 -0800 (PST) Message-ID: Date: Fri, 5 Jan 2024 16:45:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] WARNING in __folio_rmap_sanity_checks To: "Yin, Fengwei" , Ryan Roberts , syzbot , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Matthew Wilcox References: <000000000000014174060e09316e@google.com> <3feecbd6-b3bd-440c-a4f9-2a7dba3ff8f1@intel.com> <36ace74a-1de7-4224-8bc1-7f487764f6e2@redhat.com> <8bc02927-a0f0-490a-a014-0e100d30ffe4@intel.com> <1eb61435-c89c-4ca1-b1b6-aa00b3478cd2@arm.com> <556f8a4f-c739-41e0-85ec-643a0b32a2ce@redhat.com> <58e2fe0f-b198-4248-9ead-fb5bf4f3edee@intel.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <58e2fe0f-b198-4248-9ead-fb5bf4f3edee@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> vm_normal_page() works on these mappings, so we'd also have to skip rmap >> code when unmapping these pages etc. Maybe that's the whole reason we >> have the rmap handling here: to not special-case the unmap path. > > vm_insert_page() will set VM_MIXEDMAP and vm_normal_page() will skip > the page if CONFIG_ARCH_HAS_PTE_SPECIAL is enabled (it's enabled for > x86). So the unmap path will skip these kind of folios? I think we run into the if (likely(!pte_special(pte))) goto check_pfn; first and return these folios. That also matches the comment of vm_normal_page: "VM_MIXEDMAP mappings can likewise contain memory with or without ... _all_ pages with a struct page (that is, those where pfn_valid is true) are refcounted and considered normal pages by the VM." -- Cheers, David / dhildenb