Received-SPF: pass (google.com: domain of linux-kernel+bounces-18020-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
To: Jason Gunthorpe <jgg@nvidia.com>, "alex.williamson@redhat.com"
	<alex.williamson@redhat.com>
CC: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"yishaih@nvidia.com" <yishaih@nvidia.com>, "kevin.tian@intel.com"
	<kevin.tian@intel.com>, Linuxarm <linuxarm@huawei.com>, liulongfang
	<liulongfang@huawei.com>
Subject: RE: [PATCH] hisi_acc_vfio_pci: Update migration data pointer
 correctly on saving/resume
Thread-Topic: [PATCH] hisi_acc_vfio_pci: Update migration data pointer
 correctly on saving/resume
Thread-Index: AQHaG5IKSxqx627vikqShB0juPG9VbCDRMsAgEhisBA=
Date: Fri, 5 Jan 2024 15:56:09 +0000
Message-ID: <12f92affadf34f048a2eb2e7e9ecd879@huawei.com>
References: <20231120091406.780-1-shameerali.kolothum.thodi@huawei.com>
 <20231120142928.GC6083@nvidia.com>
In-Reply-To: <20231120142928.GC6083@nvidia.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Hi Alex,

Just a gentle ping on this.=20

Thanks,
Shameer

> -----Original Message-----
> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Monday, November 20, 2023 2:29 PM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
> Cc: kvm@vger.kernel.org; linux-kernel@vger.kernel.org;
> alex.williamson@redhat.com; yishaih@nvidia.com; kevin.tian@intel.com;
> Linuxarm <linuxarm@huawei.com>; liulongfang <liulongfang@huawei.com>
> Subject: Re: [PATCH] hisi_acc_vfio_pci: Update migration data pointer cor=
rectly
> on saving/resume
>=20
> On Mon, Nov 20, 2023 at 09:14:06AM +0000, Shameer Kolothum wrote:
> > When the optional PRE_COPY support was added to speed up the device
> > compatibility check, it failed to update the saving/resuming data
> > pointers based on the fd offset. This results in migration data
> > corruption and when the device gets started on the destination the
> > following error is reported in some cases,
> >
> > [  478.907684] arm-smmu-v3 arm-smmu-v3.2.auto: event 0x10 received:
> > [  478.913691] arm-smmu-v3 arm-smmu-v3.2.auto:  0x0000310200000010 [
> > 478.919603] arm-smmu-v3 arm-smmu-v3.2.auto:  0x000002088000007f [
> > 478.925515] arm-smmu-v3 arm-smmu-v3.2.auto:  0x0000000000000000 [
> > 478.931425] arm-smmu-v3 arm-smmu-v3.2.auto:  0x0000000000000000 [
> > 478.947552] hisi_zip 0000:31:00.0: qm_axi_rresp [error status=3D0x1]
> > found [  478.955930] hisi_zip 0000:31:00.0: qm_db_timeout [error
> > status=3D0x400] found [  478.955944] hisi_zip 0000:31:00.0: qm sq
> > doorbell timeout in function 2
> >
> > Fixes: d9a871e4a143 ("hisi_acc_vfio_pci: Introduce support for
> > PRE_COPY state transitions")
> > Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> > ---
> >  drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
>=20
> Jason