Received-SPF: pass (google.com: domain of linux-kernel+bounces-18065-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 5 Jan 2024 16:31:01 +0000
From: Mark Brown <broonie@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regulator: qcom_smd: Keep one rpm handle for all vregs
Message-ID: <b5a2f511-2758-452d-b6ac-399262b3734d@sirena.org.uk>
References: <20231227-topic-rpm_vreg_cleanup-v2-1-04c79c4f9166@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="SHKddNeScMT9u6b/"
Content-Disposition: inline
In-Reply-To: <20231227-topic-rpm_vreg_cleanup-v2-1-04c79c4f9166@linaro.org>


--SHKddNeScMT9u6b/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 03, 2024 at 09:18:37PM +0100, Konrad Dybcio wrote:

> -	rpm = dev_get_drvdata(pdev->dev.parent);
> -	if (!rpm) {
> +	smd_vreg_rpm = dev_get_drvdata(pdev->dev.parent);
> +	if (!smd_vreg_rpm) {
>  		dev_err(&pdev->dev, "Unable to retrieve handle to rpm\n");
>  		return -ENODEV;
>  	}

It'd be slightly more robust to have a check here that we do get the
same RPM back if the variable is already set, just on the off chance
that something changes in some future system and we do end up with a
second RPM somehow.

--SHKddNeScMT9u6b/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWYLsQACgkQJNaLcl1U
h9BhJwf+LNWnV7aYSMGzS9p2rabLoDUBs3Oa3nH9VheBdPCnj+3+D5SWTxGHdGud
87tmCpZqyfU0BuIkjYMtvSdd9YjYLFOGBCSQKA2yTXaOpwyza7YpDxI8HXzXaZwS
FZNX4keO8YbHzSIA5MUn0cx+ilemlombBlFpFXaASR+Mijs8haY6uGfMW/9H0w2k
c5hfwRGAoa/UVnwbdDtNZkSF9UUvi27H8/j1EPICaxm/MMkuse2qliuehRQkIbCq
B2JwOfnvRB5v/OQp5LbRzGyGGcdIhz/j5w/RNs2K9Cz9ImvD1c1a3l6EQTlEFuQN
CQNM2vAUtDebYaOrvTjRNtPqse5XVQ==
=3e40
-----END PGP SIGNATURE-----

--SHKddNeScMT9u6b/--