Received-SPF: pass (google.com: domain of linux-kernel+bounces-18088-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Feedback-ID: i6a694271:Fastmail
Date: Fri, 5 Jan 2024 09:55:43 -0700
From: Daniel Xu <dxu@dxuuu.xyz>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: alexandre.torgue@foss.st.com, benjamin.tissoires@redhat.com,
 	lizefan.x@bytedance.com, Herbert Xu <herbert@gondor.apana.org.au>,
 dsahern@kernel.org, 	hannes@cmpxchg.org, rostedt@goodmis.org,
 mcoquelin.stm32@gmail.com, 	pablo@netfilter.org, martin.lau@linux.dev,
 edumazet@google.com, daniel@iogearbox.net, 	ebiggers@kernel.org,
 yonghong.song@linux.dev, john.fastabend@gmail.com, 	hawk@kernel.org,
 steffen.klassert@secunet.com, jikos@kernel.org, kuba@kernel.org,
 	fw@strlen.de, ast@kernel.org, song@kernel.org, pabeni@redhat.com,
 	shuah@kernel.org, tytso@mit.edu, tj@kernel.org, kadlec@netfilter.org,
 	davem@davemloft.net, mhiramat@kernel.org, andrii@kernel.org,
 	alexei.starovoitov@gmail.com, quentin@isovalent.com,
 alan.maguire@oracle.com, memxor@gmail.com, 	kpsingh@kernel.org,
 sdf@google.com, haoluo@google.com, 	mathieu.desnoyers@efficios.com,
 mykolal@fb.com, linux-input@vger.kernel.org,
 	linux-kernel@vger.kernel.org, fsverity@lists.linux.dev,
 bpf@vger.kernel.org, 	cgroups@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org,
 	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
 linux-kselftest@vger.kernel.org,
 	linux-stm32@st-md-mailman.stormreply.com,
 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH bpf-next v2 3/3] bpf: treewide: Annotate BPF kfuncs in BTF
Message-ID: <4tsn6x45gh3vgdst3ozzmxori5gzylvpx6btxue6sbsmx7siok@6wajzdgwxfpa>
References: <cover.1704422454.git.dxu@dxuuu.xyz>
 <a923e3809955bdfd2bc8d6a103c20e01f1636dbc.1704422454.git.dxu@dxuuu.xyz>
 <ZZgcJTdwMZHglPtr@krava>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZZgcJTdwMZHglPtr@krava>

On Fri, Jan 05, 2024 at 04:11:33PM +0100, Jiri Olsa wrote:
> On Thu, Jan 04, 2024 at 07:45:49PM -0700, Daniel Xu wrote:
> 
> SNIP
> 
> > diff --git a/fs/verity/measure.c b/fs/verity/measure.c
> > index bf7a5f4cccaf..3969d54158d1 100644
> > --- a/fs/verity/measure.c
> > +++ b/fs/verity/measure.c
> > @@ -159,9 +159,9 @@ __bpf_kfunc int bpf_get_fsverity_digest(struct file *file, struct bpf_dynptr_ker
> >  
> >  __bpf_kfunc_end_defs();
> >  
> > -BTF_SET8_START(fsverity_set_ids)
> > +BTF_KFUNCS_START(fsverity_set_ids)
> >  BTF_ID_FLAGS(func, bpf_get_fsverity_digest, KF_TRUSTED_ARGS)
> > -BTF_SET8_END(fsverity_set_ids)
> > +BTF_KFUNCS_END(fsverity_set_ids)
> >  
> >  static int bpf_get_fsverity_digest_filter(const struct bpf_prog *prog, u32 kfunc_id)
> >  {
> > diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> > index 51e8b4bee0c8..8cc718f37a9d 100644
> > --- a/kernel/bpf/btf.c
> > +++ b/kernel/bpf/btf.c
> > @@ -7802,6 +7802,10 @@ int register_btf_kfunc_id_set(enum bpf_prog_type prog_type,
> >  {
> >  	enum btf_kfunc_hook hook;
> >  
> > +	/* All kfuncs need to be tagged as such in BTF */
> > +	if (WARN_ON(!(kset->set->flags & BTF_SET8_KFUNCS)))
> > +		return -EINVAL;
> 
> having the warning for module with wrong set8 flags seems wrong to me,
> I think we should trigger the warn only for kernel calls.. by adding
> kset->owner check in the condition above

Just checking:

The reasoning is that =m and out-of-tree modules can and should check
return code, right?

And =y modules or vmlinux-based registrations do not check return code,
so WARN() is necessary?

If so, I'd agree.

[..]

Thanks,
Daniel