Received-SPF: pass (google.com: domain of linux-kernel+bounces-18172-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20230920192300.3772199-1-goldstein.w.n@gmail.com>
 <202309231130.ZI5MdlDc-lkp@intel.com> <CAFUsyfKDRiX9kKOhHcA4PLqqT6Q5faHF0eRGiKN+9NSbvrUfDw@mail.gmail.com>
 <d02bd4f823534a00ae4915ead3d92773@AcuMS.aculab.com> <CAFUsyfL0M5P4+4s_b1kvJ_fE-ax8YBK0ammbKfoy7yKs1obzrA@mail.gmail.com>
 <CAFUsyfJduB29c6=BNmTtgoWcHAWA1AZ-sdbhyp02JVhvA6Gp0w@mail.gmail.com>
 <CAFUsyfLuo0_Sm91mqbM8Sbo-ncwnM4RaRq=GxQXDmkAN-nQ3uw@mail.gmail.com>
 <CAHk-=wgv6h4ru=z8UR5XyutoRKveOetNpwovHburvRgG9NSa3g@mail.gmail.com>
 <CAHk-=wiNUucmvTKGmveWzXXe99SpOwU65nFtH-A2_aUpPsAPJQ@mail.gmail.com> <5354eeec562345f6a1de84f0b2081b75@AcuMS.aculab.com>
In-Reply-To: <5354eeec562345f6a1de84f0b2081b75@AcuMS.aculab.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri, 5 Jan 2024 10:05:44 -0800
Message-ID: <CAHk-=wg8vssPVO68_qH_BHBCj6_DDawKQHBOgZh4gw5YFmpCKA@mail.gmail.com>
Subject: Re: x86/csum: Remove unnecessary odd handling
To: David Laight <David.Laight@aculab.com>
Cc: Noah Goldstein <goldstein.w.n@gmail.com>, kernel test robot <lkp@intel.com>, 
	"x86@kernel.org" <x86@kernel.org>, 
	"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "edumazet@google.com" <edumazet@google.com>, 
	"tglx@linutronix.de" <tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>, 
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "hpa@zytor.com" <hpa@zytor.com>
Content-Type: multipart/mixed; boundary="0000000000006fb109060e36b317"

--0000000000006fb109060e36b317
Content-Type: text/plain; charset="UTF-8"

On Fri, 5 Jan 2024 at 02:41, David Laight <David.Laight@aculab.com> wrote:
>
> Interesting, I'm pretty sure trying to get two blocks of
>  'adc' scheduled in parallel like that doesn't work.

You should check out the benchmark at

       https://github.com/fenrus75/csum_partial

and see if you can improve on it. I'm including the patch (on top of
that code by Arjan) to implement the actual current kernel version as
"New version".

         Linus

--0000000000006fb109060e36b317
Content-Type: application/octet-stream; name=p
Content-Disposition: attachment; filename=p
Content-Transfer-Encoding: base64
Content-ID: <f_lr0y5drz0>
X-Attachment-Id: f_lr0y5drz0

RnJvbSA2ZmY3ZjdhNzJhNDg1NTk3MGIxNjIxYWM5NzI0YzQ0YzM5M2E2ZDQ0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW51cyBUb3J2YWxkcyA8dG9ydmFsZHNAbGludXgtZm91bmRh
dGlvbi5vcmc+CkRhdGU6IEZyaSwgNSBKYW4gMjAyNCAwOTo0NjozMiAtMDgwMApTdWJqZWN0OiBb
UEFUQ0hdIEFkZCB0aGUgY3VycmVudCBrZXJuZWwgdmVyc2lvbiBhcyAiTmV3IHZlcnNpb24iCgot
LS0KIE1ha2VmaWxlICAgICAgIHwgICAzIC0tCiBjc3VtX3BhcnRpYWwuYyB8IDExNyArKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIDIgZmls
ZXMgY2hhbmdlZCwgMTE1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0
IGEvTWFrZWZpbGUgYi9NYWtlZmlsZQppbmRleCBlNGIxYmIzLi40ZTI5ZjhhIDEwMDY0NAotLS0g
YS9NYWtlZmlsZQorKysgYi9NYWtlZmlsZQpAQCAtMTcsNiArMTcsMyBAQCBjaGFpbjIuc3ZnOiBn
cmFwaHMvY2hhaW4yLmRvdAogY2hhaW4yYS5zdmc6IGdyYXBocy9jaGFpbjJhLmRvdAogCWRvdCAt
VHN2ZyAtTyBncmFwaHMvY2hhaW4yYS5kb3QgIAogCW12IGdyYXBocy9jaGFpbjJhLmRvdC5zdmcg
Y2hhaW4yYS5zdmcKLQkKLQkKLQkKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1n
aXQgYS9jc3VtX3BhcnRpYWwuYyBiL2NzdW1fcGFydGlhbC5jCmluZGV4IDRkYjBkOTcuLmRkZjZh
Y2QgMTAwNjQ0Ci0tLSBhL2NzdW1fcGFydGlhbC5jCisrKyBiL2NzdW1fcGFydGlhbC5jCkBAIC0x
NCwxMyArMTQsMjggQEAKICNpbmNsdWRlIDx0aW1lLmg+CiAKIHR5cGVkZWYgdWludDMyX3QgX193
c3VtOwordHlwZWRlZiB1aW50MzJfdCBfX3UzMjsKK3R5cGVkZWYgdWludDY0X3QgX191NjQ7CiB0
eXBlZGVmIHVpbnQ2NF90IHU2NDsKIHR5cGVkZWYgdWludDMyX3QgdTMyOworIyBkZWZpbmUgbGlr
ZWx5KHgpIF9fYnVpbHRpbl9leHBlY3QoISEoeCksIDEpCiAjIGRlZmluZSB1bmxpa2VseSh4KSBf
X2J1aWx0aW5fZXhwZWN0KCEhKHgpLCAwKQogCisjZGVmaW5lIF9fZm9yY2UKKwogI2RlZmluZSBM
T09QQ09VTlQgMTAyNDAwCiAjZGVmaW5lIFBBQ0tFVFNJWkUgNDAKIAorLyoqCisgKiByb3I2NCAt
IHJvdGF0ZSBhIDY0LWJpdCB2YWx1ZSByaWdodAorICogQHdvcmQ6IHZhbHVlIHRvIHJvdGF0ZQor
ICogQHNoaWZ0OiBiaXRzIHRvIHJvbGwKKyAqLworc3RhdGljIGlubGluZSBfX3U2NCByb3I2NChf
X3U2NCB3b3JkLCB1bnNpZ25lZCBpbnQgc2hpZnQpCit7CisJcmV0dXJuICh3b3JkID4+IChzaGlm
dCAmIDYzKSkgfCAod29yZCA8PCAoKC1zaGlmdCkgJiA2MykpOworfQorCiBzdGF0aWMgaW5saW5l
IHVuc2lnbmVkIGxvbmcgbG9hZF91bmFsaWduZWRfemVyb3BhZChjb25zdCB2b2lkICphZGRyKQog
ewogCXVuc2lnbmVkIGxvbmcgcmV0LCBkdW1teTsKQEAgLTQ4NCw3ICs0OTksMTA1IEBAIHN0YXRp
YyBpbmxpbmUgX193c3VtIG51bGx0ZXN0KGNvbnN0IHZvaWQgKmJ1ZmYsIGludCBsZW4sIF9fd3N1
bSBzdW0pCiB7CiAJcmV0dXJuIDI7CiB9CitzdGF0aWMgaW5saW5lIF9fd3N1bSBjc3VtX2ZpbmFs
aXplX3N1bSh1NjQgdGVtcDY0KQoreworCXJldHVybiAoX19mb3JjZSBfX3dzdW0pKCh0ZW1wNjQg
KyByb3I2NCh0ZW1wNjQsIDMyKSkgPj4gMzIpOworfQogCitzdGF0aWMgaW5saW5lIHVuc2lnbmVk
IGxvbmcgdXBkYXRlX2NzdW1fNDBiKHVuc2lnbmVkIGxvbmcgc3VtLCBjb25zdCB1bnNpZ25lZCBs
b25nIG1bNV0pCit7CisJYXNtKCJhZGRxICUxLCUwXG5cdCIKKwkgICAgICJhZGNxICUyLCUwXG5c
dCIKKwkgICAgICJhZGNxICUzLCUwXG5cdCIKKwkgICAgICJhZGNxICU0LCUwXG5cdCIKKwkgICAg
ICJhZGNxICU1LCUwXG5cdCIKKwkgICAgICJhZGNxICQwLCUwIgorCQk6IityIiAoc3VtKQorCQk6
Im0iIChtWzBdKSwgIm0iIChtWzFdKSwgIm0iIChtWzJdKSwKKwkJICJtIiAobVszXSksICJtIiAo
bVs0XSkpOworCXJldHVybiBzdW07Cit9CisKKy8qCisgKiBEbyBhIGNoZWNrc3VtIG9uIGFuIGFy
Yml0cmFyeSBtZW1vcnkgYXJlYS4KKyAqIFJldHVybnMgYSAzMmJpdCBjaGVja3N1bS4KKyAqCisg
KiBUaGlzIGlzbid0IGFzIHRpbWUgY3JpdGljYWwgYXMgaXQgdXNlZCB0byBiZSBiZWNhdXNlIG1h
bnkgTklDcworICogZG8gaGFyZHdhcmUgY2hlY2tzdW1taW5nIHRoZXNlIGRheXMuCisgKgorICog
U3RpbGwsIHdpdGggQ0hFQ0tTVU1fQ09NUExFVEUgdGhpcyBpcyBjYWxsZWQgdG8gY29tcHV0ZQor
ICogY2hlY2tzdW1zIG9uIElQdjYgaGVhZGVycyAoNDAgYnl0ZXMpIGFuZCBvdGhlciBzbWFsbCBw
YXJ0cy4KKyAqIGl0J3MgYmVzdCB0byBoYXZlIGJ1ZmYgYWxpZ25lZCBvbiBhIDY0LWJpdCBib3Vu
ZGFyeQorICovCitfX3dzdW0gY3N1bV9wYXJ0aWFsX25ldyhjb25zdCB2b2lkICpidWZmLCBpbnQg
bGVuLCBfX3dzdW0gc3VtKQoreworCXU2NCB0ZW1wNjQgPSAoX19mb3JjZSB1NjQpc3VtOworCisJ
LyogRG8gdHdvIDQwLWJ5dGUgY2h1bmtzIGluIHBhcmFsbGVsIHRvIGdldCBiZXR0ZXIgSUxQICov
CisJaWYgKGxpa2VseShsZW4gPj0gODApKSB7CisJCXU2NCB0ZW1wNjRfMiA9IDA7CisJCWRvIHsK
KwkJCXRlbXA2NCA9IHVwZGF0ZV9jc3VtXzQwYih0ZW1wNjQsIGJ1ZmYpOworCQkJdGVtcDY0XzIg
PSB1cGRhdGVfY3N1bV80MGIodGVtcDY0XzIsIGJ1ZmYgKyA0MCk7CisJCQlidWZmICs9IDgwOwor
CQkJbGVuIC09IDgwOworCQl9IHdoaWxlIChsZW4gPj0gODApOworCisJCWFzbSgiYWRkcSAlMSwl
MFxuXHQiCisJCSAgICAiYWRjcSAkMCwlMCIKKwkJICAgIDoiK3IiICh0ZW1wNjQpOiAiciIgKHRl
bXA2NF8yKSk7CisJfQorCisJLyoKKwkgKiBsZW4gPT0gNDAgaXMgdGhlIGhvdCBjYXNlIGR1ZSB0
byBJUHY2IGhlYWRlcnMsIHNvIHJldHVybgorCSAqIGVhcmx5IGZvciB0aGF0IGV4YWN0IGNhc2Ug
d2l0aG91dCBjaGVja2luZyB0aGUgdGFpbCBieXRlcy4KKwkgKi8KKwlpZiAobGVuID49IDQwKSB7
CisJCXRlbXA2NCA9IHVwZGF0ZV9jc3VtXzQwYih0ZW1wNjQsIGJ1ZmYpOworCQlsZW4gLT0gNDA7
CisJCWlmICghbGVuKQorCQkJcmV0dXJuIGNzdW1fZmluYWxpemVfc3VtKHRlbXA2NCk7CisJCWJ1
ZmYgKz0gNDA7CisJfQorCisJaWYgKGxlbiAmIDMyKSB7CisJCWFzbSgiYWRkcSAwKjgoJVtzcmNd
KSwlW3Jlc11cblx0IgorCQkgICAgImFkY3EgMSo4KCVbc3JjXSksJVtyZXNdXG5cdCIKKwkJICAg
ICJhZGNxIDIqOCglW3NyY10pLCVbcmVzXVxuXHQiCisJCSAgICAiYWRjcSAzKjgoJVtzcmNdKSwl
W3Jlc11cblx0IgorCQkgICAgImFkY3EgJDAsJVtyZXNdIgorCQkgICAgOiBbcmVzXSAiK3IiKHRl
bXA2NCkKKwkJICAgIDogW3NyY10gInIiKGJ1ZmYpLCAibSIoKihjb25zdCBjaGFyKCopWzMyXSli
dWZmKSk7CisJCWJ1ZmYgKz0gMzI7CisJfQorCWlmIChsZW4gJiAxNikgeworCQlhc20oImFkZHEg
MCo4KCVbc3JjXSksJVtyZXNdXG5cdCIKKwkJICAgICJhZGNxIDEqOCglW3NyY10pLCVbcmVzXVxu
XHQiCisJCSAgICAiYWRjcSAkMCwlW3Jlc10iCisJCSAgICA6IFtyZXNdICIrciIodGVtcDY0KQor
CQkgICAgOiBbc3JjXSAiciIoYnVmZiksICJtIigqKGNvbnN0IGNoYXIoKilbMTZdKWJ1ZmYpKTsK
KwkJYnVmZiArPSAxNjsKKwl9CisJaWYgKGxlbiAmIDgpIHsKKwkJYXNtKCJhZGRxIDAqOCglW3Ny
Y10pLCVbcmVzXVxuXHQiCisJCSAgICAiYWRjcSAkMCwlW3Jlc10iCisJCSAgICA6IFtyZXNdICIr
ciIodGVtcDY0KQorCQkgICAgOiBbc3JjXSAiciIoYnVmZiksICJtIigqKGNvbnN0IGNoYXIoKilb
OF0pYnVmZikpOworCQlidWZmICs9IDg7CisJfQorCWlmIChsZW4gJiA3KSB7CisJCXVuc2lnbmVk
IGludCBzaGlmdCA9ICgtbGVuIDw8IDMpICYgNjM7CisJCXVuc2lnbmVkIGxvbmcgdHJhaWw7CisK
KwkJdHJhaWwgPSAobG9hZF91bmFsaWduZWRfemVyb3BhZChidWZmKSA8PCBzaGlmdCkgPj4gc2hp
ZnQ7CisKKwkJYXNtKCJhZGRxICVbdHJhaWxdLCVbcmVzXVxuXHQiCisJCSAgICAiYWRjcSAkMCwl
W3Jlc10iCisJCSAgICA6IFtyZXNdICIrciIodGVtcDY0KQorCQkgICAgOiBbdHJhaWxdICJyIih0
cmFpbCkpOworCX0KKwlyZXR1cm4gY3N1bV9maW5hbGl6ZV9zdW0odGVtcDY0KTsKK30KIAogZG91
YmxlIGN5Y2xlc1s2NF07CiBpbnQgY3ljbGVjb3VudFs2NF07CkBAIC02MTIsNiArNzI1LDcgQEAg
aW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogCiAJTUVBU1VSRSgyLCAgY3N1bV9wYXJ0
aWFsLCAiVXBjb21pbmcgbGludXgga2VybmVsIHZlcnNpb24iKTsKIAlNRUFTVVJFKDQsICBjc3Vt
X3NwZWNpYWxpemVkLCAiU3BlY2lhbGl6ZWQgdG8gc2l6ZSA0MCIpOworCU1FQVNVUkUoNiwgIGNz
dW1fcGFydGlhbF9uZXcsICJOZXcgdmVyc2lvbiIpOwogCU1FQVNVUkUoMjIsIGNzdW1fcGFydGlh
bF9ub19vZGQsICJPZGQtYWxpZ25tZW50IGhhbmRsaW5nIHJlbW92ZWQiKTsKIAlNRUFTVVJFKDI0
LCBjc3VtX3BhcnRpYWxfZGVhZF9jb2RlLCAiRGVhZCBjb2RlIGVsaW1pbmF0aW9uICAgICAgICAg
ICAiKTsKIAlNRUFTVVJFKDI4LCBjc3VtX3BhcnRpYWxfQUNYLCAiQURYIGludGVybGVhdmVkICIp
OwpAQCAtNjE5LDcgKzczMyw2IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKIAlN
RUFTVVJFKDM0LCBjc3VtX3BhcnRpYWxfMzJiaXQsICIzMiBiaXQgdHJhaW4gIik7CiAJTUVBU1VS
RSgzNiwgY3N1bV9wYXJ0aWFsX3plcm9fc3VtLCAiQXNzdW1lIHplcm8gaW5wdXQgc3VtIik7CiAK
LQogCXJlcG9ydCgpOwogCX0KLX0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCit9Cg==
--0000000000006fb109060e36b317--