Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp308152rdb; Fri, 5 Jan 2024 10:26:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7xdi821CHmKnzVk/i7hj2FvsbA6XS/B1PpvgaG6tjFPc0V1ViHuE0JwoKdg5jpkHxV3i8 X-Received: by 2002:ac8:65d3:0:b0:429:796f:ca73 with SMTP id t19-20020ac865d3000000b00429796fca73mr1253279qto.66.1704479185358; Fri, 05 Jan 2024 10:26:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704479185; cv=none; d=google.com; s=arc-20160816; b=lspNDBnDEDtnVNrP7KgDLH5zUc7/eNqVIGMbOeRokm/XIF9x0iyL5VYIxq+osPL1AC VXUJal7k8yoQTkcI8Sz/S4TUzK+SlQfJTlGmnu7V3JixAmEC2YPEpBhPyHN6ALTxqlhR i7Gf6ZJ4CfJ+9dWx4pAJktt1kBI+gw4HFRDmLTIT8OJH0tC24EEZvt/CpjhsDduM5ndG JIxkJrvhFXuhZbrlN1j7TBnvJrJPJvcvb++HGsesCUIDmCn7MorlmHemSToOipPcDmkK WcWMqP8wI8OH3zWt2e7cdKtz6rjBrpiMdNlvKU0cvi/9EWvjWWOFjkprnDvcrcQjETgJ REeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5BMj5Iz3wdXa6D+MS5XuodEdktSJXSEeyg/bc4ogn1Y=; fh=dAP1BFvD7nKob57ikshM4KZs/Bjj5mYcuaNrrOHWX+I=; b=PJrfQ0IGIUja1PmEtBcCnFjqgTYU8goK9UAIiMr6uzx/SEyLc5tCilitm+fh9x3OiK uXVF5fN3biQnnVAzilPHGSqHXJzlnpqV7jhEwAkiJHwRZ3BpAnI+WBIpmbi7RBvfkiHj 447gEKg4QU4Yz6ikKLEU1Lgq8vam/QRFOUU2Gq8wk1TnlR8dl1hD/r2+iR5hfeEUC8L9 38ISc94UHPfsDRNOk96QFqJcdYRO0RJFtEXkLlK11VIr+fiw9ffZ8gi5WBT3QV4zIPs9 ChBmMivYeORD3FrjOCvykiH88XIzzG4g405AExOFS47p9ax8Mz5zFEipHrvQIAxG1Nuk jm0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vIE+JqRF; spf=pass (google.com: domain of linux-kernel+bounces-18210-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18210-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 14-20020ac84e8e000000b00427fbd5d69esi2380371qtp.511.2024.01.05.10.26.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 10:26:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18210-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vIE+JqRF; spf=pass (google.com: domain of linux-kernel+bounces-18210-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18210-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 25CFF1C23282 for ; Fri, 5 Jan 2024 18:26:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 28044358A2; Fri, 5 Jan 2024 18:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vIE+JqRF" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5718D3588B; Fri, 5 Jan 2024 18:26:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7C7AC433C7; Fri, 5 Jan 2024 18:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704479174; bh=42Aj2xzoqSAIt6/8r6LJJBpe/usERH1YJszj2babSjc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vIE+JqRFoaDeQnDBIfawuUEXj/Am5PxDdsPj28PpA7O1kef1I3cmYEPslrRoVkXQI TrWFwlYbm4zLC+ZSUF4mY4+NdJBZ9LCB5WAB9NB/8ex007q3JhRXN8ya1TClNok2/e WPBFv9oaqSfss+Ufn0sHqlTgb5u3Fd5JLXpT0nNRb0Bcp65upQuoyAxmZb4UGYjhMA 3sA+2PO7sj7WCpd7Hia2FSKbIuo3ryG09D6/N5y0372A4O98S0CscoWqtOVMNcC1P6 Rnu6JhYnP6TG5E8UcMiestOauuWklZtkmdWYeJg8FNlg0QwZPt5QTCiKxgqak5wvV5 BKE3hJZJng7uw== Date: Fri, 5 Jan 2024 18:26:10 +0000 From: Simon Horman To: Christian Marangi Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v4 2/4] net: phy: at803x: refactor qca808x cable test get status function Message-ID: <20240105182610.GW31813@kernel.org> References: <20240104213044.4653-1-ansuelsmth@gmail.com> <20240104213044.4653-3-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104213044.4653-3-ansuelsmth@gmail.com> On Thu, Jan 04, 2024 at 10:30:39PM +0100, Christian Marangi wrote: > Refactor qca808x cable test get status function to remove code > duplication and clean things up. > > The same logic is applied to each pair hence it can be generalized and > moved to a common function. > > Signed-off-by: Christian Marangi Reviewed-by: Simon Horman