Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp309157rdb; Fri, 5 Jan 2024 10:28:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUAYM7HfkPZqEMUZ6A89Gxo+XThW6RYjTCaX+rhLz6hd5D85uXM5MBd03iCyyzkmQ+WVwX X-Received: by 2002:a05:620a:2b4c:b0:783:783:1ea3 with SMTP id dp12-20020a05620a2b4c00b0078307831ea3mr2315014qkb.69.1704479335859; Fri, 05 Jan 2024 10:28:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704479335; cv=none; d=google.com; s=arc-20160816; b=wd565TQL5vKe9t7lIrDiR/wBLZiz30/+CYV+xnL/3HwylnX1wc8q1HQlkXQNNhLRJM qs1dXqwgYA72E6txjCA0QXXBWpfCifMO+2XRo/5ssJhvrD5ua5xMElGtrXpo47moorWg V2ePEOCXFDsLaKcSH2ZlMqNBmOILHVWP8wQwGx/w4OyB/s/hWh2scl2H1ZQit2169iUt ylUEswpbjVMCIj6uI3cQ+TyKgQwE7FLpHZwcb+1AlTHiYnr+UQN79deIUu95zOI8VoGk JL/C2MBphFzxyfXWh7Fjl2BsUzLKEY7yDa1/hbSxL+/4Itl6DkeGSpmSi5dm7ve7lhUX hTIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jqv1tM4AgIDT1sOCz+/zoV+TRle3R79piLyUJwKuXMw=; fh=dAP1BFvD7nKob57ikshM4KZs/Bjj5mYcuaNrrOHWX+I=; b=IXRwicTq3OA+rq9cOkD9P6NmIS/HGCYEzsg8teiwvf+CBSUilGmEepEFCAhotUKA2+ omcdnO97l0Kw7gLo8k3BRLbLsqRJJn7WsMIGS8CQdVdKvmZ63kz5lGqoBRUKttHPRQol bsQLhuRpFYhNuBgJN6tLJopg5WtSr5MJBTNvrmsd/HTy4jTaDJx4++RCgGErmfaA5dRF 3pnUYl/EaH2Rwq+c8qiDGpXFonXd9knYHAEziGAJshq6BwgWTLo2en12oknYLKKGttcj UOTHqGa9AQHfX1pHzIiBm3cXE2ZtR4CFwFUmg3yw83OqM38yZqLg/hItEynGY2OrpIqL 3xfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uoiuRVwE; spf=pass (google.com: domain of linux-kernel+bounces-18215-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18215-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id r8-20020a05620a03c800b0077dcf0e1604si2151106qkm.717.2024.01.05.10.28.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 10:28:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18215-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uoiuRVwE; spf=pass (google.com: domain of linux-kernel+bounces-18215-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18215-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9C98E1C21815 for ; Fri, 5 Jan 2024 18:28:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D17EA35EEF; Fri, 5 Jan 2024 18:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uoiuRVwE" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CA043588D; Fri, 5 Jan 2024 18:28:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92373C433C8; Fri, 5 Jan 2024 18:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704479318; bh=UWZ9g69LqblqTIx2GsfZYc5KFDWrnQY+MHpPKLD/9kM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uoiuRVwEFI/Jv8ITCVQiIftCwl5eJYf9CHolDmSmwwFjBxiekrtFNdx40Hn0XwKlu J3FskHOaV6alK/FmOI2lJOnAnd6JyqRzfxhFrnylY6AsLUMb4deWwcpGJlnnXYmHSg kQaEbbtmZJpAmEw4FSdg/QlHwp+G2CR5R+GcbU4mUF6gYXjJ/Eb+8cmy0c7kYa9B15 0f5yU2PZgT5FgwKyGd96Cu3A98uiwH9hc3FaMbczSC54Pf9rfUCfcTiOZ8hyvKGfBi TOISPT4tpbsnaPZbZgQ//dUwJD5Tnrz+oplNjiGcmxLrjtYGeGJuIfX+HKe31ZF7Co 8Agxh9Y3iu6Ww== Date: Fri, 5 Jan 2024 18:28:34 +0000 From: Simon Horman To: Christian Marangi Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v4 4/4] net: phy: at803x: make read_status more generic Message-ID: <20240105182834.GY31813@kernel.org> References: <20240104213044.4653-1-ansuelsmth@gmail.com> <20240104213044.4653-5-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104213044.4653-5-ansuelsmth@gmail.com> On Thu, Jan 04, 2024 at 10:30:41PM +0100, Christian Marangi wrote: > Make read_status more generic in preparation on moving it to shared > library as other PHY Family Driver will have the exact same > implementation. > > The only specific part was a check for AR8031/33 if 1000basex was used. > The check is moved to a dedicated function specific for those PHYs. > > Signed-off-by: Christian Marangi Reviewed-by: Simon Horman