Received-SPF: pass (google.com: domain of linux-kernel+bounces-18290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 5 Jan 2024 20:11:50 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Philipp Stanner <pstanner@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>, 
	Lucas Stach <l.stach@pengutronix.de>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, 
	Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, 
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Shawn Guo <shawnguo@kernel.org>, 
	Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, 
	Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, 
	Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>, David Gow <davidgow@google.com>, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] platform_device: add devres function region-reqs
Message-ID: <5k75ed3czl6rqzkykl7xc4dbyih2frunoor4ypfqxx7yzfs2vd@6ieg4dewtgxf>
References: <20240105172218.42457-2-pstanner@redhat.com>
 <20240105172218.42457-3-pstanner@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3o2nisona3kyspak"
Content-Disposition: inline
In-Reply-To: <20240105172218.42457-3-pstanner@redhat.com>


--3o2nisona3kyspak
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 05, 2024 at 06:22:18PM +0100, Philipp Stanner wrote:
> Some drivers want to use (request) a region exclusively but nevertheless
> create several mappings within that region.
>=20
> Currently, there is no managed devres function to request a region
> without mapping it.
>=20
> Add the function devm_platform_get_resource()
>=20
> Signed-off-by: Philipp Stanner <pstanner@redhat.com>
> ---
>  drivers/base/platform.c         | 37 +++++++++++++++++++++++++++++++++
>  include/linux/platform_device.h |  2 ++
>  2 files changed, 39 insertions(+)
>=20
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 10c577963418..243b9ec54d04 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -82,6 +82,43 @@ struct resource *platform_get_mem_or_io(struct platfor=
m_device *dev,
>  }
>  EXPORT_SYMBOL_GPL(platform_get_mem_or_io);
> =20
> +/**
> + * devm_platform_get_and_resource - get and request a resource

This function name is wrong.

> + *
> + * @pdev: the platform device to get the resource from
> + * @type: resource type (either IORESOURCE_MEM or IORESOURCE_IO)
> + * @num: resource index
> + * @name: name to be associated with the request
> + *
> + * Return: a pointer to the resource on success, an ERR_PTR on failure.
> + *
> + * Gets a resource and requests it. Use this instead of
> + * devm_platform_ioremap_resource() only if you have to create several s=
ingle
> + * mappings with devm_ioremap().
> + */
> +struct resource *devm_platform_get_resource(struct platform_device *pdev,
> +		unsigned int type, unsigned int num, const char *name)
> +{
> +	struct resource *res;
> +
> +	res =3D platform_get_resource(pdev, type, num);
> +	if (!res)
> +		return ERR_PTR(-EINVAL);

=46rom devm_platform_get_resource I'd expect that it only does
platform_get_resource() + register a cleanup function to undo it.

> +	if (type & IORESOURCE_MEM)
> +		res =3D devm_request_mem_region(&pdev->dev, res->start, res->end, name=
);
> +	else if (type & IORESOURCE_IO)
> +		res =3D devm_request_region(&pdev->dev, res->start, res->end, name);
> +	else
> +		return ERR_PTR(-EINVAL);

So this part is surprising. IMHO your function's name should include
"request".

> +	if (!res)
> +		return ERR_PTR(-EBUSY);
> +
> +	return res;
> +}
> +EXPORT_SYMBOL_GPL(devm_platform_get_resource);
> +
>  #ifdef CONFIG_HAS_IOMEM
>  /**
>   * devm_platform_get_and_ioremap_resource - call devm_ioremap_resource()=
 for a

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--3o2nisona3kyspak
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmWYVHUACgkQj4D7WH0S
/k7XoQf/XQgujb3wJQ7wPs2niAnyXYWMuP6k5VtPrmtieV97iKmKJoovSFpNlN7z
i1CC2tHW8sXkAROPQmqKUjaYNhA7EaIcR1I5uAaE657JeEAvST4cmrrgH/lBE6XG
uov7/CgYQNxTRDbix2M47T2fj2BfQiQtPVVIkdYOhkJatWSq7FOx/2Fi74NzISHF
3GWVPlWVpT4U/hn78DsEmfxtWcw4cdoq3pVYZQyGHKzdEKu79IKgVjllgtBVNiMb
x0yJ+ifcj7OC2zbfCHjdgd5+igXKmSQw6OJdG6VOOmICgvNwTczUl/QvMCfOt7FB
sxivF8VqMGJ5VpFauMWtvBS/3oyKrw==
=2FhD
-----END PGP SIGNATURE-----

--3o2nisona3kyspak--