Received-SPF: pass (google.com: domain of linux-kernel+bounces-18322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 5 Jan 2024 20:23:26 +0000
From: Mark Brown <broonie@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regulator: qcom_smd: Keep one rpm handle for all vregs
Message-ID: <3ccef53c-3333-4d1c-a3fc-32b05cd473fc@sirena.org.uk>
References: <20231227-topic-rpm_vreg_cleanup-v2-1-04c79c4f9166@linaro.org>
 <b5a2f511-2758-452d-b6ac-399262b3734d@sirena.org.uk>
 <7271846f-c03f-4d0f-a54b-7424ddd72724@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="okGAQarU2f8A9pZu"
Content-Disposition: inline
In-Reply-To: <7271846f-c03f-4d0f-a54b-7424ddd72724@linaro.org>


--okGAQarU2f8A9pZu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 05, 2024 at 09:15:49PM +0100, Konrad Dybcio wrote:
> On 5.01.2024 17:31, Mark Brown wrote:

> > It'd be slightly more robust to have a check here that we do get the
> > same RPM back if the variable is already set, just on the off chance
> > that something changes in some future system and we do end up with a
> > second RPM somehow.

> Knowing how improbable this is (currently RPM is responsible for almost all
> power and some clock rails, including DDR), I'd say it's excessive, but if
> you wish, I can add it.

It really feels like something where if this was a good idea we'd have
an API to do this directly rather than passing around through driver
data.  The fact that it's used for all power management doesn't
immediately preclude having two instances managing the power for two
different bits of the system (eg, a low power island).

--okGAQarU2f8A9pZu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWYZT0ACgkQJNaLcl1U
h9CkTAf/SyvlUQy6c7giS1ICGR00AlRStxV04y1DY4uwCc26V1lL2TX7UNC76a4m
KMqlLOQPh5DN3EqASjWGqjEXfbzR7/imN6WX3SoJL2oITruU4Gm1UXL6jgl6Xxtt
yscAy310pvsZD8BVMI+wAossXHfcw4W0zBzkhoVGtxGvAhxv4S7sXMERXZnXmLbC
4YpqzHI2SQ8ak9oSD449wd2DtEe3IInLVfbBmMJjqXp/BPUdJqYysfHBQlCFXzx7
+Gnzq6hraUyxMeSq7XYbttewaRKL+zR+xGRb6flJV18/9z/YS4Rpi+pIJGJn4plz
sCtCPu63pWdjy5MGqEcMPCJ6Imew+A==
=MjPg
-----END PGP SIGNATURE-----

--okGAQarU2f8A9pZu--