Received-SPF: pass (google.com: domain of linux-kernel+bounces-18362-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5a3624d1-0801-4418-a179-38ea83c40c94@intel.com>
Date: Fri, 5 Jan 2024 13:14:05 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/2] x86/resctrl: Remove hard-coded memory bandwidth
 limit
Content-Language: en-US
To: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<seanjc@google.com>, <kim.phillips@amd.com>, <jmattson@google.com>,
	<ilpo.jarvinen@linux.intel.com>, <jithu.joseph@intel.com>,
	<kan.liang@linux.intel.com>, <nikunj@amd.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<rick.p.edgecombe@intel.com>, <rppt@kernel.org>,
	<maciej.wieczor-retman@intel.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <eranian@google.com>,
	<peternewman@google.com>, <dhagiani@amd.com>
References: <20231201005720.235639-1-babu.moger@amd.com>
 <20240104212130.209490-1-babu.moger@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240104212130.209490-1-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2dCMTZIUkkzS0wwTDVYRXNSaFczTGM3dXFYaERzTDhUVWlNelBXY0xsR1Nq?=
 =?utf-8?B?K0REZDB5RDZoSStEQVVwTlk4ZWlIc1ZmeGY5eDJxVTFrcTdaczB4S3U4bVpr?=
 =?utf-8?B?a1BIWVNreTE5SU4wTmRMZUtIY0NPSlNxYVFmV3RidmhQZEtGQ0dQcEovYWs4?=
 =?utf-8?B?OUd5Tk4zcnlVdEZaNVNTTG15U3dTY25LbGsxREp6WXJXOUVLYmFEZFhnVU9H?=
 =?utf-8?B?YnRibm9jalhIbXBlVUtTU0x0K24vT3FYOUxCLzEybVBsdXVSMFcvNXlqTnY3?=
 =?utf-8?B?TXNJRnJPRUlIUjdsaG0yNXJBVFJUS1hRQ0ZtbUQwUVk0bGh3ZEp3b1ZOT1V6?=
 =?utf-8?B?WWxOcElkc1pVSTJHU1k0LzIzZlpkMXFCZTJxcW40TFN5NWlMK1kwMUtuRFAy?=
 =?utf-8?B?dGtpd1pIRWJEVUtEK3RrWGZqbklRaElaOXBsUFJhUmNaREpvb0xUY0VWSTlI?=
 =?utf-8?B?YnJkVDNYOWFnVjVzYTZKRCtiUFJ1T3diY1lZaS9XMG1wcWtoQkcwcXVGdzl6?=
 =?utf-8?B?Wi95Ulo0ekhlMUJxNlBxWVRwQ1JQTlRnKyttL3VpdXlSUzE5bXQ0K1BkNzdP?=
 =?utf-8?B?cGM1NGhMNkNseFB6SmozdmxOMFl6dWtmTjRUU1ZCNE9uc1J0eFVIcFU1L2Rt?=
 =?utf-8?B?d1AzcHdKNTlPejZ5dGtJYlVTTzV4VmFpMHc5MGluL0JtejBUQit3cFBMSmpV?=
 =?utf-8?B?Q0hiNGcvcEtYNHdhN2xEZG1pZzN4dGdKdEhkQk5zUVVmdW81Mi9BZXhlN1pa?=
 =?utf-8?B?bjNxUGlwRDJWTTVZSGVEZnN5VlhkZjNTa2dQZUN3V3pZUjlHMEpOTVcxTUh4?=
 =?utf-8?B?OEpzNE5yVG9sUSs4Ymk1UlcvS3lNaUt3cjQ3S3IrZnk5WTZ2bmpWTjIvbEJp?=
 =?utf-8?B?a0JrKzZXZHBsdmxjNmJVWmdxNUdhcFNLTWNxVjFLMDRRTlBwWnRtNDZReExW?=
 =?utf-8?B?aG9weGN0Y2NQVzBadTdlS2RVN2gxZHczVklpZnlJZEJTanNFME9Ta29kcm1V?=
 =?utf-8?B?dDYxS2JRYXFRRkVQd2twWmZrWjJKR1RRNGQ2Ym53TzZlZVMzQm0wM2Zpc1lC?=
 =?utf-8?B?ODNJcVc1TFJic0s5K2IwdjBXb1JWbEkrdy81UkxiQ003dUhvdEVKRCsyOHA4?=
 =?utf-8?B?bUtncUM1Uit3MnFTM08xdVlGUnN3aVE0bkMxUy91Ym8wU3RNWkpGQUpkWkp4?=
 =?utf-8?B?Z1ZrajFINEJtMS9rMVZTWkJVRXFOVnBDZ09GNnpZdFBuYVByaWtEbGJDRjVx?=
 =?utf-8?B?VFhidnBuQmVSVHpscUlvajVrSlZpUVZWVUJLV3dkUG5MQ2ZFZUJuUVB5RG9z?=
 =?utf-8?B?dkliOVVVaHcvNTdXampycVRsbXBsSC8vSjFMSXJBbEpNaEpISTBjT2lFVTFm?=
 =?utf-8?B?bzFlNmxwcGh5eWZLTTJ1KzZDOHRkUld5YnNNeWR2L0pVbmo1WTVLdVpES1lk?=
 =?utf-8?B?NWRUWUZ6RzFEMmQvYjZab2hyRXArMXBJRVpYcWhQK09HOWJUdHF6MFNqL2hV?=
 =?utf-8?B?Ujh2QWlpc2wrdlBndnhLY3FqbjltT0IvWW9QQmFwd1N0ank5dm9uYnpDVXVr?=
 =?utf-8?B?VWpYRzR1Mm5Nb0MxTWMrOHAwSFNCeit2alJKdXYrSmJYaXgxZ0VkYks3U25z?=
 =?utf-8?B?ZUttTkV2Y2FpbHd3T3hhbDBtNzg2T2RsZWNSTnVQZll2bEprQ09KdUt3eGRB?=
 =?utf-8?B?MjQyb251MjBvbC9NWGJYeHJBeDdML1h2dmVXdE5tc004dFhhbys4WkFpTHRP?=
 =?utf-8?B?UEpuV0FrL3VVVCtVc3JaZkNlcCt5QzhwekoyRzFiSnl2NHFQUVNyeUVoNG5w?=
 =?utf-8?B?NHZNc0FCWCtLNURpYVFCNTVxYjNRL2x4QmdRQmFCNDlkY20wSTg5dW53Z1FM?=
 =?utf-8?B?MzI5WkxLSjFUTnBUUkwzL2NPV1lQT3ZTSG94MzVOUGlqSEl4SkY3MStGVFkv?=
 =?utf-8?B?QTdpR1BJVGlIVkUyMEh4S1N3Rk1jMzByZGFqVHU3SU9yLzRKTkJuazQyZDla?=
 =?utf-8?B?b0xZMlM3NEt0SWFxRGc4c2FoY1hITXFiNjR6VWFKSjFBWmQxOGE4YWFXSm9J?=
 =?utf-8?B?aVpFRmRzMzUzNkFtbEcwNDZWUHMwbnhuOXVtb3pzY0hnZjNlcW5EM0dCbC9M?=
 =?utf-8?B?QTNKL2lWcUgrR1lER2h2b2FmZnFpdGx0bUpiV3M1bXFPZ2JOczVZZVk0bzZG?=
 =?utf-8?B?clE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dd11cd5b-eb08-4b44-b3c7-08dc0e33416c
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 21:14:08.5492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HPm8QIO3k32o3IGOJplXS4SMr2TLisXgb/egrLU/vxV/iil+vnNfA8H/Og8vvkWelXxfS7+zwVi0ZGGwU9CxRv4qeNmBDTckBMuakS1J5w0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4600
X-OriginatorOrg: intel.com

Hi Babu,

On 1/4/2024 1:21 PM, Babu Moger wrote:
> The QOS Memory Bandwidth Enforcement Limit is reported by
> CPUID_Fn80000020_EAX_x01 and CPUID_Fn80000020_EAX_x02.
> Bits Description
> 31:0 BW_LEN: Size of the QOS Memory Bandwidth Enforcement Limit.
> 
> Newer processors can support higher bandwidth limit than the current
> hard-coded value. Remove the hard-coded value and detect using CPUID
> command. Also update the register variables eax and edx to match the
> AMD CPUID definition.
> 
> The CPUID details are documentation in the PPR listed below [1].

"are documentation" -> "are documented"?

> [1] Processor Programming Reference (PPR) Vol 1.1 for AMD Family 19h Model
> 11h B1 - 55901 Rev 0.25.
> 
> Fixes: 4d05bf71f157 ("x86/resctrl: Introduce AMD QOS feature")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Looking at "Ordering of commit tags" in Documentation/process/maintainer-tip.rst
I believe "Link:" should be the last entry.

Reinette