Received-SPF: pass (google.com: domain of linux-kernel+bounces-18424-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <3e1a4b7c-241d-032d-67ca-6eecaf57fabf@amd.com>
Date: Fri, 5 Jan 2024 17:51:30 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v3 1/2] x86/resctrl: Remove hard-coded memory bandwidth
 limit
Content-Language: en-US
To: Reinette Chatre <reinette.chatre@intel.com>,
 Babu Moger <babu.moger@amd.com>, corbet@lwn.net, fenghua.yu@intel.com,
 tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, paulmck@kernel.org, rdunlap@infradead.org,
 tj@kernel.org, peterz@infradead.org, seanjc@google.com,
 kim.phillips@amd.com, jmattson@google.com, ilpo.jarvinen@linux.intel.com,
 jithu.joseph@intel.com, kan.liang@linux.intel.com, nikunj@amd.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com,
 rick.p.edgecombe@intel.com, rppt@kernel.org,
 maciej.wieczor-retman@intel.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, eranian@google.com, peternewman@google.com,
 dhagiani@amd.com
References: <20231201005720.235639-1-babu.moger@amd.com>
 <20240104212130.209490-1-babu.moger@amd.com>
 <5a3624d1-0801-4418-a179-38ea83c40c94@intel.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <5a3624d1-0801-4418-a179-38ea83c40c94@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UFdMRGxIek0wL2pkS0hPTzdXanIyQ1pEczc1eXowTUdITllFOFROOEhRVzk5?=
 =?utf-8?B?MTVKQ214TW1aek9SbmtWUHhzRUkvVVRBNk1wTURNL3ZGQlN3eVJEQ1NFNjZW?=
 =?utf-8?B?UVVOYkxKM3lST0JGUmFIQVREZVpwdkdUT3NNSDJFMUlFYWlGckVCeE50MDBu?=
 =?utf-8?B?VDB0Mk1UOVhHaG8wSDdodGxVZWQ1cG1UZ2dhYmFKaHpkQWE1UVg5bnNqUHNG?=
 =?utf-8?B?eWoyd2ZYZFdneTJQa1dQNlBTRDZBUjEraVpaeG1hTnRDYUdXVFpIL1EvRERo?=
 =?utf-8?B?SjU5dE82VTVQNlV6T3UvdURjYzgvbGNFdE1oNmJZd2gyc2ZoU3VGd2U0b3lr?=
 =?utf-8?B?RVBBNGtjSGE5bUN0SitjSERSdkgvLzNjTjlSdHdMZkhoNytMbnBOUEdrOVVG?=
 =?utf-8?B?WVlsVkhBb08yRStQYXJlZFpSQ3M4bU5PR3NNV3ZkNFcrYVlNRnNPdVU1WWdW?=
 =?utf-8?B?OFhGUzFxVXFMMktEQU9Fc3FkMXFNd3NhQ0VpNVlJUzJWcGc1bFRVSmJ3Rm1U?=
 =?utf-8?B?UTFiQ0E5UUtiQnA0ak5HNnY2cWVoeERQMGdLQnBqc1V2UC9qVU5hUmZOcGQx?=
 =?utf-8?B?dU01ZjVWUysyckZadU5TR3orTk91cUNaLzBZWUV2OHJaMnFHWWJKMVRJblpt?=
 =?utf-8?B?Wk84S2VOejhoZ3RIUzBhWnh4ZGZvM05DcjZiT0hEeEhpWmhqbFhOZDZSN3Jj?=
 =?utf-8?B?MnlHdlN1N3R4TVV5V1MxcWdpMWhVR1R6YzBWeUJVSlR6RWgwb1NJNFVmMnBQ?=
 =?utf-8?B?WC9mM0lRUEVOSGRhaURILzBTWE9pTDJHV1hyMjBQbHRQYnZZbGxuUW5NVzY4?=
 =?utf-8?B?eUNFWEUzVVJ2d0lHOWdYV1QyZERnc0pnak5IS24yRGIyb3JXZWFXWkpIb1VQ?=
 =?utf-8?B?N0NDWHJScEc5RW5YcDl5WmJ0dmJxR2c4TG9mL2diMzNXcVllbElSUlZRckxX?=
 =?utf-8?B?b1FHR0pTV2ZUR2cyUUgweUlLLzRuRi83MTJOMGM3Y3F6RW5xYUpHZlUvVEJv?=
 =?utf-8?B?cGJUQ01uUkk3Z3N0MDFqQzhTYlh6bmxoVjNyNHlDb1dSOXFudWI0elNaK0hl?=
 =?utf-8?B?OCt3MWhuckNqTHJ6UkdSMWR3MlV3L0o3a3l0c1ovVVJzOWZEV0xoRkVKd0Jo?=
 =?utf-8?B?dWozTzFlU2tUaW1rZlRrODhlck41d29xQUNTem1mbHNLVUNlOUIzcmx5Mjd0?=
 =?utf-8?B?R1ZzZC90cGl3NEFlU2M5OEdSL3Rvc2cwYVdJMVlxem5tWW1oczFnUTM4T3kr?=
 =?utf-8?B?QWRXYU1qUkltSm9ydGpDSU1SWElkVFRWTmcraCsxdEZKanlGOUNBWkNMRHdC?=
 =?utf-8?B?dFBhWmI5cEh5Y2VwMWRLVVdkZUZFVVRHWklWSzA1SnVKRy9WTHNhcFhMMFZx?=
 =?utf-8?B?amxZRFp5V0g4RXFNOGJWM0ZkNXNKOGgrcStFRW1NOVVVUVlDWWRBUlE4bENI?=
 =?utf-8?B?TGRYeEJKdXFNbThTR2VGUnMvTE5lYnVPSHI0MUtuS0NkSFpyMFBhWFJhZUMx?=
 =?utf-8?B?OU9TRkRSVGE3OS9rMXAyWUJnbHY5RWlWQVJOVHBwdURqeG1wOEtFOFpSVEZ3?=
 =?utf-8?B?d1dVRVRrVHNLZ3lHZGNSUFV5Q0R5cEJKc2dRNE5LdFp1VHlEcncyYnZ3akJm?=
 =?utf-8?B?czhhTjNENlQyenBXaXBZYWZrbDNVejFmN2g5MzhvT3lMQ3h5RzJjWm42QnNH?=
 =?utf-8?B?VTVaRDlEaU9lYlkyeVc4MG5NRjFzSm10SFc5SDZUYkdzQzNaT2pJRTl2dHh5?=
 =?utf-8?B?OFZmRXF5Y0Rva2hRZm5yVUxweUhTVWZWcE5kcGVyYjdNbGRvZ2piSlp6Tmo5?=
 =?utf-8?B?Q1RXVzEzMlVFQmdBOWt0c014a3dVSTdTM2p4bHRXeStJRFN6N0NFYUtMNzlX?=
 =?utf-8?B?UWlNMEVKbWhZckxnc1ZrNDRDYlZ1VHdzNExqMVU5czdjd0RIRHNYSDVBSG1i?=
 =?utf-8?B?SGMwTFd3S0lXUTBhcWUzYkpMRHdRWGJxc3kzRVV0a3pGVXBUaUZtVHcwMHJI?=
 =?utf-8?B?Z0dybERGcmY1YXZnUnJ2aU5MdjVIekUvb3F6bEUrcmdVSjhvdVhneFNPcjBy?=
 =?utf-8?B?VngyVnlwNTlHN2Y5Qy9IcWtoS2YvbVZXZjk5Q1lGQU5aWHc4ejVEd3dEend1?=
 =?utf-8?Q?WwJDX0HdnmtMWVmaJi6U9Pjj7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b392998-23a4-4392-b39f-08dc0e493fe2
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 23:51:34.9198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TgzgzuhGXJRKqCb4z/YCu2ZsvjHlIocE4wL/232VOv5Sza3VLCztTTVsaimHt+dK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7293

Hi Reinette,

On 1/5/2024 3:14 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 1/4/2024 1:21 PM, Babu Moger wrote:
>> The QOS Memory Bandwidth Enforcement Limit is reported by
>> CPUID_Fn80000020_EAX_x01 and CPUID_Fn80000020_EAX_x02.
>> Bits Description
>> 31:0 BW_LEN: Size of the QOS Memory Bandwidth Enforcement Limit.
>>
>> Newer processors can support higher bandwidth limit than the current
>> hard-coded value. Remove the hard-coded value and detect using CPUID
>> command. Also update the register variables eax and edx to match the
>> AMD CPUID definition.
>>
>> The CPUID details are documentation in the PPR listed below [1].
> "are documentation" -> "are documented"?
Sure.
>
>> [1] Processor Programming Reference (PPR) Vol 1.1 for AMD Family 19h Model
>> 11h B1 - 55901 Rev 0.25.
>>
>> Fixes: 4d05bf71f157 ("x86/resctrl: Introduce AMD QOS feature")
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> Looking at "Ordering of commit tags" in Documentation/process/maintainer-tip.rst
> I believe "Link:" should be the last entry.

Sure.

thanks

Babu