Received-SPF: pass (google.com: domain of linux-kernel+bounces-18448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes
To: =?iso-8859-15?Q?Michal_Koutn=FD?= <mkoutny@suse.com>
Cc: jarkko@kernel.org, dave.hansen@linux.intel.com, tj@kernel.org,
 linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org, x86@kernel.org,
 cgroups@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 hpa@zytor.com, sohil.mehta@intel.com, zhiquan1.li@intel.com,
 kristen@linux.intel.com, seanjc@google.com, zhanb@microsoft.com,
 anakrish@microsoft.com, mikko.ylinen@linux.intel.com, yangjie@microsoft.com
Subject: Re: [PATCH v6 01/12] cgroup/misc: Add per resource callbacks for CSS
 events
References: <20231030182013.40086-1-haitao.huang@linux.intel.com>
 <20231030182013.40086-2-haitao.huang@linux.intel.com>
 <5qfjx2vvirtffkro5u6zdbbwia2bhhbjxwgij2igdnxk5hysaq@kpqboajvuzbc>
Date: Fri, 05 Jan 2024 19:42:21 -0600
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: Quoted-Printable
From: "Haitao Huang" <haitao.huang@linux.intel.com>
Organization: Intel
Message-ID: <op.2g3q0ve0wjvjmi@hhuan26-mobl.amr.corp.intel.com>
In-Reply-To: <5qfjx2vvirtffkro5u6zdbbwia2bhhbjxwgij2igdnxk5hysaq@kpqboajvuzbc>
User-Agent: Opera Mail/1.0 (Win32)

On Fri, 05 Jan 2024 03:45:02 -0600, Michal Koutn=FD <mkoutny@suse.com> w=
rote:

> On Mon, Oct 30, 2023 at 11:20:02AM -0700, Haitao Huang  =

> <haitao.huang@linux.intel.com> wrote:
>> From: Kristen Carlson Accardi <kristen@linux.intel.com>
>>
>> The misc cgroup controller (subsystem) currently does not perform
>> resource type specific action for Cgroups Subsystem State (CSS) event=
s:
>> the 'css_alloc' event when a cgroup is created and the 'css_free' eve=
nt
>> when a cgroup is destroyed.
>>
>> Define callbacks for those events and allow resource providers to
>> register the callbacks per resource type as needed. This will be
>> utilized later by the EPC misc cgroup support implemented in the SGX
>> driver.
>
> I notice now that the callbacks are per resource and per cgroup.
> I think that is an overkill that complicates misc_cg allocation code
> with parent's callbacks while freeing is done by own callbacks.
> It's possibly too much liberal to keep objects' lifecycle understandab=
le
> in the long term too.
>
> For some uniformity, I'd suggest struct blkcg_policy array in
> block/blk-cgroup.c as the precedent. (Perhaps indexed with static enum=

> misc_res_type instead of dynamic index assignment as
> blkcg_policy_registeer() does.)
>
> I hope you don't really need per-cgroup callbacks :-)
>
> Michal

Sure I can do that. IIUC, you are suggesting something similar how  =

capacity is set via misc_cg_set_capacity for each resource type. Here we=
  =

make a misc_cg_set_ops() which stores the ops pointers in a static array=
,  =

then use them indexed with the resource type.

Thanks
Haitao