Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp512821rdb; Fri, 5 Jan 2024 19:33:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4eh0itATUenSv53Wezo/0+LoaLh4sRcC1BCNBoiAnLkiIlxWYb88+WgmK6IsBZtFTVaTQ X-Received: by 2002:a05:6214:c2f:b0:67f:3261:637c with SMTP id a15-20020a0562140c2f00b0067f3261637cmr531431qvd.86.1704511984171; Fri, 05 Jan 2024 19:33:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704511984; cv=none; d=google.com; s=arc-20160816; b=G075b1bvGNxqPbddVdV2SPbF6szAkAws+BksCggCoHHRXivdCkfkM7irXKRGdJVj6Z azL7KeHqQ2ctKv57DbKOX8lF2Kx2LYd1PKWjvBfMZ6eIZwMoQ7TP2DBCDL+ixkqgA7Y9 fAG7BsyGnnKx3QzKpoydCBGP1Xl+Q7oMbBA41SgRRXDGrUlhhBWlbjsO2TcftDLfg5Pb bjC6Vf+xXimhGn3Bsq0/1bEg5NQLl8Wg/AHpFZr7ayW+lDNcQxl3/1VhxK0cJ28s8W89 JgfmDRnMTdnFxuUsbL1ogMJCRZQgYDtv11Dz+2amiPcdYHjmGs1jGWFPVggawc3jJMOe QTtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=y9VdBHX1ulL5QF63++WGZx+NoJ0FKpfWHnHY93nCqMM=; fh=xj4dZKoaFBL4JegojZJQtsvddfztt+QYM1s2e+uzOo8=; b=us1LihkSqsyPJ1PQnGT4hyr+jAdknVwCOEu68c84vAhq6kGeMfOFVgF+Pnv2Arr3ww v+zst/99MqiOhRNyaFTsXuoNb/1SBoK2OE4LBUnf3MdoewvWudvUOQd4L4tuhnnZWSjB Q7nSPL7dS0j3Ho8MAup7JzFKEd1y3jdta+wVuM2FbYOsY/tmSAWaI2ZVDId8p5mwQrcr S7KgGW9jodKDkDo2XE8HgV+rQ/yP1kEZqpu1MqaaMY3k2ln2mUV1Uc9brj6bbxegwHwu XxA/izbN7iU0J7cOE/zzpqLmOG0ys5jX8tmyP5U1GgDnEowwbB3dPjVDvRHSbFh7glmH d53Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EcjEgHW+; spf=pass (google.com: domain of linux-kernel+bounces-18470-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18470-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m13-20020a0cf18d000000b00680c85d6553si3224869qvl.361.2024.01.05.19.33.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 19:33:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18470-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EcjEgHW+; spf=pass (google.com: domain of linux-kernel+bounces-18470-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18470-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BEDF71C23BC1 for ; Sat, 6 Jan 2024 03:33:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 991CB17F6; Sat, 6 Jan 2024 03:32:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EcjEgHW+" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C97B315AB; Sat, 6 Jan 2024 03:32:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D2D7C433C7; Sat, 6 Jan 2024 03:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704511973; bh=1u32dTC0eH/V7kWdeW575b47WixVYNPhXK1f2z3ilxk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EcjEgHW+7rAprJzaq4UfsGOfOl9q4bUrTKlmPdlDkeeDN6+ORWTkHUOWpZj55/sVy Arq/IABOnLBaAI0YHsWI7T6QCC30lhxhDLd1/oMrC3z+r1DtVmSqQeslMVShfhrhrZ +JtTOrMd0fpA/hZ9aVfvYum193VD0KRuPzI+MzOJMy07tGZus+4AA5eIzqAT6Fxi16 XMA9DlUW4mMcQIrqd8vC5p54fPPK13yxGP+grp+TRO621wN10C3T9uio/o62CoTaWA +gIDFWRD+YmTIIifyA7wgkPTM7d5Pnw+DiPxqaGmqyry/W7aitmBqjgH7ALBsUKQ3F vwG/CUgh/qLiw== Date: Fri, 5 Jan 2024 19:32:51 -0800 From: Jakub Kicinski To: Shinas Rasheed Cc: , , , , , , , , , , , , Veerasenareddy Burru , Satananda Burla , "David S. Miller" , Eric Dumazet Subject: Re: [PATCH net-next v3 7/8] octeon_ep_vf: add ethtool support Message-ID: <20240105193251.028e8eb5@kernel.org> In-Reply-To: <20240105203823.2953604-8-srasheed@marvell.com> References: <20240105203823.2953604-1-srasheed@marvell.com> <20240105203823.2953604-8-srasheed@marvell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 5 Jan 2024 12:38:22 -0800 Shinas Rasheed wrote: > + "rx_dropped", > + "tx_dropped", Please take a close look at rtnl_link_stats64. Anything that fits should really go to standard interface stats. This will benefit the piles of monitoring SW which gather standard stats. > + "rx_dropped_pkts_fifo_full", This one is probably rx_missed_errors