Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756636AbXLLPP7 (ORCPT ); Wed, 12 Dec 2007 10:15:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751498AbXLLPPv (ORCPT ); Wed, 12 Dec 2007 10:15:51 -0500 Received: from www.tglx.de ([62.245.132.106]:51937 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbXLLPPu (ORCPT ); Wed, 12 Dec 2007 10:15:50 -0500 Date: Wed, 12 Dec 2007 16:14:37 +0100 (CET) From: Thomas Gleixner To: Ingo Molnar cc: Kevin Hilman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Generic IRQ: Add unlocked version of set_irq_handler() In-Reply-To: <20071212102437.GI24246@elte.hu> Message-ID: References: <1197413651-23076-1-git-send-email-khilman@mvista.com> <20071212102437.GI24246@elte.hu> User-Agent: Alpine 0.99999 (LFD 796 2007-11-08) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 21 On Wed, 12 Dec 2007, Ingo Molnar wrote: > > * Kevin Hilman wrote: > > > Add unlocked version for use by irq_chip.set_type handlers which may > > wish to change handler to level or edge handler when IRQ type is > > changed. > > > > The normal set_irq_handler() call cannot be used because it tries to > > take irq_desc.lock which is already held when the irq_chip.set_type > > hook is called. > > looks fine to me. Thomas? Acked-by: Thomas Gleixner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/