Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp609369rdb; Sat, 6 Jan 2024 01:33:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZlydkR9JM1YFyjcQgGSZhOeZVwbq3f5ouZ6OZsSCcz+uhnPPwQ3J/5QSq9x9ZoYD23WWJ X-Received: by 2002:a05:600c:3483:b0:40d:aa42:b417 with SMTP id a3-20020a05600c348300b0040daa42b417mr346229wmq.90.1704533583413; Sat, 06 Jan 2024 01:33:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704533583; cv=none; d=google.com; s=arc-20160816; b=SwS7kmzvhwzEwEpNx822iap/uDRPyTzNFPZ6m2IRIK5x8+g4OptQiUQ9xTB225fqM7 /UoiCGMzc5VR0tjo+H4IDUmSA5ji6jd4t6n/3GnvhMBgrW1DMqPhEn8Oq4NwIuRLQq5p qp11i2xV54BUGCFM+IXDU+Qme1ZFMvN5B1lhl11ItwTARhVUpvkQgAemTga2SOomKhjI s3MmRarwM/VYGFe+PxWWNgW4apPT+bVj+eoUBhgcNd9E4ED/e3zNzjK4waPflWtiB7KD Z9YYWD+qpxVa35fGPt7EzGWJOepLg3qUYzD8LpICNUOeNTDDQjGTn37j9xL9VMzLdRVq IYOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=uCzELojOf7XR3y8WSqa5qQlK9psTGRHA9ep7x4N0xvA=; fh=PWfsmAeIVhjN7IPZeQwW2FkF7kRlGadaBE0mqyc58+c=; b=x8QKqYmQIp1p3rWrTYjqsVKvClKLwNlkhQjAgZiQfji15jQHTNovLEXmGGgLbvsl5E YJAqBaTNYxMdQ/6ENi2/C1K7fTcjXQGSsv511lLeg0GftXdKLQ84fNvKC4+84tTBfL/J J94Y+uUFWAgGJ1parJUCbfoVokhJ4A+WVA2M4hSvWQOfEM2OE+Zu7uqJEJIkQXnHkfxN l7hBH7/5A3RxUEt7VspJecOLb3LfyzfbcIVWD/aU7wwL1VcHdKFK8cm8VT9Wz5S9NXRj +Y/PY6g9vqFVdOyBUjPVOwDBafonu8ld5Tlr66TABeR7C5YqV39VX+72Cdydn+r74ZFv B0mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=V0CVmreh; spf=pass (google.com: domain of linux-kernel+bounces-18544-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18544-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id n13-20020a170906688d00b00a28c04e329asi1225024ejr.286.2024.01.06.01.33.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 01:33:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18544-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=V0CVmreh; spf=pass (google.com: domain of linux-kernel+bounces-18544-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18544-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2E2E41F23A78 for ; Sat, 6 Jan 2024 09:33:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C04B763C9; Sat, 6 Jan 2024 09:32:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="V0CVmreh" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D9FB63AB for ; Sat, 6 Jan 2024 09:32:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-680adbf077dso3973466d6.1 for ; Sat, 06 Jan 2024 01:32:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1704533572; x=1705138372; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uCzELojOf7XR3y8WSqa5qQlK9psTGRHA9ep7x4N0xvA=; b=V0CVmrehAeTzRMNnFsFQLgVx6Ngs3vtShe9FMhfz2Y8zcrFQxYzMXntxjWPvxZwkK9 OS3ekBiOxBDWPghU/+s3AVfC5T9LUrbhZ9b/4jevO44aaTuyrmsdRbfhc0m2Ktnv3eyR T1BI6rFQ0uy8kcsCmS9MQeJLYpX9Zob8FF8Gg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704533572; x=1705138372; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uCzELojOf7XR3y8WSqa5qQlK9psTGRHA9ep7x4N0xvA=; b=FIZJn+eDx2vwcsk9OLvqmyIjRMGREVsk7JH/EM5O7SL9vGN1hJNBvJG1Xni1WZpR1T NA9Jj2XZxkIOxbhBUPYgqHcQhOZIYBUcg/b8N4RasLX7e5csAGfeqJs7M+3M7wouqQzB oBBz1N52NALUvTtj23hWsr8wgeAjT7KiN0y0xxijmQtks81JCc+GNUtsVBzKAkJJB37m s3GwGvA81XhnaG34hRDxXDp13+zg8t9IwWjtTt3xZzW3np+mIZG3qNr0PoZwixCEqvMJ dSIRFpP/qpuYT3GIctziSO5nH80xWoGQLNNC3b9RH6hJJvuk5gCxFD0/dl9OxRAxFbAp oQqg== X-Gm-Message-State: AOJu0YxtApwifG6SvR5qkKOBrr8XLQt7ynovWpgNQLnfhXFkkl9kEcfj hUZT57TAh0BV0PefINjowT9EFBv8Ldy4syTXqCL9zEPfNVft0gnaivcrI/Z8 X-Received: by 2002:a05:6214:acd:b0:67f:ba18:7d59 with SMTP id g13-20020a0562140acd00b0067fba187d59mr1028539qvi.104.1704533572360; Sat, 06 Jan 2024 01:32:52 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240104084206.721824-1-dario.binacchi@amarulasolutions.com> <20240104084206.721824-8-dario.binacchi@amarulasolutions.com> In-Reply-To: From: Dario Binacchi Date: Sat, 6 Jan 2024 10:32:41 +0100 Message-ID: Subject: Re: [PATCH v4 7/8] drm/panel: nt35510: move hardwired parameters to configuration To: Linus Walleij Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Alexandre Torgue , Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Sam Ravnborg , Thomas Zimmermann , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 5, 2024 at 8:08=E2=80=AFPM Linus Walleij wrote: > > On Thu, Jan 4, 2024 at 9:42=E2=80=AFAM Dario Binacchi > wrote: > > > This patch, preparatory for future developments, move the hardwired > > parameters to configuration data to allow the addition of new > > NT35510-based panels. > > > > Signed-off-by: Dario Binacchi > > I tested this patch on the NT35510-based Skomer and it makes the > whole display mirrored around the Y-axis (text from right to left instead > of the other way around, penguins appear mirrored upper right > etc). > > + /* Enable TE, EoTP and RGB pixel format */ > + .dopctr =3D { NT35510_DOPCTR_0_DSITE | NT35510_DOPCTR_0_EOTP | > + NT35510_DOPCTR_0_N565, NT35510_DOPCTR_1_CTB }, > + .madctl =3D NT35510_ROTATE_180_SETTING, > > Changing this to NT35510_ROTATE_0_SETTING makes it work > fine again. Sorry for the mistake Thanks and regards, Dario Binacchi > > With that change: > Reviewed-by: Linus Walleij > Tested-by: Linus Walleij > > Yours, > Linus Walleij --=20 Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com