Received-SPF: pass (google.com: domain of linux-kernel+bounces-18593-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 6 Jan 2024 16:18:19 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marco Elver <elver@google.com>
Cc: Pierre Gondois <pierre.gondois@arm.com>, linux-kernel@vger.kernel.org,
	Kees Cook <keescook@chromium.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Jani Nikula <jani.nikula@intel.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] list: Add hlist_count_nodes()
Message-ID: <ZZlhK6rF8gSy0toK@smile.fi.intel.com>
References: <20240103090241.164817-1-pierre.gondois@arm.com>
 <CANpmjNPsBUJy6tkOdRSJyWrS9CMUOQhQyb7_hwmw68pjjiEDWQ@mail.gmail.com>
 <2f4a5ea1-daa2-4ede-bdc0-6692d7d52e8c@arm.com>
 <CANpmjNMqzYsSh-DSsdFz4D_Ad0sAgf9J1A6CBz4fEOXAS4ejjw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANpmjNMqzYsSh-DSsdFz4D_Ad0sAgf9J1A6CBz4fEOXAS4ejjw@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, Jan 03, 2024 at 02:46:00PM +0100, Marco Elver wrote:
> On Wed, 3 Jan 2024 at 13:04, Pierre Gondois <pierre.gondois@arm.com> wrote:
> > On 1/3/24 12:25, Marco Elver wrote:
> > > On Wed, 3 Jan 2024 at 10:02, Pierre Gondois <pierre.gondois@arm.com> wrote:
> > >>
> > >> Add a function to count nodes in a hlist. hlist_count_nodes()
> > >> is similar to list_count_nodes().
> > >>
> > >> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> > >
> > > Is this patch part of another patch series? As-is, this will be dead
> > > code, and there's no guarantee someone will just go and delete it in
> > > future. Although this function looks useful, we also should avoid
> > > adding new dead code.
> >
> > The function is indeed not used in the project right now. I needed
> > it for a private module. If it helps integrating the function and
> > not make it dead code, maybe I could add usages at the following
> > places:
> > - drivers/gpu/drm/drm_hashtab.c::print_binder_node_nilocked()
> > - drivers/md/bcache/sysfs.c::bch_cache_max_chain()
> 
> If this function allows to simplify these other places, by all means
> go ahead. That would look a lot better than having an unused function.

+1, produce a little series with those drivers being cleaned up.

-- 
With Best Regards,
Andy Shevchenko