Received-SPF: pass (google.com: domain of linux-kernel+bounces-18634-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 6 Jan 2024 17:30:21 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andreas Klinger <ak@it-klinger.de>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Angel Iglesias <ang.iglesiasg@gmail.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v3 10/10] iio: pressure: mprls0025pa add SPI driver
Message-ID: <ZZlyDT0J4n1_YXh4@smile.fi.intel.com>
References: <20231229092445.30180-1-petre.rodan@subdimension.ro>
 <20231229092445.30180-11-petre.rodan@subdimension.ro>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231229092445.30180-11-petre.rodan@subdimension.ro>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Dec 29, 2023 at 11:24:38AM +0200, Petre Rodan wrote:
> Add SPI component of the driver.

> Tested with mprls0015pa0000sa in spi mode on BeagleBone Black on
> slightly patched 6.7.0-rc6 mainline.

> Tested with mprls0025pa in i2c mode on BeagleBone Black with togreg
> branch on
> git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
> (tag: iio-for-6.8a)

I believe these paragraphs can be moved to the patch submission comments from
the commit message...

> Tested-by: Andreas Klinger <ak@it-klinger.de>
> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
> ---
> v2 -> v3 removed iio.h include line

...somewhere here.

...

> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/spi/spi.h>
> +#include <linux/stddef.h>

Basically here we need additionally these ones:

device.h
errno.h
types.h

(I haven't checked i2c counterpart for the similarities).

-- 
With Best Regards,
Andy Shevchenko