Received-SPF: pass (google.com: domain of linux-kernel+bounces-18694-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 6 Jan 2024 19:54:26 +0100
From: "Christian A. Ehrhardt" <lk@c--e.de>
To: Tigran Aivazian <aivazian.tigran@gmail.com>
Cc: Xiaochen Zou <xzou017@ucr.edu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/bfs: Null check to prevent null-ptr-deref bug
Message-ID: <ZZmh4rdZzj4YgrOG@cae.in-ulm.de>
References: <20240105193331.1180331-1-xzou017@ucr.edu>
 <CAK+_RLm93haEd13Z0hVPSRqG4STsDHMHfu4FBdaBW1QP0m_c6w@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK+_RLm93haEd13Z0hVPSRqG4STsDHMHfu4FBdaBW1QP0m_c6w@mail.gmail.com>


Hi,

On Sat, Jan 06, 2024 at 08:38:02AM +0000, Tigran Aivazian wrote:
> Hello,
> 
> On Fri, 5 Jan 2024 at 19:33, Xiaochen Zou <xzou017@ucr.edu> wrote:
> > Similar to ea2b62f3058 (fs/sysv: Null check to prevent
> > null-ptr-deref bug), bfs is lack of return value check for
> > sb_getblk(). Adding a null check to prevent null-ptr-defer bug
> 
> > diff --git a/fs/bfs/file.c b/fs/bfs/file.c
> > index adc2230079c6..35688424bde3 100644
> > --- a/fs/bfs/file.c
> > +++ b/fs/bfs/file.c
> > @@ -39,6 +39,8 @@ static int bfs_move_block(unsigned long from, unsigned long to,
> >         if (!bh)
> >                 return -EIO;
> >         new = sb_getblk(sb, to);
> > +       if (unlikely(!new))
> > +               return -ENOMEM;
> 
> Thank you, yes, that makes sense. Please apply the patch.

What's with the bh in this case? Wouldn't we need a brelse or something?

> 
> Acknowledged-By; Tigran Aivazian <aivazian.tigran@gmail.com>
> 
> 

regards   Christian