Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp850171rdb; Sat, 6 Jan 2024 11:59:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHV6vGzepCC9rwGkd6M8i2yoaJJrUlJoCJzKJFHs0YjhSSgRM1YNGeY1EZ1mcB7ItJ4CTvt X-Received: by 2002:a17:906:bcfb:b0:a28:a7cf:b014 with SMTP id op27-20020a170906bcfb00b00a28a7cfb014mr3878604ejb.2.1704571144447; Sat, 06 Jan 2024 11:59:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704571144; cv=none; d=google.com; s=arc-20160816; b=ihHByAvr8nsgK4fmuZQdQ1QKqEibcZhy+eNMXvNVNygCuJRTEVhkHGGSjQ31xqnQL7 164nCSxl0yVhn0cnVn3D036hT7YjNkfdNiU14qOHpOt4f3DVeMQG3HAP1+z8C5wH/SWQ go3a2vgReZdUfyiUMahZ6zrZ+3IdYjYqcCVDWsKAZjS4QmVCfX52beS0pGWXyd8hOt2l RsJBRq36JDmiWDzw/MgA93ZL+9KpNqnTSNTyttnmlzBhY7a0kB1HNoZZBpqbdlVY9iTI fo9cehxTwc8ApKZ19QlYw7Nvbv9OFHSz9SeQe/RQRN1LLf/ki80zTp1hBn4t8QOmLGR3 lN7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=C8tytxgKQ8VL9iSa1rPXrrSi88A95XYSpfrZ5GjiZHY=; fh=HPERNkQZUyspgcXOj6X4BmwTnWTxUJUsuTrmtX7WESI=; b=uG8DV4GnMTEWmDgkRO/HciFhq6LOxtsoPnDQ0m05dT8S6w0bFTKrzkZKBqEaHCKvVI ItFwCisfzbGUrOax0opQDPBPVJEFXEq71aYyurrnnywTjc0KteSIA3w2kIiRuA3m/6i/ NJs5EM4rw8KwizalTPrnu+3fWuLZwK6vhtbU74sSjx0WqR5orukRek+JjjTvWVAm+1Oc MNWdBhKqgUwrTsd9YoOYTWyAQfCkZ4Eze1jqEiGYnYKeKqxxWXUPXM/k+D/U1Z9vCglC ihgJaYv8xE/qfgRK2HfrWQ/W6kTfi615q2m8u9UakZH4exLgQMGgEhCKI9CmUngb9X9f 966g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-18704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18704-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id k4-20020a170906a38400b00a276e405519si1625986ejz.529.2024.01.06.11.59.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 11:59:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-18704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18704-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0B9C91F21FC2 for ; Sat, 6 Jan 2024 19:59:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8C862F50D; Sat, 6 Jan 2024 19:58:53 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31A0F4E3; Sat, 6 Jan 2024 19:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.104] (31.173.84.255) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Sat, 6 Jan 2024 22:58:34 +0300 Subject: Re: [PATCH net-next v3 09/19] net: ravb: Split GTI computation and set operations To: Claudiu , , , , , , , , CC: , , , , Claudiu Beznea References: <20240105082339.1468817-1-claudiu.beznea.uj@bp.renesas.com> <20240105082339.1468817-10-claudiu.beznea.uj@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Sat, 6 Jan 2024 22:58:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240105082339.1468817-10-claudiu.beznea.uj@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 01/06/2024 19:41:27 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 182473 [Jan 06 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.84.255 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.84.255 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 01/06/2024 19:45:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 1/6/2024 5:22:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 1/5/24 11:23 AM, Claudiu wrote: > From: Claudiu Beznea > > ravb_set_gti() was computing the value of GTI based on the reference clock > rate and then applied it to register. This was done on the driver's probe > function. In order to implement runtime PM for all IP variants (as some IP > variants switches to reset mode (and thus the registers content is lost) > when module standby is configured through clock APIs) the GTI setup was > split in 2 parts: one computing the value of the GTI register (done in the > driver's probe function) and one applying the computed value to register > (done in the driver's ndo_open API). > > Signed-off-by: Claudiu Beznea Reviewed-by: Sergey Shtylyov > --- > > Changes in v3: > - fixed typos in patch description > - use u64 instead of uint64_t Well, u64 in one place, u32 in another... > - remove ravb_wait() for setting GCCR.LTI [...] MBR, Sergey