Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp860107rdb; Sat, 6 Jan 2024 12:27:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcsuVa0KN9NPuIbNqZGwPMbm+cZhFqkYo3852p/eIjPJJt5sqhYYyngdfQK0MXDSssNZle X-Received: by 2002:a05:6512:62:b0:50e:8eaf:9479 with SMTP id i2-20020a056512006200b0050e8eaf9479mr441505lfo.56.1704572829535; Sat, 06 Jan 2024 12:27:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704572829; cv=none; d=google.com; s=arc-20160816; b=qbgnRoSHpsN6aYaJ+uQgHqMfpg6PMewvKDqhcQ6WgqWBZxLWXZxKsf5IeEYzI6m15y pUuHZN1uaHP9im5n02Dt+XA28fO4dtOOASjF4yZMAPwN1efVcuEDpPNpB82MtDull0Oh tJZhrHthDf/veLRZLT3rU99VpDVBZmoCQ2qtpp5P33QXlSSB6C7qQjM7J8Cet8CLpJbM knLJXH8ERN8iF5viP+kbJEYh0ihUZjOpB4hx3yXRMb/5ysfvrGQgWBM4p2XiaoQXmL7P junkL48mSRNfwaCxOTK3ysTunX61KNdMPaWAOZC0qfkBJr1o7jNa5S0sghxju+7h3zFm hsPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=+CB6PDW1V8r7LQxqeTZ2komDUfWSPjz88wqze4/E7Nk=; fh=HPERNkQZUyspgcXOj6X4BmwTnWTxUJUsuTrmtX7WESI=; b=gP352vOzHdgR9Q9iCHqpSzQn+MYq83C9IxCZOnoWsWbysdog+9C40o2/9oMUHDSFcY ZNa3jI/Nmt1xrI4li+VgJH6vEUDyqlsu1e+hKnW8K96JmnVmCUWhKuHrTcaoObdGDrsQ HPT04duhjpBS6wsBQRz/k7eqeS7+/qjLvbopoa3Q6RvZN/KhcSGgxms2DFHPSH8eLlCt iGrFqOAmiRvbSYSmj7u9oW6fFL22wEMXXqikNdG4g1sse1D6PSho+FOkkFehU8+TUzlm S23yRCfTTrwG2j/GLaQZhtpaXZ7eSKGuXWWRi720DdFOQ6EHXpGuWd5AiOrzLcpknYiE nW2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-18709-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18709-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id lc8-20020a170906f90800b00a298d73bb0asi1252017ejb.620.2024.01.06.12.27.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 12:27:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18709-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-18709-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18709-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0AD481F2181E for ; Sat, 6 Jan 2024 20:27:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 565FDF9C1; Sat, 6 Jan 2024 20:26:55 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 508FDF4E4; Sat, 6 Jan 2024 20:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.104] (31.173.84.255) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Sat, 6 Jan 2024 23:26:41 +0300 Subject: Re: [PATCH net-next v3 10/19] net: ravb: Move delay mode set in the driver's ndo_open API To: Claudiu , , , , , , , , CC: , , , , Claudiu Beznea References: <20240105082339.1468817-1-claudiu.beznea.uj@bp.renesas.com> <20240105082339.1468817-11-claudiu.beznea.uj@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <89ed8383-4466-fa3e-f975-b6ad1b424c85@omp.ru> Date: Sat, 6 Jan 2024 23:26:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240105082339.1468817-11-claudiu.beznea.uj@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 01/06/2024 20:13:03 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 182473 [Jan 06 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.84.255 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.84.255 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.84.255 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 01/06/2024 20:16:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 1/6/2024 6:35:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 1/5/24 11:23 AM, Claudiu wrote: > From: Claudiu Beznea > > Delay parsing and setting were done in the driver's probe API. As some IP > variants switch to reset mode (and thus registers content is lost) when > setting clocks (due to module standby functionality) to be able to > implement runtime PM keep the delay parsing in the driver's probe function > and move the delay applying function to the driver's ndo_open API. > > Along with it, both delay specific functions were kept together. > > Signed-off-by: Claudiu Beznea Reviewed-by: Sergey Shtylyov [...] > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index f386a3b7effb..946abd7606ca 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c [...] > @@ -1772,6 +1825,8 @@ static int ravb_open(struct net_device *ndev) > if (info->nc_queues) > napi_enable(&priv->napi[RAVB_NC]); > > + ravb_set_delay_mode(ndev); > + Please consider moving to either ravb_dmac_init() or ravb_emac_init(), at least in the future... > /* Device init */ > error = ravb_dmac_init(ndev); > if (error) [...] MBR, Sergey