Received-SPF: pass (google.com: domain of linux-kernel+bounces-18741-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <acce064f-23c1-4f32-b9d8-d8c47d81fdb2@alu.unizg.hr>
Date: Sun, 7 Jan 2024 01:11:21 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: selftest: net: fcnal-test.sh TIMEOUT
Content-Language: en-US, hr
From: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
To: David Ahern <dsahern@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
 netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
References: <0b9a2827-c9c5-41d6-a4f1-dbd91262c474@alu.unizg.hr>
 <e0a52f62-3ea8-48c4-a5c4-307f7642cd45@kernel.org>
 <5f46cd87-ecad-4cad-bb03-b5bf22dff3b7@alu.unizg.hr>
In-Reply-To: <5f46cd87-ecad-4cad-bb03-b5bf22dff3b7@alu.unizg.hr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06. 01. 2024. 22:02, Mirsad Todorovac wrote:
> On 06. 01. 2024. 17:16, David Ahern wrote:
>> On 1/5/24 2:41 AM, Mirsad Todorovac wrote:
>>> diff --git a/tools/testing/selftests/net/settings
>>> b/tools/testing/selftests/net/settings index dfc27cdc6c05..ed8418e8217a
>>> 100644 --- a/tools/testing/selftests/net/settings +++
>>> b/tools/testing/selftests/net/settings @@ -1 +1 @@ -timeout=1500
>>> +timeout=3600
>>
>> bumping the timeout is fine to me. that script is running a lot of
>> permutations.
> 
> Well, aren't bugs best discovered if all cases or permutations are tested?
> 
> I recall some cases with Giullaume and Ido fixing them the last Summer or so.

Hi, David,

I apologise for my poor understanding of American English phrases.

If increasing the timeout value is OK with you, will you guys do it
or should I submit the formal patch?

Thank you,
Mirsad

-- 
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu
 
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
The European Union

"I see something approaching fast ... Will it be friends with me?"