Received-SPF: pass (google.com: domain of linux-kernel+bounces-18777-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 6 Jan 2024 23:47:36 -0500
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com,
	conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com,
	helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev,
	kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
	kw@linux.com, l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de,
	shawnguo@kernel.org
Subject: Re: [PATCH v7 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain
 as required for iMX8MQ
Message-ID: <ZZos6LDk4NTfQHyU@lizhi-Precision-Tower-5810>
References: <20231227182727.1747435-1-Frank.Li@nxp.com>
 <20231227182727.1747435-5-Frank.Li@nxp.com>
 <20240107031506.GC3416@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240107031506.GC3416@thinkpad>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TExNU0Q3VVFCcFFaSkpCYmpybUdIV09JOGhuWUdzVmp6KzVzdE9oajFDbXJY?=
 =?utf-8?B?LzF4R2VzUmNqREhGSFBLanVzWjI3S2tMYWFnV3JGa2tOakROSHRsNXlwWjlE?=
 =?utf-8?B?aVprVFE2eGxEUGU2bkEzR3MxS1J3UkRtaXNuRHVtbzZJczNaU3NGYnZDRGF4?=
 =?utf-8?B?VmJLbXpIZWxvbVk3TFUrREkyMW4wQkxpN2xpcFQxMW1OVVJEWmtUdU93RUJi?=
 =?utf-8?B?M1hUNmQ1cDduN3ZSTlBMRUEyRHRCeFZwczBmTWcvR0lISDE3YXJjVk95M2ls?=
 =?utf-8?B?VUxUVHQ5UUpmZHNnQ0JqN2xxRkVkV0hkcTZQV2taSVMzcFY5Vm1wWlRGckV1?=
 =?utf-8?B?SHlIMGdYVWcvcks4VDlkK3hKWGxSaFN1djc0eEloaTA2ZkU1dGFINzBjdkY2?=
 =?utf-8?B?UE9henYzSU1BSThZT0ZnZVVXaEU0OWlsazFiREN5b05zSm1IdGI1ckdtQytX?=
 =?utf-8?B?QlhPUi9aY0ZmcUtZUk11UzU4c0g1TS9sWmtJb2RlVHdNclNvTFhkTWNwd1kv?=
 =?utf-8?B?T3lFQVZmS0p1YVlLSGc5K1ZTYVg5ZGEwZnVYcWl1L01CN2k0MGZsUDhkODRM?=
 =?utf-8?B?VVNTOWxlcWdsNFpMSWtnTzNQNWxKMWtDZitHVDlHSzAxUHNYdkY0TVZobDRj?=
 =?utf-8?B?UTdDM2NSVU9Pc042bjlpcGpDNUFqTVdzaktpYWZRaDRkWmFpVndtOWY0T0dH?=
 =?utf-8?B?b1hDdk9oVVJwWDdOUENEYUtzTWUrVDJWbmpMUUV4VHJjWlJYTkpZT3NTUkR2?=
 =?utf-8?B?SytqUlpaSmljN21SVVNaODFvZXlCbkk2dzBzUUpvd2FYMVp5Um8rbm5hN1dH?=
 =?utf-8?B?SlVaZzJONjgzeWRSNkZtS0hkRXJwdE1idFlvNi9Lc09TWW1kQWtQRkFqZmtj?=
 =?utf-8?B?ZFY4MzR5SHpJUjNwL095QjJnWjhEMGR6S1hyVEhkY29LYXJoempLVU9pcVJl?=
 =?utf-8?B?SmRrN0VJREN0eHBiQkhRR1R1NlhmZGVzWGoxSTJjN0hLK3o1ZTROTDRSNDRi?=
 =?utf-8?B?WUJFTWhrMWxzT2hNWnRodjUxZU4xRURBNmJFcjd5SFV3VFVlZnBsdVBOM3hT?=
 =?utf-8?B?cm4xaVgxQzl6TkMxU0NJU1FlNWJQOGJqSmFORzJqV0tpN3hCZFhoWVhNc3dE?=
 =?utf-8?B?cUZuZjNPYlNic3dvbHdaTkVGalYwU2N6SWcvYm12aWhOeW04R2NHTTZQTnVX?=
 =?utf-8?B?a000YlU0UGVndDBXamJONFIycnE3RlRLTFFBUUF3TmJyR0o1cmhvd3Rjd093?=
 =?utf-8?B?emk0NXZPeG1jVlJ6djNGeThTOW16bVJpNUpyN3RrUkQ1cURsRmlnbDhrOXNl?=
 =?utf-8?B?eE5CTVdBSG5YQUR0LzFJaVA5OEQ0c3FaZDVuRHNXK1VtRVlRNnZ3SzI2OEI3?=
 =?utf-8?B?RzluMm1hOURpL1JEa05nNnBVMXVpQUl0cExHSHA2TTFHV1Y4b0pRWUZDT2Vq?=
 =?utf-8?B?N3ppMU9wYjhIbTJnUmdmVHIzQ1liamwvTXJkek9tbEpBL3g1Q3hINlRteklL?=
 =?utf-8?B?ZW5DdzdjbmZHUUhOTnFvdW9QMzIwZWlKT1ovdGZTZjJWTGlBYkhtZ1lXVDBJ?=
 =?utf-8?B?NFdPZGZoOElNNFVwVTVVSTVBOWt1bTMvK3NNS2dKaWpWcEFMV2tGTnk4SjFT?=
 =?utf-8?B?Ykh4RUFLb3BOMUFzNTZGbUNBVmltSlp4Z1F5K2d6SU5BaXBwcHZqR3VraFkw?=
 =?utf-8?B?SnprUEN0Wm9VZHVieXVoUTI0ZHIrZU40QWk0aDQwVnp2dlpzNzJRWW5VM0dj?=
 =?utf-8?B?T3VkODZsaXRmYzJIay9vTmZHM2FGR3QyY0R2RDlEVjYwYUV1WlFhdHNvK1pn?=
 =?utf-8?B?UHFubGE2ZTZFME9KNlRyWnl6SWdlcFFqWXE3dVdXblcyUU5jWjB1dXNGYnkz?=
 =?utf-8?B?MUYxQXVlQTczWkduWk5QU2ZKdnlYbGhiZ1ZEWWl5WU14N3llOHZxK20xYTRt?=
 =?utf-8?B?L0RLRUxhWWs1dmpUTEpSUzdFS1dpTFpSYmovUjFwWkF5MGN2N2QyOE1abWlz?=
 =?utf-8?B?QkxZTFltb1cwWVJQKzVWbXpRQ1RmMjMxNUJVWnFlMnNHR0RySzJPTWRYU2I4?=
 =?utf-8?B?VjVIZ1pLR2p1SlFRMnRLeVpkRlp3bXo5RjJWSjNYUkpaSlkvYmJIdXpVSjNB?=
 =?utf-8?Q?s5Z8=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27d23a14-ef46-4a94-733f-08dc0f3bcb90
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB7511.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2024 04:47:47.4312
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zn1MvnIXNkWyhceYvtx16711qu/ieXyZ69VkEw/pmfVwdbbWAf8E+Yr/QhGmRXaZF4vTlo4PLv+qDUFYMCB/gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7363

On Sun, Jan 07, 2024 at 08:45:06AM +0530, Manivannan Sadhasivam wrote:
> On Wed, Dec 27, 2023 at 01:27:15PM -0500, Frank Li wrote:
> > iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required
> > proptery for iMX8MQ to indicate pci controller index.
> > 
> 
> property
> 
> > This adjustment paves the way for eliminating the hardcoded check on the
> > base register for acquiring the controller_id.
> > 
> > 	...
> > 	if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> > 		imx6_pcie->controller_id = 1;
> > 	...
> > 
> > The controller_id is crucial and utilized for certain register bit
> > positions. It must align precisely with the controller index in the SoC.
> > An auto-incremented ID don't fit this case. The DTS or fuse configurations
> > may deactivate specific PCI controllers.
> > 
> 
> You cannot change the binding for the sake of driver. But you can make this
> change in other way. See below...
> 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > 
> > Notes:
> >     Change from v5 to v6
> >     - rework commit message to explain why need required and why auto increase
> >     id not work
> >     
> >     Change from v4 to v5
> >     - new patch at v5
> > 
> >  .../bindings/pci/fsl,imx6q-pcie-common.yaml           | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > index d91b639ae7ae7..8f39b4e6e8491 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > @@ -265,6 +265,17 @@ allOf:
> >              - const: apps
> >              - const: turnoff
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - fsl,imx8mq-pcie
> > +              - fsl,imx8mq-pcie-ep
> 
> "linux,pci-domain" is a generic property. So you cannot make it required only
> for certain SoCs. 

Sorry, why not? there are many generic property.

> But you can make it so for all SoCs. This way, the drivers
> can also rely on it.
> 
> Now, you should get rid of the commit message about driver internals:

Not all dts already added "linux,pci-domain" yet. If required for all SOCs,
it will cause dtb check warnings.

Frank
> 
> > This adjustment paves the way for eliminating the hardcoded check on the
> > base register for acquiring the controller_id.
> > 
> >       ...
> >       if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> >               imx6_pcie->controller_id = 1;
> >       ...
> > 
> > The controller_id is crucial and utilized for certain register bit
> > positions. It must align precisely with the controller index in the SoC.
> > An auto-incremented ID don't fit this case. The DTS or fuse configurations
> > may deactivate specific PCI controllers.
> > 
> 
> - Mani
> 
> > +    then:
> > +      required:
> > +        - linux,pci-domain
> > +
> >  additionalProperties: true
> >  
> >  ...
> > -- 
> > 2.34.1
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்