Received-SPF: pass (google.com: domain of linux-kernel+bounces-18788-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 7 Jan 2024 00:38:10 -0500
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com,
	conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com,
	helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev,
	kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
	kw@linux.com, l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de,
	shawnguo@kernel.org
Subject: Re: [PATCH v7 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain
 as required for iMX8MQ
Message-ID: <ZZo4wkHf4RE2O9UN@lizhi-Precision-Tower-5810>
References: <20231227182727.1747435-1-Frank.Li@nxp.com>
 <20231227182727.1747435-5-Frank.Li@nxp.com>
 <20240107031506.GC3416@thinkpad>
 <ZZos6LDk4NTfQHyU@lizhi-Precision-Tower-5810>
 <20240107051917.GG3416@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240107051917.GG3416@thinkpad>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ck54a3lQbkozMjlJL1g3M1pvWEl6N3V6UmdCYWhzRUp5K1NIdGk0cU5QRjhq?=
 =?utf-8?B?WEVRUHRMK2RlUzhSSndUR0RlbDZqTCtCWGxZdnI2UVY2U2lzekYxQ3YyUXh1?=
 =?utf-8?B?cWJ3N29EdmZPTHhFLzJsNU9UMDlWL1RSMmtkYmxpZy9CaUhZQ2p3NVovVlpH?=
 =?utf-8?B?bGxReWVQNVpOV25FeGVITkczZ1haRkZocFZidTZCME1tR29YQ05qOEx3d3No?=
 =?utf-8?B?OVlSVFZtUXFSdjB2cVZlamJpdUFBRHVzVnQ3VityVlFyQ2pjRWVUdWRPd05S?=
 =?utf-8?B?bzJMbDY1Y21tdmhmNlZ5VTErSGptQjNVTTFaOU0vaUREUFdqT3Z6Nit1bW9r?=
 =?utf-8?B?ZFpHdE44Y2dyU3Z1RlNCWnJNMHNYQ0tGR3JHQ0lCRlh3bXJuMUx3SlIrN2NM?=
 =?utf-8?B?SG1xNzhHQ2tycGFJN0wwRHFjSGN3YzR6WUJ2VU13T013Q3B5Qy9MSllJMndZ?=
 =?utf-8?B?ZDFkOHFuU01EK1o4bFRXUXRqWnNvY0pxQ29EeHMvMUNWV3YyZHE2a1UxeE5P?=
 =?utf-8?B?NWtTV3poK0RrUkdxa1ZqWVlBbGZQamhaSzU4bHVFMk8wamw3Nk13UTRjUXhq?=
 =?utf-8?B?YkF6b3NDak5BZkJHQk5uSHJaUlZNSUJ4Ry9CalhNeU1IU2lZTVFoMDBZZUZZ?=
 =?utf-8?B?RHFUaUdrSUpGOVZ6VzJvRjJQa2dmRTFjcjFrWFQzWHJFdnloSmNYbEkwaVl2?=
 =?utf-8?B?VEpwU0NXMjNoc3luc1ljM2g3cUhzU1FPNGlKbVh0cjkxUmo3cHBSWkRVNk9l?=
 =?utf-8?B?QVVCeDlQZEp0MWl1MW5hcmhHUXltNXN3YStvK1FsYkhJUzdWU1VWWkNhQi9D?=
 =?utf-8?B?b09odWZKVStGR1VWQUF2RXk2M2NGWFpHOTVITk5uL2Y1SFF2cE9lUldGNktU?=
 =?utf-8?B?WDhseGM5RWlxcWpvQ29NU0E4QXpubkpMQ2F5Q0NnZmxGOXVBT3luM2FpWEdC?=
 =?utf-8?B?N0RRLytjdWtUUEhhTGxhNy9tNHpsUWNiaTQwSGM4ZjVqS0F6RVFvanV2SVpx?=
 =?utf-8?B?bzBpMUc4OUxrUzI0RzJHMzNLbDg3YU15VW85dm9iOWMxNXJsc1o4amFkOTFi?=
 =?utf-8?B?NnRTakJXSENSZkFpTTZnY2V3RG1XZkFna0ZhVXVhdGszbWlYMFZaRXBTaEJD?=
 =?utf-8?B?NGlkaWpFaEMzcmVwMHJlWWtIS0pFNG9iMFA5ZGRySjhwS09YNmEzY20vS1RX?=
 =?utf-8?B?RVpRdzRya051UHFTR2ZlZWJ5cFVkdVdVUGs1RE91cXhCL2xCb1ZIREUza0dm?=
 =?utf-8?B?eThKTnp1eldKbkZEc29kUjRxK1M1UEdDcXVpZFUwUERFSnh4cm4yWEkyeWZR?=
 =?utf-8?B?b0ZpQnFXZ3dYYmpnV0kxZXNYSHNLV1VzUmFIV1hMc1E2QkdydWEzckFQNzBF?=
 =?utf-8?B?Z2tpbW9NOEFHNHNCNWhWVmhaKy9nUWtEeFdRa1FiN2NJZ0RPLytXL0pNdmMz?=
 =?utf-8?B?RDY4TFRHZmhqYlEwQnM2Z2dSTThFZjF0QUFaRk5Ha3pzRjFMNUJlNllZMHBu?=
 =?utf-8?B?eXZrckxENWMyRTlQNlgvV0ovRUJhOGJ2alhRZWk2US93Qkk3b0FiV3NOZkFy?=
 =?utf-8?B?aWRFam9ST1RCSmtoekdkS0g0WCtyZnNxTlFYRUFlTEp1MFJBejcvME5acWZ0?=
 =?utf-8?B?L0xUTTFidThTSzcrcDFzSTAycnJPWG1nNVlSOHZjT2Z6bjNKMzUxTzBOYXk4?=
 =?utf-8?B?dHd0T3RqWHhCaHdaekoxYUNRTmZ2RHBwbzl4cjl5ZStvRzNIMEJ5MG92SnRn?=
 =?utf-8?B?Q29FUERaMTVIRk96bjhFYTdSWlhxRURQRmEvempQYmpzejA4QWhoT0hZNzlG?=
 =?utf-8?B?Z0dzNFdKUmp0bXozenhudzlnM3VwZmZiWm01L1p0ZTg4RkFyZWFEWHIxVzJC?=
 =?utf-8?B?NGRQbVlzZ1lBMHlDWWMwSXRoTTdjSk5HQXJnb3FibWhLMDJOQmhnSGRXRVRT?=
 =?utf-8?B?TGF4YkxJbFZTN1ZXeElyREFiek93N0lCcGxpREcyNUwySFJLRjl2MnpOZC9j?=
 =?utf-8?B?Y0JidUUzelBTTlNCZGRtY3cwVEVxM2hKaVBhaWYzb1VoaXEvQXRTTmV5aDRt?=
 =?utf-8?B?eGlsQjJZUTdQWTFXN05jODVvZ2QrM1FldWdtalpVdEdDbXVjeDRPMXJYQWZm?=
 =?utf-8?Q?pfWM=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e958b3d1-b204-450d-c9f3-08dc0f42db39
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB7511.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2024 05:38:20.1284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bkPq1XZ0/YCMSFCSGNyhGyT/kqKyiL4Ph94GSE97VN1biP4zfeq4BL9/EQF5q85VpX99gNEpPYXAXCY1Bxm0BA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8033

On Sun, Jan 07, 2024 at 10:49:17AM +0530, Manivannan Sadhasivam wrote:
> On Sat, Jan 06, 2024 at 11:47:36PM -0500, Frank Li wrote:
> > On Sun, Jan 07, 2024 at 08:45:06AM +0530, Manivannan Sadhasivam wrote:
> > > On Wed, Dec 27, 2023 at 01:27:15PM -0500, Frank Li wrote:
> > > > iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required
> > > > proptery for iMX8MQ to indicate pci controller index.
> > > > 
> > > 
> > > property
> > > 
> > > > This adjustment paves the way for eliminating the hardcoded check on the
> > > > base register for acquiring the controller_id.
> > > > 
> > > > 	...
> > > > 	if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> > > > 		imx6_pcie->controller_id = 1;
> > > > 	...
> > > > 
> > > > The controller_id is crucial and utilized for certain register bit
> > > > positions. It must align precisely with the controller index in the SoC.
> > > > An auto-incremented ID don't fit this case. The DTS or fuse configurations
> > > > may deactivate specific PCI controllers.
> > > > 
> > > 
> > > You cannot change the binding for the sake of driver. But you can make this
> > > change in other way. See below...
> > > 
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > > 
> > > > Notes:
> > > >     Change from v5 to v6
> > > >     - rework commit message to explain why need required and why auto increase
> > > >     id not work
> > > >     
> > > >     Change from v4 to v5
> > > >     - new patch at v5
> > > > 
> > > >  .../bindings/pci/fsl,imx6q-pcie-common.yaml           | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > > > index d91b639ae7ae7..8f39b4e6e8491 100644
> > > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > > > @@ -265,6 +265,17 @@ allOf:
> > > >              - const: apps
> > > >              - const: turnoff
> > > >  
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          contains:
> > > > +            enum:
> > > > +              - fsl,imx8mq-pcie
> > > > +              - fsl,imx8mq-pcie-ep
> > > 
> > > "linux,pci-domain" is a generic property. So you cannot make it required only
> > > for certain SoCs. 
> > 
> > Sorry, why not? there are many generic property.
> > 
> 
> It doesn't make sense to make it required only for specific SoCs since it is not
> specific to any SoC. You can make it required for all.

More than 2 controller need require "linux,pci-domain".

> 
> > > But you can make it so for all SoCs. This way, the drivers
> > > can also rely on it.
> > > 
> > > Now, you should get rid of the commit message about driver internals:
> > 
> > Not all dts already added "linux,pci-domain" yet. If required for all SOCs,
> > it will cause dtb check warnings.
> > 
> 
> You can safely add this property to all DTS. Nothing will break.

Yes, but it will be off topic of this patch serial.

I can submit new patches for this later. After all dts changed, then I
remove this conditional check.

This patch serial is already quite big, (17 patches).

And I don't want to involve new DTB check warning.

Frank

> 
> - Mani
> 
> > Frank
> > > 
> > > > This adjustment paves the way for eliminating the hardcoded check on the
> > > > base register for acquiring the controller_id.
> > > > 
> > > >       ...
> > > >       if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> > > >               imx6_pcie->controller_id = 1;
> > > >       ...
> > > > 
> > > > The controller_id is crucial and utilized for certain register bit
> > > > positions. It must align precisely with the controller index in the SoC.
> > > > An auto-incremented ID don't fit this case. The DTS or fuse configurations
> > > > may deactivate specific PCI controllers.
> > > > 
> > > 
> > > - Mani
> > > 
> > > > +    then:
> > > > +      required:
> > > > +        - linux,pci-domain
> > > > +
> > > >  additionalProperties: true
> > > >  
> > > >  ...
> > > > -- 
> > > > 2.34.1
> > > > 
> > > 
> > > -- 
> > > மணிவண்ணன் சதாசிவம்
> 
> -- 
> மணிவண்ணன் சதாசிவம்