Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1099672rdb; Sun, 7 Jan 2024 03:57:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IFgB354MuT76pjv6Nd27TlQi4qZ8dN130qBBx8FV4NMtnu1XaL6/fljBkAby+3oEOgDHedQ X-Received: by 2002:ac8:5a04:0:b0:429:89f5:5e6f with SMTP id n4-20020ac85a04000000b0042989f55e6fmr2255551qta.15.1704628635364; Sun, 07 Jan 2024 03:57:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704628635; cv=none; d=google.com; s=arc-20160816; b=YRx/jHzuSkmYydIDTC2BMpYAUt3t/unM8Vh2lSB1WIWnOldnYcuZ6XBNRZdm+faPjq VIuhiHOzlRZzFr4guCkkWurvy+zxsV5xBNEc4TxNRtmrc06BeG9EddWEKPoR1jISDhB8 dBUlBh4h6XPosFZC3BsnXHBSWXWroaO3dBDT35V73yxiYseLx/E88xQk4M3CCQoS0211 Fe8YQ8olrMWW0FIKD5++z8RkFEuZ7Lj5vO9nA5Vh6qvt1i6FsZMKCVXojP6GZtbrM7ey 4FIo0JU5ZTnLJ5lZ78XB0xyr6veN/3EEQWXQzpcYEfgzjprdh/a/FloT5kVTw2Skd9BR IbzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=60gxa1noVk5cpuesKhyJXaBSd7M6NODkl1WRf8H+12E=; fh=gMK3CaWZ0hQzNl7Vcn5IrQKiZN1N9dECtJpcGlcn8OE=; b=zHQQTl+ReVfyx0OKl7HLyE+5tKMM5bElwrBv4t1+fhMYZpUcgNPb1c3jpF7xyUl2n7 YEv1Kh7t5jSBNkKGqTw9J8CDHHWAc4mJKIZ7FgkLN8D2r/k8XF5n+g7BfVjY7PD/Gbmp jXPgSV8fmVndF3JRnnUCrTmoSg5U1PdCehw6AtYs9+wgK1PvoyZlBod56HIZGL7+r9At UCVAJNcLO9RYBBmS1dhAi/KUsesXb8qihgy14wyTgPFr7Bqm1icJI59uPHzfYte5/Kuq CPoTPHluZfWWMOusy4nxwUEevoCCcvgzNdyRCW9qNIwQbebbKsoscgc5jC4GhbQiuOBr q3lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W3tdgJbF; spf=pass (google.com: domain of linux-kernel+bounces-18850-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18850-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id z15-20020ac87f8f000000b004297543e51bsi5652199qtj.679.2024.01.07.03.57.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 03:57:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18850-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W3tdgJbF; spf=pass (google.com: domain of linux-kernel+bounces-18850-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18850-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E929D1C20BFD for ; Sun, 7 Jan 2024 11:57:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 49AAB12E4A; Sun, 7 Jan 2024 11:57:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W3tdgJbF" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0369A12E40 for ; Sun, 7 Jan 2024 11:57:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-55783b7b47aso443073a12.0 for ; Sun, 07 Jan 2024 03:57:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704628621; x=1705233421; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=60gxa1noVk5cpuesKhyJXaBSd7M6NODkl1WRf8H+12E=; b=W3tdgJbFdyfzgCnYO+PivXNUvKZislgrsknGVDl8aSjs+ASYtV9IjprlkHNAlPxoa+ EjlX+v8MDHwuSBihGh5h4m04L7xfbkoi2GxJPahVbFO4Wu5m/LdAG+06z3+qLpvBK4tc SqapV8Hnm82dhaRw+IpzlGVZKBK9ge1rIhfYeKS3zrp9ZULzbIx3kGHoiRKU0fd6KkEr Iu6wO+ley7RQDTa9Q69+YqJdu7rS0jL0BNwg1Wil18IUMJ9jAGg4D5a/emKtMtlwKw5T /gAwrNFkLFsFRKllAe08r4fMeAce/wNUm6tTW4JWr+CCFcpAGcPI3I7FFUYKrNg740YL cGiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704628621; x=1705233421; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=60gxa1noVk5cpuesKhyJXaBSd7M6NODkl1WRf8H+12E=; b=lxhl7bHlqbfo1uD5tDWuZQUDRLPhLfSFIsLVdr/yaeE3u9yEuig9eHD8pzW0tpA5EN 4mHHdldeqbgoPadqRmducB2As8tWFbl2JsSzxRS2jXkiMSokowJXMZrsiBNYUuFVme/W sw/fHL2t6AD7d0B7BI9z/fyBEVR1TA4NE7S1nEsCJboc2ken6hf1DuB+eEAbxLy5CJlD bAFttwHQR+jH7t9kdX4RSWF9HnvPJMkTyJItFnSDM5gEYElqQcWxz97UvsP10yfLse7/ g4bFfUBz7mUp6RKhyCLBqXAb7GpliwI2MWHdBgrEvZfAOiKUattSt7yOkvHHbY1M2PsT vpmA== X-Gm-Message-State: AOJu0Yzey9h1q+3G+OcNi4N3SQ61lsEJeboW8i51l3Dl5hjZjSn3GObk WBOcNC8fLNX/6wZHzFUVpz6pUIrHzgEy6Q== X-Received: by 2002:a50:9b4f:0:b0:557:639e:ae21 with SMTP id a15-20020a509b4f000000b00557639eae21mr1099610edj.23.1704628621347; Sun, 07 Jan 2024 03:57:01 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.112]) by smtp.gmail.com with ESMTPSA id q4-20020a056402248400b005579c887effsm529167eda.79.2024.01.07.03.56.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jan 2024 03:57:00 -0800 (PST) Message-ID: Date: Sun, 7 Jan 2024 12:56:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] reset: gpio: Add GPIO-based reset controller Content-Language: en-US To: Biju Das , Srinivas Kandagatla , Banajit Goswami , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-arm-msm@vger.kernel.org" , "linux-sound@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: Bartosz Golaszewski , Sean Anderson References: <20240105155918.279657-1-krzysztof.kozlowski@linaro.org> <20240105155918.279657-2-krzysztof.kozlowski@linaro.org> <40b4d29e-fa5c-43d5-8ccb-4a5a41150546@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/01/2024 11:46, Biju Das wrote: >>>> + >>>> + if (!platdata || !*platdata) >>> >>> Maybe, if (!(platdata && *platdata)) which reduces 1 inversion >> operation. >> >> I would not call it easier to understand... To me !A and !*A are quite >> obvious and easy to read instantly because !A is obvious: check if it is >> not NULL. Therefore original check is obvious: is NULL or points to NULL? >> Then exit. >> >> Now your check is a bit more complicated. It is not even frequent code >> pattern which my brain used to see. You want to check if both are not NULL >> and then negate it, wait, no, opposite, check if they are something and >> then negate? To me it is really opposite of readable code. > > I agree maybe it is not readable, even though it reduces 1 extra operation. > Number of operations does not matter. Code readability matters. Compilers are nowadays smarter than us, so don't write code more difficult to read just to optimize some instruction like this. Best regards, Krzysztof