Received-SPF: pass (google.com: domain of linux-kernel+bounces-18860-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 7 Jan 2024 20:49:52 +0800
From: Hangbin Liu <liuhangbin@gmail.com>
To: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH v1 1/1] selftests: net: increase timeout value for tests
Message-ID: <ZZqd8PqvHlYCqbMX@Laptop-X1>
References: <20240107003929.891669-1-mirsad.todorovac@alu.unizg.hr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240107003929.891669-1-mirsad.todorovac@alu.unizg.hr>

On Sun, Jan 07, 2024 at 01:39:29AM +0100, Mirsad Todorovac wrote:
> In particular, fcnal-test.sh timed out on slower hardware after
> some new permutations of tests were added.
> 
> This single test ran for almost an hour instead of the expected
> 25 min (1500s). 75 minutes should suffice for most systems.
> 
> Cc: David Ahern <dsahern@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: netdev@vger.kernel.org
> Cc: linux-kselftest@vger.kernel.org
> Signed-off-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
> ---
>  tools/testing/selftests/net/settings | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings
> index dfc27cdc6c05..ed8418e8217a 100644
> --- a/tools/testing/selftests/net/settings
> +++ b/tools/testing/selftests/net/settings
> @@ -1 +1 @@
> -timeout=1500
> +timeout=4500
> -- 
> 2.40.1
> 

FYI, the net-next patch 779283b7770f ("selftests/net: convert fcnal-test.sh
to run it in unique namespace") has extended the timeout to 3600s.

Thanks
Hangbin