Received-SPF: pass (google.com: domain of linux-kernel+bounces-18896-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sun, 7 Jan 2024 15:33:49 +0000
From: Mark Brown <broonie@kernel.org>
To: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado <nfraprado@collabora.com>,
	linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v1 3/4] ksellftest: alsa: Fix the printf format specifier
 to unsigned int
Message-ID: <ZZrEXSU3Bx85rSGo@finisterre.sirena.org.uk>
References: <20240107151218.933806-1-mirsad.todorovac@alu.unizg.hr>
 <20240107151218.933806-4-mirsad.todorovac@alu.unizg.hr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="p9mm3phoO9jkv5GJ"
Content-Disposition: inline
In-Reply-To: <20240107151218.933806-4-mirsad.todorovac@alu.unizg.hr>


--p9mm3phoO9jkv5GJ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 07, 2024 at 04:12:20PM +0100, Mirsad Todorovac wrote:

> mixer-test.c:350:80: warning: format =E2=80=98%ld=E2=80=99 expects argume=
nt of type =E2=80=98long int=E2=80=99, \
> 			      but argument 5 has type =E2=80=98unsigned int=E2=80=99 [-Wformat=
=3D]

If this is the issue then...

> -			ksft_print_msg("%s.%d value %ld more than item count %ld\n",
> +			ksft_print_msg("%s.%d value %ld more than item count %d\n",
>  				       ctl->name, index, int_val,
>  				       snd_ctl_elem_info_get_items(ctl->info));

=2E..why are we not using an unsigned format specifier here?  I am very
suprised this doesn't continue to warn.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

--p9mm3phoO9jkv5GJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWaxF0ACgkQJNaLcl1U
h9CdNQf/eSp1ZBFqDqiG3/RzhWZq0q6Cxi19N7gfrqosUu9wmJszlaYOwjkl7NIS
bM5J3aQTUHrl14v/kctmvg9YokFIRRIY95EJq/4nVrx8CWHeylXMhw8LVuBjaJu1
Dm0WBl//R/lKeiqICnld9WI8xiLJ9bqNDZAGQzJSKbtsHXaB+iIE0nDL4KVniz4t
C7tLJDBRnFS+i9cCGQPGq278lt0Ne4YBg+bU9lCQhCunaS8YvF4qas1w/0wYapTq
Kezrn28qcEYZo2cEv/hW3dUpJCSnkTRCYrVNP18M4bWv7zbjEU4K5zuS/PRtZhU9
/mvxxSeGKCXHJvWlZRoObfbh5uK91g==
=SaVm
-----END PGP SIGNATURE-----

--p9mm3phoO9jkv5GJ--