Received-SPF: pass (google.com: domain of linux-kernel+bounces-18899-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 7 Jan 2024 15:53:33 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter
 Clausen <lars@metafoo.de>
Subject: Re: [PATCH 1/1] tools: iio: fix iio_generic_buffer
Message-ID: <20240107155333.0e43b041@jic23-huawei>
In-Reply-To: <20240104101253.25896-2-petre.rodan@subdimension.ro>
References: <20240104101253.25896-1-petre.rodan@subdimension.ro>
	<20240104101253.25896-2-petre.rodan@subdimension.ro>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu,  4 Jan 2024 12:12:45 +0200
Petre Rodan <petre.rodan@subdimension.ro> wrote:

> Fix code flow problem and floating point exception caused by improper
> directory stream positioning.
> 
> Fixes: <e58537ccce733> ("staging: iio: update example application.")
> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
Hi Petre,

This doesn't really explain 'why' seeekdir(dp, 0) is wrong.
My assumption is that telldir() would not have returned 0 on this particular
system?  Could you confirm that and update the message to explain why
seekdir(dp, 0) is not equivalent to rewinddir(dp). 

Thanks,

Jonathan

> ---
>  tools/iio/iio_utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/iio/iio_utils.c b/tools/iio/iio_utils.c
> index 6a00a6eecaef..c5c5082cb24e 100644
> --- a/tools/iio/iio_utils.c
> +++ b/tools/iio/iio_utils.c
> @@ -376,7 +376,7 @@ int build_channel_array(const char *device_dir, int buffer_idx,
>  		goto error_close_dir;
>  	}
> 
> -	seekdir(dp, 0);
> +	rewinddir(dp);
>  	while (ent = readdir(dp), ent) {
>  		if (strcmp(ent->d_name + strlen(ent->d_name) - strlen("_en"),
>  			   "_en") == 0) {
> --
> 2.41.0
>