Received-SPF: pass (google.com: domain of linux-kernel+bounces-18917-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sun, 7 Jan 2024 18:28:52 +0200
From: Petre Rodan <petre.rodan@subdimension.ro>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 1/1] tools: iio: fix iio_generic_buffer
Message-ID: <ZZrRRNTUbXaDIgRU@sunspire>
References: <20240104101253.25896-1-petre.rodan@subdimension.ro>
 <20240104101253.25896-2-petre.rodan@subdimension.ro>
 <20240107155333.0e43b041@jic23-huawei>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Zqf1JCAeZ2jJLOAM"
Content-Disposition: inline
In-Reply-To: <20240107155333.0e43b041@jic23-huawei>


--Zqf1JCAeZ2jJLOAM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


Hi Jonathan,

On Sun, Jan 07, 2024 at 03:53:33PM +0000, Jonathan Cameron wrote:
> On Thu,  4 Jan 2024 12:12:45 +0200
> Petre Rodan <petre.rodan@subdimension.ro> wrote:
>=20
> > Fix code flow problem and floating point exception caused by improper
> > directory stream positioning.
> >=20
> > Fixes: <e58537ccce733> ("staging: iio: update example application.")
> > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
> Hi Petre,
>=20
> This doesn't really explain 'why' seeekdir(dp, 0) is wrong.
> My assumption is that telldir() would not have returned 0 on this particu=
lar
> system?  Could you confirm that and update the message to explain why
> seekdir(dp, 0) is not equivalent to rewinddir(dp).

it looks like there is a 32-bit specific bug in one of the glibc patches th=
at
the stable Gentoo Linux is using [1]. telldir returns (u32)(-1) if seekdir =
is
used which ends up in a floating point exception.

it so happens that the rewinddir() function (which is equivalent) works
correctly. so it is a fix for Gentoo users and should not impact anyone els=
e.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=3D31212

my very best regards,
peter

> Thanks,
>=20
> Jonathan
>=20
> > ---
> >  tools/iio/iio_utils.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/tools/iio/iio_utils.c b/tools/iio/iio_utils.c
> > index 6a00a6eecaef..c5c5082cb24e 100644
> > --- a/tools/iio/iio_utils.c
> > +++ b/tools/iio/iio_utils.c
> > @@ -376,7 +376,7 @@ int build_channel_array(const char *device_dir, int=
 buffer_idx,
> >  		goto error_close_dir;
> >  	}
> >=20
> > -	seekdir(dp, 0);
> > +	rewinddir(dp);
> >  	while (ent =3D readdir(dp), ent) {
> >  		if (strcmp(ent->d_name + strlen(ent->d_name) - strlen("_en"),
> >  			   "_en") =3D=3D 0) {
> > --
> > 2.41.0

--Zqf1JCAeZ2jJLOAM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE2Ap/wXYVGTXsPl+pzyaZmYROfzAFAmWa0UQACgkQzyaZmYRO
fzDovg//VVy5Z6eThxtYXOO6ZHyAlKAr2dAxJeh9tO464Lkzq3VYWfPj5j1FbKjk
WOlUYa0oa3CLew0NQR4WuH4nxbs9TJD5EQxO6TYanZ0JGxVUDv15sz517G3XZ7uS
x60asWALVNH0jWMTUYE+lmSrAnS1fREnkAkZDv+AFCkTvjrEr/WXV0juUtwqxlgR
6mmSRTd1VpEdWJL/NDBaF7M7O059ubRTA8LQeJ7aFaqCtuoWCB6cngK77P9LMqLS
3xxG9eyT+0rzPB9uYoZaNcutPNT80IUZL4DhPESE1Tdo9VsdWBb6NflQ35JAn6tN
YBYUbz0qzXvF9thT5C+M6HJJ44/VOnXml8zFrggjaIRHFKvLO6wx6sFsV4Ls5jvl
IXGMit2OQJHRKA5sz/MNHvlumwC/FNoTlRewYKYRQrxDOZ5TseXxj9QsTx/oxM+7
7KusWUXDl3Zb4lnnzZFTCPwUoznMJlGym/R0IEb2naHW5gOoESbwIjZPrLKC7X2N
fV1+m1zS1HNXOS5iICqelz1pd2qtDVC1m1FkuMlt8rhw5ySYPqvwBSnlS3/GQgJz
D2z8FfgFZ2cwyekStc/fwE1aeYu/9uiQ+xu9X/g8D6OpfMqqG/nIMM3NrM/b7nYA
onHMsex+41aB21Bxe0UnzvPLCw6PhZzirnAyD7UfaZBvk/igcPk=
=5e1c
-----END PGP SIGNATURE-----

--Zqf1JCAeZ2jJLOAM--