Received-SPF: pass (google.com: domain of linux-kernel+bounces-18920-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 7 Jan 2024 16:32:15 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petre Rodan <petre.rodan@subdimension.ro>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org, Andreas Klinger <ak@it-klinger.de>,
 Lars-Peter Clausen <lars@metafoo.de>, Angel Iglesias
 <ang.iglesiasg@gmail.com>, Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v3 10/10] iio: pressure: mprls0025pa add SPI driver
Message-ID: <20240107163215.427b563d@jic23-huawei>
In-Reply-To: <ZZl628UdGQ_Bu2jy@smile.fi.intel.com>
References: <20231229092445.30180-1-petre.rodan@subdimension.ro>
	<20231229092445.30180-11-petre.rodan@subdimension.ro>
	<ZZlyDT0J4n1_YXh4@smile.fi.intel.com>
	<ZZl5rBPOKwvxZAAx@sunspire>
	<ZZl628UdGQ_Bu2jy@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 6 Jan 2024 18:07:55 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Sat, Jan 06, 2024 at 06:02:52PM +0200, Petre Rodan wrote:
> > On Sat, Jan 06, 2024 at 05:30:21PM +0200, Andy Shevchenko wrote:  
> > > On Fri, Dec 29, 2023 at 11:24:38AM +0200, Petre Rodan wrote:  
> > > > Add SPI component of the driver.  
> 
> > > > +#include <linux/mod_devicetable.h>
> > > > +#include <linux/module.h>
> > > > +#include <linux/spi/spi.h>
> > > > +#include <linux/stddef.h>  
> > > 
> > > Basically here we need additionally these ones:
> > > 
> > > device.h
> > > errno.h
> > > types.h  
> > 
> > ok, I'll add errno.h. the other two are in the shared .h file.  
> 
> Yes, but it's better to follow IWYI principle. Generally speaking
> there is no guarantee that above will be _always_ the case.
> 
> Anyway, I leave this to Jonathan.
> 
When it's a local include to the driver like this I don't mind
as much if the includes aren't there in the c file, but do generally
'slightly prefer' them to be so.  As such I've added them here and
in the i2c file (I also renamed that patch as 'refactor' isn't
exactly descriptive in the patch title!)  I suspect none of us
feel that strongly about this so rather than slowing things down
I took a fairly random decision that let me apply the series today.

Anyhow, along with dropping the text on what this was tested on in
the final patch - series applied to the togreg branch of iio.git.

However, I'll be rebasing that tree on rc1 once available hence
for now this will only be pushed out as testing for 0-day to get
a head start on poking it.

Thanks,

Jonathan