Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1216939rdb; Sun, 7 Jan 2024 08:46:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8VANEqc3uyhvrm27LF+laqiAHChvL6GAbLEVxT+cqCxK4dL8rAotwo/0VUuuOl8Ck9iQd X-Received: by 2002:a05:6e02:318e:b0:35f:af09:23d1 with SMTP id cb14-20020a056e02318e00b0035faf0923d1mr5100083ilb.28.1704645984887; Sun, 07 Jan 2024 08:46:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704645984; cv=none; d=google.com; s=arc-20160816; b=u2u5ZXbrD02SUy+hC0wL6k3h57lr1GAwM5xoOmLgwvSpKQJ6Z3z2pogjCeBxUajxkz BPzEQ35YTHwcKmXPWt3FaPhgdStXjMPmGlMmEl1W+HctJoJ7NLjWFmKAblTy5ISqeCh6 Hu6YhXtpURxjEbY1KITMsvbR3K/qC3odsOsMdOfUIG7CSB/7lxS8tsFsCOg4jVG68RXn 8Zo8Wxf9yY2fgiScVSk3k0ZuWnXedThurzFyvYrBkK9P/Nt1jSM5G9a18bGDenp5Fpuq Sao2Uwutx+4KVp/IG0C+c1LQ+cPgxElDAZ6irWBWZjWa9J+iLWgqx8F7ZZgmBBEGKFR/ c72A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date :dkim-signature; bh=spp2negAoDE91Yk0CKaN80jgjnsO3+MueAKeHJ0K3J8=; fh=OsQ9/Iz9UI1W8Ag57k1xrfmNXMsMJmGPqtBpgj7+68I=; b=YcyJ7SUmsMVJB/n/1kGx+skBcUo9RDkGiYzMmizczIagAjBU3Zar2ni/Nc1z+LCHGy NUy0hfsrx8b7m+Vhg+nGfbK+4jwE7+U7dYslqieD72N5CFp5nAuBpRBUyLmTdtFDZpnA HFXsOF3Nz9UbWKaIbPHYcyFp8qg3aHhOf8ajMTXl86EOUQr0pegpjKMjTIxTBVOXGIOK H6YnnpV3obIhXZqU4dkxO0NefpwdBQNPA2SBpjAdf0WB2EYZmIwtHrnb++WgzdlFwdbU 7XrIHDHkXCQJaqxjFWMyyRszavFrB+dgFXL0D6JT5EH6pI2rUK9Cr5A05whok/QrlArB Jg4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=SFeBvTtD; spf=pass (google.com: domain of linux-kernel+bounces-18924-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18924-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id o7-20020a1709026b0700b001d5086ad3b4si2600245plk.413.2024.01.07.08.46.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 08:46:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18924-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=SFeBvTtD; spf=pass (google.com: domain of linux-kernel+bounces-18924-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18924-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6BE35B21526 for ; Sun, 7 Jan 2024 16:46:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 719F313AE8; Sun, 7 Jan 2024 16:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SFeBvTtD" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3904113AD5 for ; Sun, 7 Jan 2024 16:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-336788cb261so1123734f8f.3 for ; Sun, 07 Jan 2024 08:46:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704645971; x=1705250771; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=spp2negAoDE91Yk0CKaN80jgjnsO3+MueAKeHJ0K3J8=; b=SFeBvTtDFGkLgstgTtvhvP+oq5MhqtFeo5ZEK7aLqXWkwPqJudKhUgNIKtZU9wqrIn Vs3GcZB8jnxsplvH10E0JpgCCVswOcgZbP+eQxgJw8OASbsDWD+S2aeMXtFwUTlLrJ8v PEBQEKxKI8U5zje+kpNnZn7E6ZiPzC18tLj1p5z4lphw0NuMD5QFj2DA4flRYUxPuV5I SffUh7Z+7OU7+cMAvI91lZELgU56NJg6vwKfuHWL/yofMHWow9idDm0EuluQyU13ZBuG Mc32XCc1CmKCGS26vGjqJLPpUVkc51ZF6AMW7LpLjinF/WLpkD+atukEAbAv7rkH8PbC uzmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704645971; x=1705250771; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=spp2negAoDE91Yk0CKaN80jgjnsO3+MueAKeHJ0K3J8=; b=NyrC24cx7LN0bjWuN0d+ENhC/ab3pCyABHuyp+Dy5xCPC9gdjyUTHsfwbTZB3uTR8N RUiMWjS62NQ0Ex+/R0Vrkt5EuHaZSnghH4kW6tBUIZdMtJgI0g0v9FWWNDgAWcEo/hm7 NlcFMQa3qKqaV24rF+aWWwKTmP0qNrdGucVEJLLTGxxIB+pbrmCC08FbwmSKTecPz6pJ 953Cp/i5o4qnZZ5VNlY5q6IcPKuklEhfC6b1Kz1/J1EfPhlREK4h75d944Ghu43ZRsnN xDvLeYc1ZEsEBpCtkRhh16aNuFAESR2RF1Ka5t4iIRFrhFLIwgIRiBC3jNlv3zaptJXo OzNw== X-Gm-Message-State: AOJu0YyfvstZwEKI75xD6nqdfZ8KvN/gXHsjGxVk3s/e3MQ9ywYeZ4LQ tSI99p8hEHS6LAZJ0wxi3YGsUQc3rw== X-Received: by 2002:a5d:690d:0:b0:336:e366:471 with SMTP id t13-20020a5d690d000000b00336e3660471mr1225561wru.58.1704645971108; Sun, 07 Jan 2024 08:46:11 -0800 (PST) Received: from p183 ([46.53.248.125]) by smtp.gmail.com with ESMTPSA id c17-20020a5d4cd1000000b00336a0c083easm5685483wrt.53.2024.01.07.08.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 08:46:10 -0800 (PST) Date: Sun, 7 Jan 2024 19:46:08 +0300 From: Alexey Dobriyan To: Yukai Wu Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/mm: Remove unnecessary casts in init_64.c Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline > - pgd = (pgd_t *)page_address(page) + pgd_index(addr); > + pgd = page_address(page) + pgd_index(addr); Please learn C operator precedence rules before touching this code. > - pgd = (pgd_t *)page_address(page) + pgd_index(addr); > + pgd = page_address(page) + pgd_index(addr);