Received-SPF: pass (google.com: domain of linux-kernel+bounces-18927-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sun, 7 Jan 2024 19:04:39 +0200
From: Petre Rodan <petre.rodan@subdimension.ro>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 1/1] tools: iio: fix iio_generic_buffer
Message-ID: <ZZrZp4VNdmBzA4lR@sunspire>
References: <20240104101253.25896-1-petre.rodan@subdimension.ro>
 <20240104101253.25896-2-petre.rodan@subdimension.ro>
 <20240107155333.0e43b041@jic23-huawei>
 <ZZrRRNTUbXaDIgRU@sunspire>
 <20240107170026.6baccc49@jic23-huawei>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="h7AGFP2sAjLPuOv5"
Content-Disposition: inline
In-Reply-To: <20240107170026.6baccc49@jic23-huawei>


--h7AGFP2sAjLPuOv5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


Hi Jonathan,

On Sun, Jan 07, 2024 at 05:00:26PM +0000, Jonathan Cameron wrote:
> > On Sun, Jan 07, 2024 at 03:53:33PM +0000, Jonathan Cameron wrote:
> > > On Thu,  4 Jan 2024 12:12:45 +0200
> > > Petre Rodan <petre.rodan@subdimension.ro> wrote:
> > >  =20
> > > > Fix code flow problem and floating point exception caused by improp=
er
> > > > directory stream positioning.
> > > >=20
> > > > Fixes: <e58537ccce733> ("staging: iio: update example application.")
> > > > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> =20
> > > Hi Petre,
> > >=20
> > > This doesn't really explain 'why' seeekdir(dp, 0) is wrong.
> > > My assumption is that telldir() would not have returned 0 on this par=
ticular
> > > system?  Could you confirm that and update the message to explain why
> > > seekdir(dp, 0) is not equivalent to rewinddir(dp). =20
> >=20
> > it looks like there is a 32-bit specific bug in one of the glibc patche=
s that
> > the stable Gentoo Linux is using [1]. telldir returns (u32)(-1) if seek=
dir is
> > used which ends up in a floating point exception.
> >=20
> > it so happens that the rewinddir() function (which is equivalent) works
> > correctly. so it is a fix for Gentoo users and should not impact anyone=
 else.
> >=20
> > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=3D31212
> >=20
> > my very best regards,
> > peter
>=20
> I'd be happy to take the same change as a cleanup if you want to resubmit=
 it
> with a different patch description.

sure, I will resubmit it, but tomorrow morning.

best regards,
peter

--h7AGFP2sAjLPuOv5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE2Ap/wXYVGTXsPl+pzyaZmYROfzAFAmWa2acACgkQzyaZmYRO
fzBFIxAAkYFjUkr27o/sG18/liGK3WV9HqanIAI5hnU8vmBAyJhG50zekJX6Golc
6WXi4VLWHn1ZpItx6Bw+3+G3k0kPD6UvfcbQ5tyKcc46Klby7ZEuSASWQdSD6IVQ
XhBbyg4WQfrALh2EOdR5CnAZDMMDXU0zaGMcNEAUXoQPlWszZzCA9x+jYUR7B5l7
UCOTgPwlSgNN2T4kBjUFOKsCYR8SAueAHxh7tQnwBDmAAwD1Cd1yWXDEd1osA8kK
kibl3R6mNroH90jM0X8sW4++hx7sY4pZL5sHE+jyhtn/Um7jyFP2jrFq9eLirGFd
fUMiwJ5u4X+Op95ZnK6RTVFG5nKs5awJ7Pi1kj3HrcomDZsXMWDUfK/aOJWWGu8b
trJ2zlSgpQLJZgEvwNb97eIF3tyEWyFRehSegCbrwzJPs9HifTa/0nvkYLs7JPUo
mcEi14I+PnwqMVhVCmNbV8Q4hg+qgSY4tzG5HmH4qnjViZy6DeqQlLvgeeAUkeBl
y7L9mtZgRPq6RRJOj6dVmqVJDOedQEGZguUXqphN7v7LHJ8grzb1iooxA+PApkhM
hzlDsQfmzMhqq9Pkh1MiuQEArW8ZeKAuWz6RyFMKRyiUazlnby87WBFqgeTl0774
HhiB352idWW02TLWmgMGHBjlGuS/w5fr+XC9JiJ4D+JzJg2b3X0=
=d7Ch
-----END PGP SIGNATURE-----

--h7AGFP2sAjLPuOv5--