Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1257097rdb; Sun, 7 Jan 2024 10:42:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGqRl+aURbI/hBpWh/Y+eOe7YX1Hh40+E/CsUD0cMVpR/Kj4HwykHFTWcjfECV9jdMooL0X X-Received: by 2002:a05:6808:10c2:b0:3b8:b063:6bb1 with SMTP id s2-20020a05680810c200b003b8b0636bb1mr3810072ois.96.1704652940580; Sun, 07 Jan 2024 10:42:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704652940; cv=none; d=google.com; s=arc-20160816; b=FLWIJdoQcTx7tHRzPy/y05RD8NE53QLIWTaOvnHwqCFDas01iHiO1gg9OSwzfF6RTe i7+8hYMElRMNnePcH6f+FpR+yNsvOwptYFIESbTbLhZHYBJE/ROqAdXFlpsztrDDSdbi mgIfhbwQzW4Z3CqzUgiwhkWyDJVrS/czQR+Id93/mnI9Zv/RPXjwxJTYsrv5laWcDe64 sFGzR5rc0S8NHXbvKFdEqppMtsxSeJXwpGOWcvGZSE8YTerUzPMSdyk3kOVL0oPZRxHr /tQpyRVj8EInWc7ILiCmXhzwlHbB1KPol9BBRVsu1GiP2oIR7xmYrgbn19Fd8FPKpjda I8iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=s0prdEAj89MfCO6uINX9NF3GFv49wanD+YL5iJFREZs=; fh=aJ9xTPZtymM0WggePwHZ7Jde+NNf2w5GyAsTEcDsGwE=; b=Z64IusbrgYtTrkxzCupAqAnviMw8jmXkC+lOZ9oD/qJDHHxom9GWjO05sX5G5Ur/ES bwUkOXnQ70/BSTmQM6FdyQyS6+6CsUsNqWZmgOUl4XyvWUlIDMAXkDO1oR8lkGh4UJww 7HTXG+SFqv8RQUHM7eWRjOihu2AIR1+ufgK0EUaKzZqukdnZGyBOfISlnamgufB6No60 z5++c7vgldy7db9lXeyZ7hovvx1uE4xmnZ1gY7oUUksNOl6d+lPuZkZsYr+xlQ2JTsGT w55CNJOKMdRC9cvHqCxdLRU59mRUtEk+BS40iwT/oGIhcQhHTqT3ixYIe5Y9OShGLPdv 8F0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=bStquiGf; spf=pass (google.com: domain of linux-kernel+bounces-18955-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18955-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id s10-20020a17090a6e4a00b0028ce48902cfsi4259647pjm.151.2024.01.07.10.42.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 10:42:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18955-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=bStquiGf; spf=pass (google.com: domain of linux-kernel+bounces-18955-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18955-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3F202281B3C for ; Sun, 7 Jan 2024 18:42:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F1EE310A39; Sun, 7 Jan 2024 18:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="bStquiGf" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B9CD10A0A for ; Sun, 7 Jan 2024 18:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2ccb4adbffbso11814901fa.0 for ; Sun, 07 Jan 2024 10:42:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1704652929; x=1705257729; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s0prdEAj89MfCO6uINX9NF3GFv49wanD+YL5iJFREZs=; b=bStquiGfXB78TOKeTSMx6QP5PWm5mQgB2XAtLeCaNGkEJMxqJAfakmzbF2iMETpI8S Ga02jpnDeLrhIlGA3lFrFAdDyPLQumYYj2uqYlrLsvnUNc742Xa+PaNw9pbCJ0fjb2Yi up0yAiTAwkCqEJBkFDKLqFwQo2CdrAfyqQ3XU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704652929; x=1705257729; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s0prdEAj89MfCO6uINX9NF3GFv49wanD+YL5iJFREZs=; b=QxE4fiXQxggTBJALidNYmJu8s1CVz/mn+IJIgk1A80dfnlvWUwzpprYNwDZydjLQ1L YI5bubO5u8SZ4lRNzjscIuC03RSJb8KnbNRyrXijxBNmyb7JprnjFkjockbQthb79Vbo 1rN5MGYpxSk3OUIQWml5dO+13+9UP4yneiwEXi5gdJyERKTbrAYPr2ZixVdGUIspWhhm ACyWgTsOOMZDgwI5yEsB/0PYScBV6EgaiFTCkFAu+Obv7NgjQvlPWVtm1ckfHbbFBmGG WHnLG1a4kS0J/GrXn3ezhsE8lPGh+68LoZNRzJZc3j6lVBjVbA+sXeGKoON8K2zqn5mx uHzA== X-Gm-Message-State: AOJu0YzfIWG8ZNUeOsnlrPItiFCuirZEnqYQQgL5bpNECtXHFKexeA5l ucfsGdKVw/p0QIE1E++XyHHScF056MFEOjchMvK+419DXVh3yVsi X-Received: by 2002:a2e:a553:0:b0:2cd:50a7:12d2 with SMTP id e19-20020a2ea553000000b002cd50a712d2mr382671ljn.58.1704652929173; Sun, 07 Jan 2024 10:42:09 -0800 (PST) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id h26-20020a2e901a000000b002cceb7bd648sm1224107ljg.92.2024.01.07.10.42.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jan 2024 10:42:08 -0800 (PST) Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50e7d6565b5so1118925e87.0 for ; Sun, 07 Jan 2024 10:42:07 -0800 (PST) X-Received: by 2002:ac2:548b:0:b0:50e:7dca:7f93 with SMTP id t11-20020ac2548b000000b0050e7dca7f93mr823836lfk.77.1704652927542; Sun, 07 Jan 2024 10:42:07 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240104185138.169307-1-jeffxu@chromium.org> <20240104185138.169307-3-jeffxu@chromium.org> In-Reply-To: <20240104185138.169307-3-jeffxu@chromium.org> From: Linus Torvalds Date: Sun, 7 Jan 2024 10:41:50 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v4 2/4] mseal: add mseal syscall To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, usama.anjum@collabora.com, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Content-Type: text/plain; charset="UTF-8" One comment: On Thu, 4 Jan 2024 at 10:51, wrote: > > diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c > index 9a846439b36a..02280199069b 100644 > --- a/kernel/sys_ni.c > +++ b/kernel/sys_ni.c > @@ -193,6 +193,7 @@ COND_SYSCALL(migrate_pages); > COND_SYSCALL(move_pages); > COND_SYSCALL(set_mempolicy_home_node); > COND_SYSCALL(cachestat); > +COND_SYSCALL(mseal); > > COND_SYSCALL(perf_event_open); > COND_SYSCALL(accept4); Move this part to PATCH 1/1, so that it all builds cleanly. Other than that, this seems all reasonable to me now. Linus