Received-SPF: pass (google.com: domain of linux-kernel+bounces-18963-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 7 Jan 2024 19:17:32 +0000
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Sergio Palumbo <palumbo.ser@outlook.it>
Cc: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]     net: sfp: add quirk for DFP-34X-2C2 GPON ONU SFP
Message-ID: <ZZr4zCzEpuzOoIGQ@shell.armlinux.org.uk>
References: <AS1PR03MB8189FE82C632EBA97644D70082642@AS1PR03MB8189.eurprd03.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AS1PR03MB8189FE82C632EBA97644D70082642@AS1PR03MB8189.eurprd03.prod.outlook.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

On Sun, Jan 07, 2024 at 05:17:57PM +0100, Sergio Palumbo wrote:
>     Add a quirk for a GPON SFP that identifies itself as "OEM"
>     "DFP-34X-2C2". This module's PHY is accessible at 1000base-X,
>     but can also run at 2500base-X as per specs of the module.
>     After application of the quirk the module is enebled to run both
>     at 1000base-X as well as at 2500base-X interface mode.
> 
> Signed-off-by: Sergio Palumbo <palumbo.ser@outlook.it>

There are several issues here:

1. Submitting to netdev needs either [PATCH net] or [PATCH net-next]
   to indicate which tree is being targetted. As this isn't a fix,
   net-next is appropriate, but I would also suggest that it is too
   late in the cycle as v6.7 is due out today.

2. How does the module switch between 1000base-X and 2500base-X?
   What happens if the module wants to use 2500base-X but the host
   doesn't support it? Please include these details in the commit
   message.

3. While I know the Turris Rollball entries are out of order, please
   try to keep the list alphabetically sorted, first by vendor string
   and then part string.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!