Received-SPF: pass (google.com: domain of linux-kernel+bounces-18965-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 7 Jan 2024 18:45:30 +0000 (GMT)
From: Phillip Lougher <phillip@squashfs.org.uk>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Message-ID: <522978349.868758.1704653130312@eu1.myprofessionalmail.com>
In-Reply-To: <49472d26-29e6-443f-b0f5-21967a67dd4a@web.de>
References: <49472d26-29e6-443f-b0f5-21967a67dd4a@web.de>
Subject: Re: [PATCH] squashfs: Improve error handling in
 squashfs_decompressor_create()
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Importance: Normal

> On 30/12/2023 09:55 GMT Markus Elfring <markus.elfring@web.de> wrote:
>=20
> =20
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 29 Dec 2023 21:30:26 +0100
>=20
> The kfree() function was called in two cases by
> the squashfs_decompressor_create() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
>=20
> * Thus return directly after a call of the function =E2=80=9Ckzalloc=E2=
=80=9D failed
>   at the beginning.
>=20
> * Use another label.
>=20
> * Move an error code assignment into an if branch.
>=20
> * Delete an initialisation (for the variable =E2=80=9Cdecomp_strm=E2=80=
=9D)
>   which became unnecessary with this refactoring.
>=20
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

As mentioned in this thread (and many others)

https://lore.kernel.org/all/20240104204032.GN31813@kernel.org/

calling Kfree with a NULL pointer is perfectly valid.

So like most others I'm going to ignore this patch.

Cheers

Phillip