Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757316AbXLLQHg (ORCPT ); Wed, 12 Dec 2007 11:07:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752366AbXLLQH2 (ORCPT ); Wed, 12 Dec 2007 11:07:28 -0500 Received: from mail.suse.de ([195.135.220.2]:58627 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbXLLQH1 (ORCPT ); Wed, 12 Dec 2007 11:07:27 -0500 Date: Wed, 12 Dec 2007 17:07:22 +0100 From: Andi Kleen To: Neil Horman Cc: Andi Kleen , Yinghai Lu , Ben Woodard , Neil Horman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, hbabu@us.ibm.com, Andi Kleen , "Eric W. Biederman" , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com Subject: Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels on boot cpu Message-ID: <20071212160722.GD4889@bingen.suse.de> References: <20071211143910.GA10999@hmsreliant.think-freely.org> <20071211182254.GB10999@hmsreliant.think-freely.org> <20071211192434.GD10999@hmsreliant.think-freely.org> <86802c440712111151t29acd38kf9fac8e41743f3e4@mail.gmail.com> <20071211205955.GF10999@hmsreliant.think-freely.org> <20071212142132.GC4889@bingen.suse.de> <20071212155515.GA29735@hmsendeavour.rdu.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071212155515.GA29735@hmsendeavour.rdu.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1824 Lines: 47 On Wed, Dec 12, 2007 at 10:55:15AM -0500, Neil Horman wrote: > On Wed, Dec 12, 2007 at 03:21:32PM +0100, Andi Kleen wrote: > > > + htcfg = read_pci_config(num, slot, func, 0x68); > > > + if (htcfg & (1 << 18)) { > > > + printk(KERN_INFO "Detected use of extended apic ids on hypertransport bus\n"); > > > + if ((htcfg & (1 << 17)) == 0) { > > > + printk(KERN_INFO "Enabling hypertransport extended apic interrupt broadcast\n"); > > > + printk(KERN_INFO "Note this is a bios bug, please contact your hw vendor\n"); > > > > I'm not convinced the message is correct. e.g. on a system with only a dual core not enabling > > that is fine, but the extended IDs might be still set. > > > I'm not sure that would be fine. In the situation you describe, not setting > this bit means the second core won't receive interrupts. If we crash on that > core and boot the kdump kernel with it, we get exactly the same problem that we > currently see. It could enable the extended APIC IDs but not use them? Anyways I haven't got docs on that NV bridge so I might be wrong. > > > #endif /* CONFIG_ACPI */ > > > > > > -static void __init nvidia_bugs(void) > > > +static void __init nvidia_bugs(int num, int slot, int func) > > > { > > > + static int fix_applied = 0; > > > + > > > + if (fix_applied++) > > > + return; > > > > This looks like the wrong place to do this. Better add a flag or something > > in the structure. Dito others. > > > I suppose I can, but I'm not sure what benefit that provides. Can you > elaborate? The code would be smaller and cleaner. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/