Received-SPF: pass (google.com: domain of linux-kernel+bounces-18989-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sun, 7 Jan 2024 21:26:59 +0000
From: Mark Brown <broonie@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: David Lechner <dlechner@baylibre.com>, linux-iio@vger.kernel.org,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Michael Hennerich <michael.hennerich@analog.com>,
	Nuno =?iso-8859-1?Q?S=E1?= <nuno.sa@analog.com>,
	Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: spi: add spi-rx-bus-channels
 peripheral property
Message-ID: <f431e418-0b7c-4362-be26-9d2f03e0de07@sirena.org.uk>
References: <20231215-ad7380-mainline-v3-0-7a11ebf642b9@baylibre.com>
 <20231215-ad7380-mainline-v3-1-7a11ebf642b9@baylibre.com>
 <20240107164356.3e8df266@jic23-huawei>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Fv0DJ3jRqIS10aZI"
Content-Disposition: inline
In-Reply-To: <20240107164356.3e8df266@jic23-huawei>


--Fv0DJ3jRqIS10aZI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jan 07, 2024 at 04:43:56PM +0000, Jonathan Cameron wrote:
> David Lechner <dlechner@baylibre.com> wrote:

> > This adds a new spi-rx-bus-channels property to the generic spi
> > peripheral property bindings. This property is used to describe
> > devices that have parallel data output channels.

> > This property is different from spi-rx-bus-width in that the latter
> > means that we are reading multiple bits of a single word at one time
> > while the former means that we are reading single bits of multiple words
> > at the same time.

> Mark, could you take a look at this SPI binding change when you have time?

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

> I don't want to apply it without your view on whether this makes sense
> from a general SPI point of view as we all hate maintaining bindings
> if they turn out to not be sufficiently future looking etc and we need
> to deprecate them in favour of something else.

This makes no sense to me without a corresponding change in the SPI core
and possibly controller support, though I guess you could do data
manging to rewrite from a normal parallel SPI to this for a pure
software implementation.  I also see nothing in the driver that even
attempts to parse this so I can't see how it could possibly work.

--Fv0DJ3jRqIS10aZI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWbFyMACgkQJNaLcl1U
h9AzYgf+Mbh0jgcqo96lL6XLC32m37OlYdd9fUKv0+KUOEXnZaUQ7qSCxWmhGgAP
A2b1ghi/zUK7TsqVz8j+942keDay/MqUYOsrRMXpYpgELqWDlkLCh9TN/lpAbXJB
q6dSJ7LnzJPH27JocTjnOFv16EILR/8974m14laHlQ49Rqr4egzfRNDHgfTyOFci
DIsEp7kGIM3Xt1WeQzYlvxpDPeD4pRmlZBO6/zS9w77c4d+UXugNB/s1P/C5YNRK
8l9iTvCtcTjkgFuznUQZIqfYYZYLC00jcpt/MsDCLz+bY4lHQTsoZMuvdpAjMspW
SzABJV2fJNW1ZG1pWTy3YNc54Em1IA==
=jAw8
-----END PGP SIGNATURE-----

--Fv0DJ3jRqIS10aZI--