Received-SPF: pass (google.com: domain of linux-kernel+bounces-19033-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Bart Van Assche'" <bvanassche@acm.org>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <alim.akhtar@samsung.com>,
	<avri.altman@wdc.com>, <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
	<beanhuo@micron.com>, <adrian.hunter@intel.com>, <h10.kim@samsung.com>,
	<hy50.seo@samsung.com>, <sh425.lee@samsung.com>, <kwangwon.min@samsung.com>,
	<junwoo80.lee@samsung.com>, <wkon.kim@samsung.com>
In-Reply-To: <65dead0b-34a5-4e29-83ec-c26e556f262a@acm.org>
Subject: RE: [PATCH v1] ufs: get target SQ entry within critical section
Date: Mon, 8 Jan 2024 09:51:19 +0900
Message-ID: <001501da41cc$cb1fbe80$615f3b80$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQGjKnJSW6mFTQ0gfnvbL4w9CrB5iwLKIUEhAXEayZmxG2puEA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20240104012454epcas2p36b58220b4c89ee72f1e095b34d329be2@epcas2p3.samsung.com>
	<1704331491-115325-1-git-send-email-kwmad.kim@samsung.com>
	<65dead0b-34a5-4e29-83ec-c26e556f262a@acm.org>

> > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> > index 7bc3fc4..da1a9c0 100644
> > --- a/drivers/ufs/core/ufshcd.c
> > +++ b/drivers/ufs/core/ufshcd.c
> > =40=40 -2199,9 +2199,10 =40=40 void ufshcd_send_command(struct ufs_hba =
*hba,
> unsigned int task_tag,
> >   	if (is_mcq_enabled(hba)) =7B
> >   		int utrd_size =3D sizeof(struct utp_transfer_req_desc);
> >   		struct utp_transfer_req_desc *src =3D lrbp->utr_descriptor_ptr;
> > -		struct utp_transfer_req_desc *dest =3D hwq->sqe_base_addr +
> hwq->sq_tail_slot;
> > +		struct utp_transfer_req_desc *dest;
> >
> >   		spin_lock(&hwq->sq_lock);
> > +		dest =3D hwq->sqe_base_addr + hwq->sq_tail_slot;
> >   		memcpy(dest, src, utrd_size);
> >   		ufshcd_inc_sq_tail(hwq);
> >   		spin_unlock(&hwq->sq_lock);
>=20
> Is this perhaps a duplicate of patch =22scsi: ufs: core: Let the sq_lock
> protect sq_tail_slot access=22? See also https://lore.kernel.org/linux-
> scsi/1702913550-20631-1-git-send-email-quic_cang=40quicinc.com/=23t

I didn=E2=80=99t=20see=20it.=20Thank=20you=20for=20letting=20me=20know.=0D=
=0A=0D=0A=0D=0A