Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1413584rdb; Sun, 7 Jan 2024 19:47:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlrEBQ414Ml6vAxaP7XEJBV9mdUKOzAGCvKyhXmiU+iVtMG7gnzhC4sdy3dl3E8p8Pe6tV X-Received: by 2002:a05:6358:7f0e:b0:175:620b:3178 with SMTP id p14-20020a0563587f0e00b00175620b3178mr3516005rwn.34.1704685631214; Sun, 07 Jan 2024 19:47:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704685631; cv=none; d=google.com; s=arc-20160816; b=otBWJR1w2NoV5cePJiz1DnjQ29PgEkT0Q9KCY5XUUDXJHgVmjeUFFpgTxgsXApdGiK YnnU31AfcBCPHKSydIXBO4zfPfdoDAvDKct2duZAgQReZkc2JKYSayOmi55+UJ1Pt89a czQtyBGxASL9kB3iETUUCIcVOJqnXTB2vMOxbogeJ+DhzYE9tcjtZXkkxmvXCPA6bTCX sLo6QK1QGvLaScGtA06k8lelbq7RqB07WGenJWAYF7JLM5s26YehoJgjvUZUP7WQTbDs v8mcEpYmMDlJz5oOEhEVsmvSCK4ZAOH3cf1WXrvqTgQAXX1Zgl1eq0M2lp6YJT8D5b7e LKAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Xb0u7S94W+FH92L7fSkSwAIe1EHoAr/NxL2DTwrFwD8=; fh=uxctrWgoO6uREvjBtS7m4gjAWmNP/jMIKuiM6myZhkY=; b=RCJP0zmXGQ1L4aUq91XyQtVkRcy4RFOCkYsJT/WtU3nkEZrGZSonrxPVP10XhJx3wV t7K75u8gRvgv5zoZU3CstI/KIf6WmD9/m71LWnBfmjHTiqnMNRMC2/HYVcM6zxTYXZZF +InkklKOIVLUetrLDPBX8bNoUSZlu4HIpNHJVcGktXzD9zhcqHbU5CIq3EZbW06zuy1M pmhjOKfXI9HX11SnjsW1PyzKXs19IiGt34oTO7A3cKVYxcOs9rDe6Z+FYOqJxpgkjg3o Qw6MgYGrrP7c10QpllVRmpd6QnZV/bf2+OtVz40EInhwtaZA6pgddnVi5E9YZtgxHHun DQJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lCVm+XqQ; spf=pass (google.com: domain of linux-kernel+bounces-19073-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19073-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id p1-20020a056a000a0100b006daeef3d235si1751531pfh.64.2024.01.07.19.47.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 19:47:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19073-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lCVm+XqQ; spf=pass (google.com: domain of linux-kernel+bounces-19073-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19073-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 1E435B2117C for ; Mon, 8 Jan 2024 03:47:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 313FF4687; Mon, 8 Jan 2024 03:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lCVm+XqQ" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29D227465; Mon, 8 Jan 2024 03:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-5981e5d4e7cso1004386eaf.0; Sun, 07 Jan 2024 19:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704685615; x=1705290415; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xb0u7S94W+FH92L7fSkSwAIe1EHoAr/NxL2DTwrFwD8=; b=lCVm+XqQoxA9Hz8EcRMckC5gfhifPKAPeDYSICaefaSpu5BR1s3tm/iT7M6+QI7gjG PbMEglctHr3cVhWz1mKt/4oQqOIZM12Mr8m99I6Q6+g8sBifizD9ofRcvU7xVpk5NV8M BKYkNoAgyCiz6NxG+pHuW8JR2iusA0pBdP9oALSdEqs1mgdL/obHStTggHzo8zdDcseh tZ78BHce3AIRckolk7MqWkJdePGDRFEdpwVHQKR2USxpF29CJTU3Ob6bto8opFCNhWGw g3HRhDKFaTKhEcHmadhda6vADs8VzwOEo2MOy60lrDslqHeOfEGz0EN0b239efoIzmBm KX5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704685615; x=1705290415; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xb0u7S94W+FH92L7fSkSwAIe1EHoAr/NxL2DTwrFwD8=; b=O8s8Opu7BhL36GEHc7iKhH7yQJKcWGdUlXBF4fwZZhN6wSL0AYsFdzTAUlRm1cQZWZ DiOJg/4cniDz8kms2rPkDRGRW6NPhRNBfkcZI+wHLt2tWQ0Sjkmqwk6YlYPXRCoXKsaX c6xa373OOj2R6usSSQrKmRrIxxqyG/0WuhCokHwc/tZreP2CgQWNeolxwiPVHLMC5IPZ kbyfMBn0znkJI3sNLBeV5u7j1zovh2CA6gE+1hWKNi2QNCb3hcXqNxWe+LbVLpAg1qhp p9F7w0ifQoMrKeABWzd75cIXqQ8WBSHvuv+HIn6JBy55Nn012dRhHjg65D1m4uY7LEXG RFpQ== X-Gm-Message-State: AOJu0Yx82N79pu8gy602klFco1F0Vr5jy9AKxO+5P129ecC/TKuRip+S +tZXPqLkVcTDkK54V66Dq8I= X-Received: by 2002:a05:6358:a083:b0:175:9796:1f9b with SMTP id u3-20020a056358a08300b0017597961f9bmr201068rwn.28.1704685614968; Sun, 07 Jan 2024 19:46:54 -0800 (PST) Received: from Laptop-X1 ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id fk3-20020a056a003a8300b006d92f081d9fsm4963717pfb.31.2024.01.07.19.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 19:46:54 -0800 (PST) Date: Mon, 8 Jan 2024 11:46:48 +0800 From: Hangbin Liu To: Jay Vosburgh Cc: Aahil Awatramani , David Dillow , Mahesh Bandewar , Andy Gospodarek , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Martin KaFai Lau , Herbert Xu , Daniel Borkmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2 net-next v2] bonding: Extending LACP MUX State Machine to include a Collecting State. Message-ID: References: <20240105000632.2484182-1-aahila@google.com> <11317.1704418732@famine> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11317.1704418732@famine> On Thu, Jan 04, 2024 at 05:38:52PM -0800, Jay Vosburgh wrote: > >+coupled_control > >+ > >+ Specifies whether the LACP state machine's MUX in the 802.3ad mode > >+ should have separate Collecting and Distributing states. > >+ > >+ The default value is 1. This setting does not separate the Collecting > >+ and Distributing states, maintaining the bond in coupled control. > >+ > > Please reference the standard in the description; this is > implementing the independent control state machine per IEEE 802.1AX-2008 > 5.4.15 in addition to the existing coupled control state machine. The status of IEEE 802.1AX-2008[1] is "Superseded Standard". Maybe we should use IEEE 802.1AX-2020[2]. [1] https://standards.ieee.org/ieee/802.1AX/4176/ [2] https://standards.ieee.org/ieee/802.1AX/6768/ Thanks Hangbin