Received-SPF: pass (google.com: domain of linux-kernel+bounces-19118-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <70448afd-cb53-478c-83fc-831c712e9a82@shopee.com>
Date: Mon, 8 Jan 2024 14:49:31 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] mm: list_lru: disable memcg_aware when cgroup.memory
 is set to "nokmem"
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org,
 shakeelb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20231228062715.338672-1-haifeng.xu@shopee.com>
 <ZZS-IFA6TScotocU@P9FQF9L96D>
From: Haifeng Xu <haifeng.xu@shopee.com>
In-Reply-To: <ZZS-IFA6TScotocU@P9FQF9L96D>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2024/1/3 09:53, Roman Gushchin wrote:
> On Thu, Dec 28, 2023 at 06:27:14AM +0000, Haifeng Xu wrote:
>> Actually, when using a boot time kernel option "cgroup.memory=nokmem",
>> all lru items are inserted to list_lru_node. But for those users who
>> invoke list_lru_init_memcg() to initialize list_lru, list_lru_memcg_aware()
>> returns true. And this brings unneeded operations related to memcg.
>>
>> To make things more convenient, let's disable memcg_aware when
>> cgroup.memory is set to "nokmem".
> 
> I guess it's not only more convenient, but also should save a bit of memory.
> But _probably_ not enough to justify messing up with stable backports.
> Do you have any data on memory savings?

Do you mean that it will remove the allocation of 'list_lru_memcg' in memcg_init_list_lru_one()?

In fact, even without this patch, if we set cgroup.memory set to "nokmem", all memcg's kmemcg_id is -1, so
memcg_list_lru_allocated() always returns true and we won't invoke memcg_init_list_lru_one().


> 
>>
>> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> 
> Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
> 
> Thanks!