Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1469472rdb; Sun, 7 Jan 2024 23:06:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkpEQ9Ib5ReJ8rhBDgP8lE3//gbr+6b07gK4MH7gQ27QrzHci3CLAkNvWBaEsy3Od1dyAW X-Received: by 2002:a05:6808:1797:b0:3bd:27a9:3f57 with SMTP id bg23-20020a056808179700b003bd27a93f57mr3341596oib.77.1704697579833; Sun, 07 Jan 2024 23:06:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704697579; cv=none; d=google.com; s=arc-20160816; b=BnWYzZpCU2nTT9EQe5828IKMGqmeBWsjibixuFJPzklapEK2mrSXvxpkjGVfUjhUxN vxwLZYm9TAik88atBwLHdk+r0IUZs5LRp4Bd90x9bPHfMTZbP7FgZofscBRblAkvs4tu DW/ioyssujrRs7L0UhjEAvqNs0MvN5YNfsLWXQsDG17Yn8mR3QsDXsfT175wkKqInxiq FajDEafPz6yfvBMgwzYz7FG8TUm0R5k+/UmKWaVGipZf41rJsE+LDbfD3Tfe0lhDfz3H hoWh9/793zECTKSmzsGdzmoYuHZ/3p0xeQjJ/a8MviBniona8vALqThU9Quhf8r9g3pT 2rAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=+W5MR0GZTvvVT7Ez94bP6YWkWN8S36H3wYikt4HSl4Q=; fh=6KFy4QhCcBI+/pqThEy8ytXCCgd97tilmcVLnDWZpv4=; b=B5I1HK5ld/3/MClz/x0ssDkmO1tLJ37fKkjhDwP5GLsRi8oxBT9TcScS8GJLubCVgV VzyDknrvPXlS6BgOu9mbf3a10uk9Bv0o14GajnM86ZemUGlXg51Rq8aOE284cMXGYelH Xryxce3KMkF1nz3B6AdlvM7M7MPdr4PDnLeH49MlakmZibDFOX5u8vvQhojdku7sLCGA sCENPjhTqYZNHmWvf7PNoW5GWhLvu5MLAwZWwf2hOcKNY4ty1/Io0xO8nb8idaVFoltl LIdokO9xajg3FKuS7VrZxvTxVfT4xqqP0WgLf5J18LiM+r1PRclygYG4sFdBzYRTA1dZ vZmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=phI3eXm5; spf=pass (google.com: domain of linux-kernel+bounces-19128-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19128-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id fd17-20020a056a002e9100b006d275095934si5590797pfb.310.2024.01.07.23.06.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 23:06:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19128-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=phI3eXm5; spf=pass (google.com: domain of linux-kernel+bounces-19128-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19128-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BD9EEB20B20 for ; Mon, 8 Jan 2024 07:06:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6E7F8C02; Mon, 8 Jan 2024 07:06:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="phI3eXm5" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62BF4B660 for ; Mon, 8 Jan 2024 07:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-50ea9daac4cso1346551e87.3 for ; Sun, 07 Jan 2024 23:06:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1704697559; x=1705302359; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+W5MR0GZTvvVT7Ez94bP6YWkWN8S36H3wYikt4HSl4Q=; b=phI3eXm59qPP0jQ8DwkFvWbXhXYGoID3/wYE1adMQ60hFPVf6xzqQ+lSTk9whbAidC Kjmx36XSDGf+EE+n2rEIXlOMb/CAOidVvXyLYhhA4w1jMg8853SSEOSk+P+mtgVmk5lw kKldn4woAzVrFPtjQD85wE/VDnrQhV8slyl/ttwnrkqDwh+zzQW+Yti9pUcVsowqnIVr Dmdu0tpwtA+XMQL9syRoUcK7f2tjTB0tfzQmFTIi2Ice1U00oX4IGZURPOZQJ4qYiajn puZzodbWzUYfukddEviLWRv7JXXoP/d52KCLGZsZu7PtF8Mea7GZkRruSrYegAUD2FPd lrKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704697559; x=1705302359; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+W5MR0GZTvvVT7Ez94bP6YWkWN8S36H3wYikt4HSl4Q=; b=FbagQ+VmwJokaEhnjfVjJq00YHiFI8kL5n6kxa2RO6Q5pAYVoU9PJrfB2Ni4xvgFcv UU4z2x0YNiRyFbeNPEJZYjGO44YjMSDHazHpQawuM4O6jk8JmlMVX4wDtlq0Q+Virfr+ KIreyLqC6QRO8fSsScJPKS/n/4Oc2DR0wgqMzrYGGVA7APPNiDJe9zNLc8p+DBBMmWID VBiW0lR7DzeEMDumlQ/AbDhtm7jfjHrmdEMhvXwSTrV+mhYLIiQb2SsbD1ndPpgH7rHU mRDCsbwOKSS6kgoqSPZxyvYZoTgSzD9RgwIYkf0nv4vnFtrUC6aDL1V+lyNfqI+pM4pK aSiQ== X-Gm-Message-State: AOJu0YwZcNwLebzPjPDVcfjbYGKeBKt4JpiBuDJbx4pT92XeKMpbb3cz x2Uysez3M8/SoaV9tOMxmjwlwQ5hZ5NslA== X-Received: by 2002:a05:6512:b23:b0:50e:a942:e6f3 with SMTP id w35-20020a0565120b2300b0050ea942e6f3mr1367517lfu.10.1704697559144; Sun, 07 Jan 2024 23:05:59 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.5]) by smtp.gmail.com with ESMTPSA id ez10-20020a1709070bca00b00a28a7f56dc4sm1063479ejc.188.2024.01.07.23.05.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jan 2024 23:05:58 -0800 (PST) Message-ID: Date: Mon, 8 Jan 2024 09:05:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 03/19] net: ravb: Make reset controller support mandatory Content-Language: en-US To: Geert Uytterhoeven Cc: s.shtylyov@omp.ru, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, p.zabel@pengutronix.de, yoshihiro.shimoda.uh@renesas.com, wsa+renesas@sang-engineering.com, netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, geert+renesas@glider.be, Claudiu Beznea References: <20240105082339.1468817-1-claudiu.beznea.uj@bp.renesas.com> <20240105082339.1468817-4-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, Geert, On 05.01.2024 11:38, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Fri, Jan 5, 2024 at 9:24 AM Claudiu wrote: >> From: Claudiu Beznea >> >> On the RZ/G3S SoC the reset controller is mandatory for the IP to work. >> The device tree binding documentation for the ravb driver specifies that >> the resets are mandatory. Based on this, make the resets mandatory also in >> driver for all ravb devices. >> >> Reviewed-by: Sergey Shtylyov >> Reviewed-by: Geert Uytterhoeven >> Signed-off-by: Claudiu Beznea > >> --- a/drivers/net/ethernet/renesas/ravb_main.c >> +++ b/drivers/net/ethernet/renesas/ravb_main.c >> @@ -2645,7 +2645,7 @@ static int ravb_probe(struct platform_device *pdev) >> return -EINVAL; >> } >> >> - rstc = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); >> + rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); >> if (IS_ERR(rstc)) >> return dev_err_probe(&pdev->dev, PTR_ERR(rstc), >> "failed to get cpg reset\n"); > > Upon second look, you also have to make config RAVB select > RESET_CONTROLLER. > Currently, you can build an R-Car Gen[234] kernel with RESET_CONTROLLER > disabled, causing devm_reset_control_get_exclusive() to fail > unconditionally. ok, I'll update it. Thanks! > > Gr{oetje,eeting}s, > > Geert >