Received-SPF: pass (google.com: domain of linux-kernel+bounces-19138-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Naveen Mamindlapalli <naveenm@marvell.com>
To: Simon Horman <horms@kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
Subject: Re: [net PATCH] octeontx2-af: CN10KB: Fix FIFO length calculation for
 RPM2
Thread-Topic: [net PATCH] octeontx2-af: CN10KB: Fix FIFO length calculation
 for RPM2
Thread-Index: AQHaQgSBmaz7OYYtHkGYAQmVS9FCcw==
Date: Mon, 8 Jan 2024 07:30:08 +0000
Message-ID: 
 <SJ2PR18MB5635D2C1019D1E2B026F9652A26B2@SJ2PR18MB5635.namprd18.prod.outlook.com>
References: <20240105065423.714-1-naveenm@marvell.com>
 <20240105214457.GD31813@kernel.org>
In-Reply-To: <20240105214457.GD31813@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?RSuEQ0/5m+Xz5JgdvFnRWS5r/adWal49S/bOEczi2EWaexs/793mEwzQWvLT?=
 =?us-ascii?Q?D4QzWazafaa5XJH1rgKZ7tT07bkzdlOt4Ib/vYoKlSkTL4kHxO614RXWeAUr?=
 =?us-ascii?Q?PePamAp2kun/M1hpOudznzggHiedyKUXA8dYXlstpytsZLHlnMJgfN4gT8CS?=
 =?us-ascii?Q?XHy8cs+Cl099ZLliVtUXLt2udU2zM51Mp/ydvP0ndviQTZLziOm9dv0Ph7Hp?=
 =?us-ascii?Q?D3Pgmeo6xkFiMud98gUGIn3cZUJXrl+P6VM0IM5HjVDQUnmiHAvid5GUh54z?=
 =?us-ascii?Q?uCzOWWiw2vkihTvYh+FFn7K9T8svvOw08WU6vATW5QcJTo2pcy3hJHahwJR8?=
 =?us-ascii?Q?g1Loj4bNyEVkM9qX1JoQQg6IkZZHj3VO+a1vxXLAQ3bV7zJieTAhYMxDxlAI?=
 =?us-ascii?Q?F6Z06nkN+6QhmrGawq2bBlrAmGdWHAqmWusVtQ3PFSugWiDvf+6gX7V2vOIG?=
 =?us-ascii?Q?87a4a3/v/c4/CfhvHMZaHR8LN1yeHoHEHXNNjMza3DV13C9+r5VDbKFaqlK3?=
 =?us-ascii?Q?JV41E7kEkBxj/wCXoJ9RxmvJKdknGd0fMJze5eS+4Iy0GU1QC5bhoFRTGEZa?=
 =?us-ascii?Q?dUGmTVEzooRxJmMPnOdVd+dMrRl7TsQr20rhnMiri3MoNDIpGSkVP6woWmtw?=
 =?us-ascii?Q?7LOWmK1K+QXIWAQSWo2dQ+F+bmtB4AoeVJK/VDVVtWs00nA350aNaWU7QWDy?=
 =?us-ascii?Q?Ig4y84CuFecNolaeUBKD7iBdUhQwZTdVIpgHfsbWqMSrc0bsIgATSDaWv523?=
 =?us-ascii?Q?PBT9J0/M/Zcu5CGk+bPF3e4X9BInWMs3kowbNAeVIN3ePrBWx2XV89rzFgz0?=
 =?us-ascii?Q?4Iix07eQu8YqmM9jKB34xy8uDGXh++W/4dNCrj+iyGtFHPQHHmc7XPuq3YQh?=
 =?us-ascii?Q?OqW2k4su5ANyNm5yY6tBCg5oC3jdsCLE0i6HBpFX38d19bgXutC7cnGgAgbn?=
 =?us-ascii?Q?zqjWW75YCpdxnvJz5fnQwFx1O6+LGhgqYAu8HTpZjFZ2jfz5qgNLug+wkMSd?=
 =?us-ascii?Q?O1BLwLdWEInk3L/pnTxOf+gQzvtRjkBcx+ewlMhGJglP/1M4uMARolQ+lMdK?=
 =?us-ascii?Q?6PG6MiWoFGh0upymt1h23Iy/avFPNXVc0PDMPLWy9r9ikuXk62ZzrTOUrOx2?=
 =?us-ascii?Q?IZz45ws6m0oCSH/ve8doqSKUUx/8blceGRl0yA25gswZuFn0mH6vQ8hW+x2I?=
 =?us-ascii?Q?j2QFsmQSVSNqJdY5lX5uBocKH+m1geSq82jxCV+bI0V9nFNBRMLGCNGPxTDz?=
 =?us-ascii?Q?KCmDLYk7r1FjqP4oOi4SbOrioAzs024yrWlqXZa3GMgK/MdVvyqEF2GZca48?=
 =?us-ascii?Q?yqdgoQp1oNfldB5xP9Fy26nGRuy2GdZ3WOLoOeWfMwxv8XKUyo/+tGrPLcCt?=
 =?us-ascii?Q?ez+sHt92VYQxWrMRQ7GJ5tUXMes5AqVRqjdADTuKbrhY6XsHdvlyZwsByzwM?=
 =?us-ascii?Q?tfNLvihGxB4KVNubPtHBgNssp/Z2BT8znSa81Ujr2kg2JlEmTRZV1nW9ppIu?=
 =?us-ascii?Q?DcpO1F9YE6+qyLXSAHVzAgR4fxUYHGq7JS0NP+VKoezrukTSw3x92XX4YiXO?=
 =?us-ascii?Q?baeKaY5p+qz2g+6HMBI1PbXElgY/BTmYMzc0Ypiv?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR18MB5635.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 908e6b3e-fb1e-4527-82d6-08dc101ba463
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 07:30:08.7460
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XpbqC6xi1YhJKdRkFM2VwYj6Iqiv+9VptP6lcAl3l61xo85mCMEqXVXkJY+6rruyLBbfPNuf2ZphvXJOcmhPOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3538
X-Proofpoint-ORIG-GUID: _4j9QlILxxkV6ErDalG-PKuFRxsjDQvA
X-Proofpoint-GUID: _4j9QlILxxkV6ErDalG-PKuFRxsjDQvA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02

Hi,

> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Saturday, January 6, 2024 3:15 AM
> To: Naveen Mamindlapalli <naveenm@marvell.com>
> Cc: davem@davemloft.net; kuba@kernel.org; edumazet@google.com;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> Sunil Kovvuri Goutham <sgoutham@marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram@marvell.com>
> Subject: Re: [net PATCH] octeontx2-af: CN10KB: Fix FIFO length
> calculation for RPM2
>=20
> ----------------------------------------------------------------------
> On Fri, Jan 05, 2024 at 12:24:23PM +0530, Naveen Mamindlapalli wrote:
> > From: Nithin Dabilpuram <ndabilpuram@marvell.com>
> >
> > RPM0 and RPM1 on the CN10KB SoC have 8 LMACs each, whereas RPM2 has
> > only 4 LMACs. Similarly, the RPM0 and RPM1 have 256KB FIFO, whereas
> > RPM2 has 128KB FIFO. This patch fixes an issue with improper TX credit
> > programming for the RPM2 link.
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
>=20
> If this is a fix for a user-visible bug then it should have a Fixes tag. =
Else it should
> be targeted at net-next.

Sorry, I missed it. I'll include a fixes tag and send v2 patch.

>=20
> Also, as a potential follow-up, it looks like this file (driver?) could b=
enefit from use
> of GETMASK/FIELD_GET/FIELD_PREP.
> But, IMHO, there is no need to do that for this change which is in a styl=
e
> consistent with the rest of the file.

Sure, noted.

Thanks,
Naveen

>=20
> > ---
> >  drivers/net/ethernet/marvell/octeontx2/af/rpm.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rpm.c
> > b/drivers/net/ethernet/marvell/octeontx2/af/rpm.c
> > index 4728ba34b0e3..76218f1cb459 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rpm.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rpm.c
> > @@ -506,6 +506,7 @@ u32 rpm2_get_lmac_fifo_len(void *rpmd, int lmac_id)
> >  	rpm_t *rpm =3D rpmd;
> >  	u8 num_lmacs;
> >  	u32 fifo_len;
> > +	u16 max_lmac;
> >
> >  	lmac_info =3D rpm_read(rpm, 0, RPM2_CMRX_RX_LMACS);
> >  	/* LMACs are divided into two groups and each group @@ -513,7
> > +514,11 @@ u32 rpm2_get_lmac_fifo_len(void *rpmd, int lmac_id)
> >  	 * Group0 lmac_id range {0..3}
> >  	 * Group1 lmac_id range {4..7}
> >  	 */
> > -	fifo_len =3D rpm->mac_ops->fifo_len / 2;
> > +	max_lmac =3D (rpm_read(rpm, 0, CGX_CONST) >> 24) & 0xFF;
> > +	if (max_lmac > 4)
> > +		fifo_len =3D rpm->mac_ops->fifo_len / 2;
> > +	else
> > +		fifo_len =3D rpm->mac_ops->fifo_len;
> >
> >  	if (lmac_id < 4) {
> >  		num_lmacs =3D hweight8(lmac_info & 0xF);
> > --
> > 2.39.0.198.ga38d39a4c5
> >