Received-SPF: pass (google.com: domain of linux-kernel+bounces-19189-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240107203258.37e26d2b@gandalf.local.home>
In-Reply-To: <20240107203258.37e26d2b@gandalf.local.home>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Mon, 8 Jan 2024 10:32:14 +0200
Message-ID: <CAHp75VcsV8t2-6GB24Rz003B2JSAEOBjWD7B7FjEXuCQhkJ5pQ@mail.gmail.com>
Subject: Re: [PATCH] tracing histograms: Simplify parse_actions() function
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, 
	Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>, 
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Andy Shevchenko <andy@kernel.org>, 
	Tom Zanussi <zanussi@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 8, 2024 at 3:31=E2=80=AFAM Steven Rostedt <rostedt@goodmis.org>=
 wrote:
>
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> The parse_actions() function uses 'len =3D str_has_prefix()' to test whic=
h
> action is in the string being parsed. But then it goes and repeats the
> logic for each different action. This logic can be simplified and
> duplicate code can be removed as 'len' contains the length of the found
> prefix which should be used for all actions.

> Link: https://lore.kernel.org/all/20240107112044.6702cb66@gandalf.local.h=
ome/
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

If you want Link to be formally a tag, you should drop the following
blank line.


> +               if ((len =3D str_has_prefix(str, "onmatch(")))
> +                       hid =3D HANDLER_ONMATCH;
> +               else if ((len =3D str_has_prefix(str, "onmax(")))
> +                       hid =3D HANDLER_ONMAX;
> +               else if ((len =3D str_has_prefix(str, "onchange(")))
> +                       hid =3D HANDLER_ONCHANGE;

The repeating check for ( might be moved out as well after this like

  if (str[len] !=3D '(') {
    // not sure if you need data to be assigned here as well
    ret =3D -EINVAL;
    ...
  }

--=20
With Best Regards,
Andy Shevchenko