Received-SPF: pass (google.com: domain of linux-kernel+bounces-19217-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <a618fb58-fdcc-41b3-a3fa-72025477a481@kontron.de>
Date: Mon, 8 Jan 2024 09:54:14 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 00/14] arm64: dts: imx8mm-kontron: DT updates
From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Shawn Guo <shawnguo@kernel.org>, Frieder Schrempf <frieder@fris.de>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 Sascha Hauer <s.hauer@pengutronix.de>,
 Alexander Stein <alexander.stein@ew.tq-group.com>,
 Fabio Estevam <festevam@gmail.com>,
 Gregor Herburger <gregor.herburger@ew.tq-group.com>,
 Krzysztof Kozlowski <krzk@kernel.org>,
 Marcel Ziswiler <marcel.ziswiler@toradex.com>, Marek Vasut <marex@denx.de>,
 NXP Linux Team <linux-imx@nxp.com>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Philippe Schenker <philippe.schenker@toradex.com>,
 Tim Harvey <tharvey@gateworks.com>
References: <20231206144201.46911-1-frieder@fris.de>
 <20231213093134.GN270430@dragon>
 <5bdfefe3-238a-48d3-b8a4-cee4fb6b0951@kontron.de>
Content-Language: en-US, de-DE
In-Reply-To: <5bdfefe3-238a-48d3-b8a4-cee4fb6b0951@kontron.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YkhlVXl1RS9pTmQvSysrRTBIaktmNmw0bUNML3lXYnZHeWQ0TGt0Tm5jeDE0?=
 =?utf-8?B?M1k5bDRzeHQ0Ym9aNTRGUU44OWxKeWxtQ1QxN1pvU2p1S2FvSVA2Zi9aVjBz?=
 =?utf-8?B?THovRWYzNE1VTk5Hb1RjclpHUGFlbGxURFA1b2FlUDh1ejJCQmNTSVlwWDZn?=
 =?utf-8?B?cVgzV0plVWpqZllxczhIYXI4TTNndmV3WlZJeFI2Sm1vVGpIcFVna1F0RVM5?=
 =?utf-8?B?UXRtRlhBSE5vNHZTRlFQbmJKYXl6Z3prZjMwV3hPa0IyNnVmZ1AwV0RkT0U3?=
 =?utf-8?B?d2M1MDgxQ2o0UzlYLzh6TXZvS0hqVWFmMGpPdDA0THBjV3NjTUlxbTVWaVZk?=
 =?utf-8?B?L25mZWVuZXVzUytGVG9FOUliRXZ1blVyMmN3Wkg2aUdSZUc3akppQnQwOGVV?=
 =?utf-8?B?YVJyeUJ5NmZISFR1SFdOdmxxSWRLOUhVYnNQckxOSXIxUmN6Zzd2RzMyVkg5?=
 =?utf-8?B?RWxMZzZUTzFLN2hJc0dJc0twWDFZNUpPNmkrcFIvNW4vZmFWZUxiQ2gwRGtM?=
 =?utf-8?B?VFpSSGR2LzNrR0U3RUFpejdYczk3eFlNLzdFdXJFaWpuVkVqelAyb1F6M0NH?=
 =?utf-8?B?R0IrWjNvUjlRQ2dqNXl3UUxCak1wRUdBV09qR3RKVzZNaGhlWXpJcVJIR3lE?=
 =?utf-8?B?cHZRRklraEY5NElBN3RCd05HNVZ2OXhxZ0x2K0RKNGNmVlpoNlkvQzJuREJr?=
 =?utf-8?B?amxvNis2TFVrV1k2em52SUFIMG5rMVhrSDM1cVdaMUs4Z0tYVUc4U2VLa1pI?=
 =?utf-8?B?UXdac0lDeXhIQmMwOGF3cU5uZWVjOGFjVE5pc2ltdStrZGdWUXhEZXF0bHQ4?=
 =?utf-8?B?alRWdWUzWXZlTC9lbHpsQktodjNkaDlrVHBrZTV5a3NMd0ZhS1FDTU4rcS93?=
 =?utf-8?B?ck1KT2IvUVozTWtFU2d1QU9sL0ZkdmdHTy9sVDlyTUtHc3p5c2w2T3VIQ0Y0?=
 =?utf-8?B?czdHb3Q1dDA0RTZEYy83WWtkZktaaDJQSmtzdFVnYUR3cldwR2lSZzdLWk4v?=
 =?utf-8?B?elRxV21IbURLS0dsNzNnL2N4QkJQbmtMRkZ0Tkoydk5UcjkvUmdvTDNJMTly?=
 =?utf-8?B?ZWpIUnc5VWFDVzlIVzJUZDFhZTBCUmJYUUNla3NuczUwZUY2UkxwTjhlbDBi?=
 =?utf-8?B?RXhlMG03Q2FXQUlvZ2VtKzQ4ZU9ReXVJSkx3U1pTOXBhNTQ4Ukl4anZ6RVpy?=
 =?utf-8?B?VEZCOGZYbUIxTHhEZkNTS0d4OEQrV2lFZ3lIaGF3NkFMekdPZDA4QXNFSHNB?=
 =?utf-8?B?eWwxbkhaUDBmWmdINks0dG1LZXg4SzhtTjlDTTNzTEZnZWRKUURVdTBYL1Qr?=
 =?utf-8?B?RElkWkszdWRBb21ubDd4di9xWG1KQ1VOVEhySmpGeVppMDZsaU8wV1VWVHEz?=
 =?utf-8?B?OFJJZXBTN3pNSmZuY2dXb1R1UjVESlVsWm9ZeHpQSmhFWEVZekZOTHk4YVpC?=
 =?utf-8?B?TTJrV1JmZG55cVdGdXluVUw2a0lnTFgwNGNjMjNUWHg5NlpoNW84bnJSUnVm?=
 =?utf-8?B?Z3ByU05sZWZZTW1VLzB1cmU2dE9SdUd2RGV4c1c4WERTcXFHdXgybjZFeFYr?=
 =?utf-8?B?SmtXbjNzR1g0K3pqMEQxc2s0TktQUUJDZy9ta2xUNFpsbFdFdU9uV1UvbDAz?=
 =?utf-8?B?LzE0YnFQak1FTll3VENURGZ1NklEYno4b1NlSXhkSnZwN1lQMWcvVURQeU1n?=
 =?utf-8?B?dHhHT0xkRTNacmk0QVJENURVRlpmTVN6Q2FwQUNNQWRCNGR3K25tUFVWeGo5?=
 =?utf-8?B?b251UHhLZEtzcWdKVndOQitLSU5mSmFNNXNqR2Zmc2s5bXdNdmlqUDlRQUJj?=
 =?utf-8?B?U0djKzRic1BrTUVhaUZDdndWd3l1bnBGOWNTQ3YvdG5DWkxiSnhDbHJkT2ov?=
 =?utf-8?B?ZWNOUVNIRENQVWM0Nno4emZZMUI2Y1FCUVp1OG1QRjA2RmdkdTNRL1V5QWtw?=
 =?utf-8?B?ZHRna0d6RnZJLzN2R3JxOVZsNVpEbGRXOU9VelJ1eE9aaDhtNEF4QnNjMGNw?=
 =?utf-8?B?WmRpd0tDZzdIaUR4dS9uRlRhYVhQOCtwT0RvTklMSTVSQXNhQnowWGpuMThP?=
 =?utf-8?B?WGRZM3F4V0FDUGpMSnBWdjZIQU9uS1VQVFFpd3JHRzNUZitHajZQWVF1OFJh?=
 =?utf-8?B?ZlZvRFNDMG1XMTliZSsvVnNtS1hVU2ZDWmZyYjYxN3FyY3c5K3lRM2RwQUM3?=
 =?utf-8?B?THc9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: f3b02fb9-1fee-4fb4-0020-08dc10276472
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 08:54:15.6316
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V7TH3nwTgedl9ZqXWl+FP23aYpVY87d+//NR6vfPK41snbF2ko0ODev9i8JUji7zq9Dq8XyCTn6+awAP6eIBwWioXC5nHUfsJD9X8aGDnBs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3498

On 19.12.23 16:14, Frieder Schrempf wrote:
> On 13.12.23 10:31, Shawn Guo wrote:
>> On Wed, Dec 06, 2023 at 03:41:03PM +0100, Frieder Schrempf wrote:
>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>> ...
>>>  arch/arm64/boot/dts/freescale/Makefile        |   4 +
>>>  .../dts/freescale/imx8mm-kontron-bl-osm-s.dts | 295 +++------
>>>  .../boot/dts/freescale/imx8mm-kontron-bl.dts  | 198 +++++-
>>>  .../boot/dts/freescale/imx8mm-kontron-dl.dtso | 201 +++++++
>>>  .../dts/freescale/imx8mm-kontron-osm-s.dtsi   | 567 +++++++++++++++++-
>>>  .../boot/dts/freescale/imx8mm-kontron-sl.dtsi |   4 +-
>>>  6 files changed, 1035 insertions(+), 234 deletions(-)
>>>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso
>>
>> A couple of things:
>>
>> - I have to use 'git am -3' apply some of the patches.  Could you rebase
>>   the series on imx/dt64 branch?
> 
> Ok, sure!
> 
>>
>> - There are a few DTC warnings that need to be addressed.
>>
>> ../arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts:235.34-238.7: Warning (graph_endpoint): /soc@0/bus@30800000/i2c@30a40000/bridge@2c/ports/port@0/endpoint: graph connection to node '/soc@0/bus@32c00000/dsi@32e10000/ports/port@1/endpoint' is not bidirectional
> 
> I'm not aware of a proper solution for this warning. The thing is that
> there is a DSI switch on the board that is able to route the DSI output
> of the SoC to one of two bridges (HDMI or LVDS).
> 
> On the driver side there is no representation of the switch. Therefore
> the result is a three-way connection for the graph ports which is
> reported by the binding check, but works fine as we only enable one of
> the target port nodes at a time and use GPIO hogs to select the switch path.
> 
> Rob, Krzystztof: Would it be acceptable to ignore this until there is a
> way to represent this in the DT? Are there alternative solutions? Is
> there anything to model a graph link switch?
> 
>> arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtbo: Warning (graph_port): /fragment@3: graph port node name should be 'port'
>> ../arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso:61.17-63.3: Warning (graph_endpoint): /fragment@3/__overlay__: graph endpoint node name should be 'endpoint'
> 
> For these warnings it seems like I could work around them by creating
> two separate port nodes in the board DT and then only enable the proper
> one in the overlay.

Until I find out how to deal with the DTC warnings above, I sent a v4
without the display support patches to unblock the merging of the other
patches.