Received-SPF: pass (google.com: domain of linux-kernel+bounces-19247-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <83fe7beb-de1a-4c71-a584-f3d205249d9d@collabora.com>
Date: Mon, 8 Jan 2024 10:09:21 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] media: cadence: csi2rx: Add enum_mbus_code pad ops
Content-Language: en-US
To: Changhuang Liang <changhuang.liang@starfivetech.com>,
 Maxime Ripard <mripard@kernel.org>,
 Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Jack Zhu <jack.zhu@starfivetech.com>, linux-media@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20231211094329.9090-1-changhuang.liang@starfivetech.com>
From: Julien Massot <julien.massot@collabora.com>
In-Reply-To: <20231211094329.9090-1-changhuang.liang@starfivetech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 12/11/23 10:43, Changhuang Liang wrote:
> Add enum_mbus_code ioctl so that user space can know what
> formats are supported to csi2rx.
> 
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>

Reviewed-by: Julien Massot <julien.massot@collabora.com>
Tested-by: Julien Massot <julien.massot@collabora.com>

> ---
>   drivers/media/platform/cadence/cdns-csi2rx.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c
> index 889f4fbbafb3..7788ce0e3171 100644
> --- a/drivers/media/platform/cadence/cdns-csi2rx.c
> +++ b/drivers/media/platform/cadence/cdns-csi2rx.c
> @@ -389,6 +389,18 @@ static int csi2rx_s_stream(struct v4l2_subdev *subdev, int enable)
>   	return ret;
>   }
>   
> +static int csi2rx_enum_mbus_code(struct v4l2_subdev *subdev,
> +				 struct v4l2_subdev_state *state,
> +				 struct v4l2_subdev_mbus_code_enum *code_enum)
> +{
> +	if (code_enum->index >= ARRAY_SIZE(formats))
> +		return -EINVAL;
> +
> +	code_enum->code = formats[code_enum->index].code;
> +
> +	return 0;
> +}
> +
>   static int csi2rx_set_fmt(struct v4l2_subdev *subdev,
>   			  struct v4l2_subdev_state *state,
>   			  struct v4l2_subdev_format *format)
> @@ -439,6 +451,7 @@ static int csi2rx_init_cfg(struct v4l2_subdev *subdev,
>   }
>   
>   static const struct v4l2_subdev_pad_ops csi2rx_pad_ops = {
> +	.enum_mbus_code	= csi2rx_enum_mbus_code,
>   	.get_fmt	= v4l2_subdev_get_fmt,
>   	.set_fmt	= csi2rx_set_fmt,
>   	.init_cfg	= csi2rx_init_cfg,

Regards,
--
Julien Massot