Received-SPF: pass (google.com: domain of linux-kernel+bounces-19290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Shinas Rasheed <srasheed@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Haseeb Gani
	<hgani@marvell.com>, Vimlesh Kumar <vimleshk@marvell.com>,
        Sathesh B Edara
	<sedara@marvell.com>,
        "egallen@redhat.com" <egallen@redhat.com>,
        "mschmidt@redhat.com" <mschmidt@redhat.com>,
        "pabeni@redhat.com"
	<pabeni@redhat.com>,
        "horms@kernel.org" <horms@kernel.org>,
        "wizhao@redhat.com" <wizhao@redhat.com>,
        "kheib@redhat.com"
	<kheib@redhat.com>,
        "konguyen@redhat.com" <konguyen@redhat.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Satananda Burla
	<sburla@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet
	<edumazet@google.com>
Subject: RE: [EXT] Re: [PATCH net-next v3 7/8] octeon_ep_vf: add ethtool
 support
Thread-Topic: [EXT] Re: [PATCH net-next v3 7/8] octeon_ep_vf: add ethtool
 support
Thread-Index: AQHaQBdBShrkdjKYx0aaWpM69n+DqLDMId6AgAOLKyA=
Date: Mon, 8 Jan 2024 09:40:07 +0000
Message-ID: 
 <PH0PR18MB4734F1FC933FC4E4BAB06934C76B2@PH0PR18MB4734.namprd18.prod.outlook.com>
References: <20240105203823.2953604-1-srasheed@marvell.com>
	<20240105203823.2953604-8-srasheed@marvell.com>
 <20240105193251.028e8eb5@kernel.org>
In-Reply-To: <20240105193251.028e8eb5@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?f5h0Qn/iYK2HKt2XqTy/QxzOWvV4f4hQy8sbVuCPKY6XA5qWEG8DQR0zuXVW?=
 =?us-ascii?Q?rysgl8jLSVHGfzrzgVmxHYUOfBYsJKSsXNXC42+DzbLd8N6hYsraCJM6mnai?=
 =?us-ascii?Q?Xq12PTns4BxxaqnAesSzP1BR4ZbCSY9Zre0l3waBX3uCP7Upx/DvSLIyPjug?=
 =?us-ascii?Q?CIKFzvE+/yVMkVvUnK0+YMa82nViCqDvs8Q/yuUKoISh4S11bBogPrZaOonj?=
 =?us-ascii?Q?sAV4wcGR5VqC+V8Tpcq3Eukjl25HhAqllAR0cmnKtdIaTIBZsVd2nyutnlPY?=
 =?us-ascii?Q?vjeuV3PxXbDaPNp5D1AF3vZfE9aSvNBLcFPRTZa73YxiA/07DMnK3OqHB66U?=
 =?us-ascii?Q?shZswSfMOHnIEe/xZn51ch+G7wIE2G12BUEMT3glIiNicJVgZTYbs/5L+6yu?=
 =?us-ascii?Q?0ep5Q7kZ+qnJ2FZGLsFmbVa1DO0nr02fBeYpLWhgVod+igzpVpN+uG8jeGkD?=
 =?us-ascii?Q?kWer6y0IJ0tCcw2K4J+9pQRMXH+xQyVGqHEXTyQHTANbWVDMHtw4KL4SD3Tv?=
 =?us-ascii?Q?EaxY9TzVQIrJDO9In9144xTGKYJBtzMCpuPEArkbcytdWx7pr+XEAJmf6ouI?=
 =?us-ascii?Q?eP+N+4hqi9IeDIA1kmhLMUskEN5Y8TeQ/NrixfZJmJ7S75v9JM7IJ2z7bjK3?=
 =?us-ascii?Q?NVa7G2nsv2BJ/vuGj/NlcgayJlPnpwh8gf8Zt98OaA4K50cySB7piS+TJ/rz?=
 =?us-ascii?Q?i5d8sPfp+ERC3DWvmufmAi5MFaAfSXTwRfvnXP1YLy1059QXPAZV7Q9lJtTl?=
 =?us-ascii?Q?SCj5+a0xIS+uDW0ZKyPyFKzUXwWXWjkhtQeRusvrM3Qr2bBezrATUBVg22HP?=
 =?us-ascii?Q?bFXMGXWr9bUwDUfK9W2NbaEsAZhBzKrWbdKBw/KSrL+lCXrjjO7Db8bJKizH?=
 =?us-ascii?Q?IG/UmKEpdEVg7qDUhe40RhzkxWNczltMN+RmoJkMLwpLVaz9VUoPiECBghSh?=
 =?us-ascii?Q?WhRED8yXJOgY6uBh1iVDqFfWPvdMBu4nLRiuACKc9/BVMfqxnBULDAhdVROA?=
 =?us-ascii?Q?CQkuQj8Of8I6XWJK2HXWTV4aU6SqaA/1qpTE7kaFc4c21J0DCudh2JnWTZP3?=
 =?us-ascii?Q?jhzcjFGhfFTMITr58Gi2rryso4lkW36zcmR9kDdCY5cdUyplPyVJ1fSX8ECq?=
 =?us-ascii?Q?HxYWmgJJAt5o5VIlMcUyXBv9lYfeGfw3Y7j6TERNgZXw6Do2gVwoW2eeTr/B?=
 =?us-ascii?Q?hTEliyxy0eqK2eZA53+Wh1onx3io1AdK1xgIvGa6drwYWKUyXMvBr9wRQ88R?=
 =?us-ascii?Q?bDi/GUquZQpsl0oKQGr1PjY7TuA2I5bihJLLSim+qY/OB3zwNiomvU//ubLo?=
 =?us-ascii?Q?jgCms0fTq/1cu/rOH9Ywq58wbU5v+MNLQO2cYzwud7x4Kt1t4plahpU1uNNn?=
 =?us-ascii?Q?PUqDvTq8ddmuzf+zLjkyPFpSZf/P+FkGdW6u1i2PZSYvsJfcQM4WMpPdee0k?=
 =?us-ascii?Q?qgur9iKUUKAUWjZbp28au4N+LXzZ2ikv4Fz7MZLbJ77BvqTDuzS5xzipvekq?=
 =?us-ascii?Q?me2xbFYFa/gbeYWvQSMe5PkMsdoeBq/7khjpuW9PbHzLirZ7Wh4Yeq2aVzcC?=
 =?us-ascii?Q?k5ZJgbqLx9gkkHLFgkC+9ga6Vpis4tkdFrwSypjm?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4734.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fed9a327-b21b-4516-b0d4-08dc102dcc89
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 09:40:07.0771
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xmyXgYGcFvlJ8pLzynAAdHOo/rFfSU+tfYtmKzFqMUFkKtsdltJIiLdnwy6NQT6nDbqWw/xbvr2T9tZvAmy1BQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB3807
X-Proofpoint-GUID: 2yFOyl6HhOrWc0xuETXCPcb1Q3AH3gOf
X-Proofpoint-ORIG-GUID: 2yFOyl6HhOrWc0xuETXCPcb1Q3AH3gOf
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02

Thanks for your review. Will submit V4 soon

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Saturday, January 6, 2024 9:03 AM
> To: Shinas Rasheed <srasheed@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Haseeb Gani
> <hgani@marvell.com>; Vimlesh Kumar <vimleshk@marvell.com>; Sathesh B
> Edara <sedara@marvell.com>; egallen@redhat.com; mschmidt@redhat.com;
> pabeni@redhat.com; horms@kernel.org; wizhao@redhat.com;
> kheib@redhat.com; konguyen@redhat.com; Veerasenareddy Burru
> <vburru@marvell.com>; Satananda Burla <sburla@marvell.com>; David S.
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>
> Subject: [EXT] Re: [PATCH net-next v3 7/8] octeon_ep_vf: add ethtool supp=
ort
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Fri, 5 Jan 2024 12:38:22 -0800 Shinas Rasheed wrote:
> > +	"rx_dropped",
> > +	"tx_dropped",
>=20
> Please take a close look at rtnl_link_stats64.
> Anything that fits should really go to standard interface stats.
> This will benefit the piles of monitoring SW which gather standard
> stats.
>=20
> > +	"rx_dropped_pkts_fifo_full",
>=20
> This one is probably rx_missed_errors