Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1534761rdb; Mon, 8 Jan 2024 02:14:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKKvU8aJTKosHzGew7ZMmgqGe+DaH0C4VOcCa7Cqk4h7cffKEeXTXkrxpgRmHta3eSod75 X-Received: by 2002:aa7:c603:0:b0:557:32bd:1fcc with SMTP id h3-20020aa7c603000000b0055732bd1fccmr1321470edq.102.1704708883794; Mon, 08 Jan 2024 02:14:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704708883; cv=none; d=google.com; s=arc-20160816; b=glsmSs5yJOlvxDUroNNCAGcFrVgt1IkAcad4tvMbPZ5CtjjqD/THfhvWUaC8uLNVBl tAfOH5qLnjEg5Ye0BREF3fnHhGDH3dhGKSZ1iHxCcu0g4xfLjGcKrnjQutEc63NQODux seqc1lXY3+0B4eBQXoIUMQ2zWUgw3cz7COwjy6PMkp7fHBo3ZolhhPlceW4dbEkneNUG m+DR48syb69anPCNvHYQMzP9yTQ9kWf3iYQJPtf9q2kRyvwvDxY4n1rgV6dpjgtgrv6g 7TtR6atXUAyuUsKneZkI/eFqMYnH0hIRmvnuxWbtGoTV1kUESVKmGxbCD2HhkkSrxSKt bJRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=c/2oaBr4iO/1sWgu4cfhj7Rov+gOamCBkgl3arIn18s=; fh=o3KgMbTE75TlNCtYP8Oh5STao7mLovEDElu2wDoZ4g8=; b=FaR5LgSqkoxQd1qtDPZXWOL2eM3cuV5yRT1bnXxd2y2RCQUdJqKUJdHs9T3zwggNhG yt3abiQy+bAtxcdqimlKNDSrSN/FKmypqwQOT151YP1+Hw8s/3ORo4KFLdIhn9Ch/K6q QwDBgu2Zi0C/YxSdI12DpfVhSRDvQYIenycUuGzARu2J45kPccaj5oAzuZviZnUzHCVG EAtgKsE1AU4Bn7x+jiMno4TFB0zFCB/Qo5dooIoGM5CItAedmzDbxUiHRnRs/8PEPzjt CEIYtkWeHKUV3Q+MeSaOs0Ji9LN+TRIK4Kv1eCzZvFba71rBIxIRPKeWMUf6ucR7BPAh 2yMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=JI2igXEs; spf=pass (google.com: domain of linux-kernel+bounces-19322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19322-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ee8-20020a056402290800b00557de40e982si54153edb.405.2024.01.08.02.14.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 02:14:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=JI2igXEs; spf=pass (google.com: domain of linux-kernel+bounces-19322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19322-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 867BB1F22389 for ; Mon, 8 Jan 2024 10:14:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 53F8813AF0; Mon, 8 Jan 2024 10:14:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="JI2igXEs" X-Original-To: linux-kernel@vger.kernel.org Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 350D413ADD; Mon, 8 Jan 2024 10:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1704708870; bh=+6Hlxr0hsvZweqdmUQQAuzfh3fA7eGxoJr8e5qLrLCI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JI2igXEsshtxlSPnZLcph1flUi93XgLxZl6t8n9XCWGOHtcarxXXrSzMnrIXsmvIl HSkOIMdhcgvFwd2TmLoWkGQE4jzw7Yod7QKq01FUoxa+EqwOvo8Jy+oOmE4gcbXWTd ukZ4oGNxG80HW+ehP/kTxI/9jEVdKpWVz3/IVK/6fwuhY8y781a9OFzv1JqhJHGhUb 9Rc3/EMT0/P4iUKV838AhMBFy9MjWyydR5AMUZ94b1TuQAbhde5iFDVbok6GImtvt7 n72YXbcgM8oJJEnkG6+5tYpI8JM0kFPSb3//0s1Gns2BMRKR3JMlK9UNMH21eADWq5 LnNgHU6Rs26oA== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id AB07C3780625; Mon, 8 Jan 2024 10:14:29 +0000 (UTC) Message-ID: <97a1d977-38ad-48f7-bc10-f3973b635585@collabora.com> Date: Mon, 8 Jan 2024 11:14:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: mediatek: mt8135: Fix an error handling path in clk_mt8135_apmixed_probe() Content-Language: en-US To: Christophe JAILLET , Michael Turquette , Stephen Boyd , Matthias Brugger , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <6cd6af61e5a91598068227f1f68cfcfde1507453.1704615011.git.christophe.jaillet@wanadoo.fr> From: AngeloGioacchino Del Regno In-Reply-To: <6cd6af61e5a91598068227f1f68cfcfde1507453.1704615011.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 07/01/24 09:12, Christophe JAILLET ha scritto: > If an error occurs after mtk_alloc_clk_data(), mtk_free_clk_data() should > be called, as already done in the remove function. > > Fixes: 54b7026f011e ("clk: mediatek: mt8135-apmixedsys: Convert to platform_driver and module") > Signed-off-by: Christophe JAILLET Reviewed-by: AngeloGioacchino Del Regno