Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1534994rdb; Mon, 8 Jan 2024 02:15:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOJ7yYSDl4SjXNA/ro50KSN8KzT+H95u2EzxGVEwFXoo+ieN2h73IgmAd1Ehsb5Udcz3M0 X-Received: by 2002:a17:906:2c44:b0:a29:7fa9:b8b7 with SMTP id f4-20020a1709062c4400b00a297fa9b8b7mr1086860ejh.121.1704708912879; Mon, 08 Jan 2024 02:15:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704708912; cv=none; d=google.com; s=arc-20160816; b=tH7cQFVjz0YnHVrneX2+3cz3LsjYrwL8eSSJyW5S9CnEO5lxXtK9doPjkIEYNezTJP Ox2d2FLf73zi5g6Y6Ca7vNh4reblV0fn2fJoikWa8RWT2+DsG8UXFfYGsReYbeXTi5pb OPsIhy+evh0LiCKOKA2fGZjUisN+nqvrjWS3uCfZuw6P7TyUqdQQ6biazNZXLP+1y3Vc /MwMVsiFLPybmujygVO7iNl77vyR70AiFAEQhRmZgEIdDzxrUBYZSSTKPJSxN3CsU/f6 fNbrh+HQrvtFRTWFOUO0jI4wrw3vqQIqJBdWKruPKtVozt0MeRMQ06xwnpKQ6GzLu4BE 8Tyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=LxWgKhCDAXC6fRntjujECaPHgDRT1c5S9YGojA3+QN4=; fh=o3KgMbTE75TlNCtYP8Oh5STao7mLovEDElu2wDoZ4g8=; b=F5O8Pa5IEVE/1frLEVs0KbERdjwwMfjiaJ6PrKtReooPHzRBKXKG/fq2Yjko2KDfDX s+Rh1/qs07XSGyLBVgITD5ihOg7h6/CKqJ8SKJ1JYPQ4eWMdXs0X9Gm1DPOKVbfv9P4l 6y9wHClFqKSo6kAZ2X5SbHW0/vKwPL1/SNGo7iFEwrWoTxzN2zxnFKxCP0luQ/jKiewi 7wH9CYRTHvFYzZz1DIsQpJ0gs+xZfiAtO7QuGLYAStug258mxA7HzqrZhPIz35HOp90G JG7PmX98tKsdlsrotQL2tLaSKOmBIFMriODUx3dNdO0BGWgM0WBf+tH81pnTCptr8UvR XEgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Uug89SLG; spf=pass (google.com: domain of linux-kernel+bounces-19324-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19324-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id x8-20020a1709064bc800b00a27fb1e91desi3042785ejv.213.2024.01.08.02.15.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 02:15:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19324-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Uug89SLG; spf=pass (google.com: domain of linux-kernel+bounces-19324-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19324-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A00F81F22357 for ; Mon, 8 Jan 2024 10:15:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7A8F614270; Mon, 8 Jan 2024 10:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Uug89SLG" X-Original-To: linux-kernel@vger.kernel.org Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58C7914017; Mon, 8 Jan 2024 10:14:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1704708881; bh=v3YxdNrdSgkWoqnPochuFDi/fDkCFuaCUTCM/mFHb+o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Uug89SLGrs671PvYYyqHZyKC4fITITj8cRDPQbcmt7Lxsr89yS001FrIIsSmsCK7l meZoCx2urIhIUNWtLf8mAKJFvrjYoh5S2xadnIslVpRXZ138MfElyhqaUshgqNqKoH 0w9xHCfDLUprJS9xXI6+lPg+RQssAGmrFWk+ZxyjHmTq56hg10QlyvlO9qY1k/a0YW 4DMX3G4ay5lrfBR1NRvvnqjyUKUZc7CLHLiUIbDbD6GGnbdb9MgVXTLJxzvun9BvuO W2IYrRnP+wFLgCxx4rbJ74mtG/+4xr4jHWItWeJadzP/VtyU2uSYiXdvAbQWRc8BmR 999ufQxTpZrqg== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 169F93780625; Mon, 8 Jan 2024 10:14:41 +0000 (UTC) Message-ID: <5edf0558-7d31-4ccb-9635-dee64b026cbc@collabora.com> Date: Mon, 8 Jan 2024 11:14:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: mediatek: mt7622-apmixedsys: Fix an error handling path in clk_mt8135_apmixed_probe() Content-Language: en-US To: Christophe JAILLET , Michael Turquette , Stephen Boyd , Matthias Brugger , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <2c553c2a5077757e4f7af0bb895acc43881cf62c.1704616152.git.christophe.jaillet@wanadoo.fr> From: AngeloGioacchino Del Regno In-Reply-To: <2c553c2a5077757e4f7af0bb895acc43881cf62c.1704616152.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 07/01/24 09:29, Christophe JAILLET ha scritto: > 'clk_data' is allocated with mtk_devm_alloc_clk_data(). So calling > mtk_free_clk_data() explicitly in the remove function would lead to a > double-free. > > Remove the redundant call. > > Fixes: c50e2ea6507b ("clk: mediatek: mt7622-apmixedsys: Add .remove() callback for module build") > Signed-off-by: Christophe JAILLET Reviewed-by: AngeloGioacchino Del Regno