Received-SPF: pass (google.com: domain of linux-kernel+bounces-19321-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 8 Jan 2024 15:42:29 +0530
From: Jai Luthra <j-luthra@ti.com>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
CC: Maxime Ripard <mripard@kernel.org>,
        Mauro Carvalho Chehab
	<mchehab@kernel.org>,
        Jack Zhu <jack.zhu@starfivetech.com>, <linux-media@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] media: cadence: csi2rx: Add enum_mbus_code pad ops
Message-ID: <ahubawbt5jcef5dajidyfkpwgmdw6wyzv33itu4n6jocheg7c3@et6nax3r7kmp>
References: <20231211094329.9090-1-changhuang.liang@starfivetech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="r72e3nzso4uzxyaj"
Content-Disposition: inline
In-Reply-To: <20231211094329.9090-1-changhuang.liang@starfivetech.com>

--r72e3nzso4uzxyaj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

Thanks for the patch.

On Dec 11, 2023 at 01:43:29 -0800, Changhuang Liang wrote:
> Add enum_mbus_code ioctl so that user space can know what
> formats are supported to csi2rx.
>=20
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
>  drivers/media/platform/cadence/cdns-csi2rx.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>=20
> diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media=
/platform/cadence/cdns-csi2rx.c
> index 889f4fbbafb3..7788ce0e3171 100644
> --- a/drivers/media/platform/cadence/cdns-csi2rx.c
> +++ b/drivers/media/platform/cadence/cdns-csi2rx.c
> @@ -389,6 +389,18 @@ static int csi2rx_s_stream(struct v4l2_subdev *subde=
v, int enable)
>  	return ret;
>  }
> =20
> +static int csi2rx_enum_mbus_code(struct v4l2_subdev *subdev,
> +				 struct v4l2_subdev_state *state,
> +				 struct v4l2_subdev_mbus_code_enum *code_enum)
> +{
> +	if (code_enum->index >=3D ARRAY_SIZE(formats))
> +		return -EINVAL;
> +
> +	code_enum->code =3D formats[code_enum->index].code;
> +
> +	return 0;
> +}
> +

Tested next-20240108 + this patch, output looks good to me:
root@am62axx-evm:~# v4l2-ctl -d/dev/v4l-subdev0 --list-subdev-mbus-codes
ioctl: VIDIOC_SUBDEV_ENUM_MBUS_CODE (pad=3D0,stream=3D0)
        0x2011: MEDIA_BUS_FMT_YUYV8_1X16
        0x200f: MEDIA_BUS_FMT_UYVY8_1X16
        0x2012: MEDIA_BUS_FMT_YVYU8_1X16
        0x2010: MEDIA_BUS_FMT_VYUY8_1X16
        0x3001: MEDIA_BUS_FMT_SBGGR8_1X8
        0x3013: MEDIA_BUS_FMT_SGBRG8_1X8
        0x3002: MEDIA_BUS_FMT_SGRBG8_1X8
        0x3014: MEDIA_BUS_FMT_SRGGB8_1X8
        0x3007: MEDIA_BUS_FMT_SBGGR10_1X10
        0x300e: MEDIA_BUS_FMT_SGBRG10_1X10
        0x300a: MEDIA_BUS_FMT_SGRBG10_1X10
        0x300f: MEDIA_BUS_FMT_SRGGB10_1X10


Reviewed-by: Jai Luthra <j-luthra@ti.com>
Tested-by: Jai Luthra <j-luthra@ti.com> # [Test on sk-am62a]

>  static int csi2rx_set_fmt(struct v4l2_subdev *subdev,
>  			  struct v4l2_subdev_state *state,
>  			  struct v4l2_subdev_format *format)
> @@ -439,6 +451,7 @@ static int csi2rx_init_cfg(struct v4l2_subdev *subdev,
>  }
> =20
>  static const struct v4l2_subdev_pad_ops csi2rx_pad_ops =3D {
> +	.enum_mbus_code	=3D csi2rx_enum_mbus_code,
>  	.get_fmt	=3D v4l2_subdev_get_fmt,
>  	.set_fmt	=3D csi2rx_set_fmt,
>  	.init_cfg	=3D csi2rx_init_cfg,
> --=20
> 2.25.1
>=20
>=20

--=20
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

--r72e3nzso4uzxyaj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEETeDYGOXVdejUWq/FQ96R+SSacUUFAmWbyoAACgkQQ96R+SSa
cUV5xA/9Es54UmZG4Tshb9ZisEBlRigGb5pw5ALxLfzSXEJCdupuSkpmg0BrtyWJ
HBGn2tRPHqG9O4VzuvZehwQa3YT9RvF7ONEpcus8xR2Tf9v802F+2Q4EJwMvcMRA
57QVZSTnnjZ5DkS+OvQEV2fN7qjt1QAzdKFCj8IZr2fERo8ChIylxSdnbtIb1KFu
uDn/zgY/2c4R+XUOE73g2BBxqKeJAwsT8uriMsTyP6wWjfaHskOjH2fZVlu06RKy
5O6vzCXUQ7s7bqvdZo6Zy+cJpkXLOleotvMPjFkOV+RpyvThbbSEHIAYkKqzEsLJ
5SwcVexAfGEfSOyYFeEndrhGGQo6fv9qn1ojh7gOc6qjGGx01xop8XmB+7zjIFQN
zdtvnPIKZy6XXUrvPHeSvtmX+fNwHVsxpGk2Gg7fuYz21Bx/3fWljaL2BcWWCftE
tJ9A8JofdU6czZo6uBCoB849GNqyVwZ9E7xd/7hYxldkCPPQQ/pvdKY6QpEaCsFb
pEJ1Dc+s8eNX1bV8nK/74sCEcR6wT+VpvsppnIssan0aWfgzfzxL4po9Y2DhsqtW
5+RSVx3+CSfTDKKwHYsNy2VMO+iAWKWuJTPPHQMfye69HIric1+BOWSpPiELpGa4
UM1j+sU5gztKKt4p0xTG6oIZy53FHPShkbFujZezHJuflpeRgXU=
=2G3n
-----END PGP SIGNATURE-----

--r72e3nzso4uzxyaj--